From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17A8E3612D7 for ; Thu, 4 Dec 2025 17:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764871122; cv=none; b=dZph1CBitKeWM8dbIezE2fRvfUnRz3CZxF/7wSdL6zM4++NDPsAXpkJRSLU25tXNxAHGLFJewJM5VruTtHXrp1u9TlkaFPcA8AIg3KO9vvV1jF894Deo5Nf9508SWmCUn53fBP8Flk3KSkCKf1iL3eXrwmGrRrA3d56grPY8qIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764871122; c=relaxed/simple; bh=M61YqHUOtUork5VnW7pM/Mojz5Hm0vLf3JZ2HTVr3lo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sJMtHxAvjTBYzyElK5xNTVJcuP0dyrElW7p42b50dt903ul2F8PVVxauariHClg2ny4FVVwM2fcWy/Y4UmA0AeWGlsEWmv3xm/PFnBZBYepBEU1ne0PYpNo8B4F6egv5aln5CR4gP1e2uvw7yyHUhVw6mG2H3H2NEpyOUI6rAUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HY4ORmZL; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HY4ORmZL" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-343ea89896eso1111607a91.2 for ; Thu, 04 Dec 2025 09:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764871119; x=1765475919; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=n1pRj1+5/jO3PLLne9MyCDaDvNW1mVSp/lUv//X24Es=; b=HY4ORmZLBYzOdCUWObP7rSVJNZCX+aHieIFOY+XQnM/6dOsnZ02o7P4txafcZlkgGz 0MbNeFn0fDCTerN5bAfHfJ4Qcqd5VXxaQ8iVWSz8IIYU2P4S/uBspS2fCfqWlAxGrojq 5RRunddNABa8WgZHRxXDnN1vOnpJcHS5k7PDjFVXd4dpU86HBoNr2K/PCWTVxlKn/2oL jIBQvBRatRIVfVU/UogKDCeFlFofcWSQazAzuvl3BnDKt/+XgkxtBsy/0KOKncPDlPYV jDbCI1+Qhymnqh5+K4rap1GSp0WckFrLYv/0d/CznRy+CLPwhe8K/iPso6Vy2uA+lJJw 0p8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764871119; x=1765475919; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=n1pRj1+5/jO3PLLne9MyCDaDvNW1mVSp/lUv//X24Es=; b=Z3kPB8MVulwl+9IYI7Lx6CLonq3Dbfs9dHXELkPhcrqLVKUvlDsDWBKrOoxs0OQw/O 2PKU6zuHHXHXwo2vOjGFe1IKVUOCZwzaZ4xJbUw+lV35y0I3xMCV/PFEL1Os60hwvHvD 2zunhRoMAe0R96zhbBBMmNGclsHyJOUiMKJWIYoML+Vk7mjQQSgoeSKAAM0GXztPGX88 uaFjekq6nzeEOxFcYjRJHgqYMYg+SJraxOPvsniazySGfV5ef6ydG84DUAWDYDTLmBsT R9KmYinL/U2ZiYwVS+wVrs0hrLS0rPeenBqcHNNgr7VOiKp6xOJOOMfDMuFSTTsTbUIP ukIw== X-Forwarded-Encrypted: i=1; AJvYcCVU0KdtiTHDmoDMAlAMQHH/XbYkDJvqznuUJQCGcvXPIiTT4B0YHmMJ4mjhyiYWoPhC/e5DQtSn4bs1pOQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyDZIqVZcfjlWa7UA8q/L7kaa9ca8VaPW3JVsBVDnLvv+Rd5/Mh dR7hb6gX5RNDpUgcs9rxNkLSHQUnYQU4O+v3srSNv4m94PF1sYA6f49k X-Gm-Gg: ASbGnctGIp+OkM9Tdvg7WCKCeg07PyN610s21SvyJKFqgsJZPIgNlscchhzOE9eN3au 98AdRiLN4NRk02uiYoTsZiquvfRkMxJSoXllkqjh4Dvmzw88jmHRQGL4tekjGiI0PW8daUACxDV trKuEPwDb9xaCQfJY+CqyPyHed0cWLCK43qxMifnknVrQ1SAZ8meGerEZqug0GJiZuAnT5G1/lD 073CVzS+CvZfW3rwL7heiTYsTaWqSWuElO04gDMv1m9zgs/RUwiih3ObNeGL8HRIFXe2Oew5V+7 PgTY+N4Lr2JUgfNW/GmbWLbF7PpD8zy6z5uWd3OyW/MHX4uRgQCttkG0ltI1RXrCPcZe4vRU+lh uTB3OwPr6KAW52Px9ZE6EcWNXlwtTV5e+CO7pOtKqn7K7gkZP70d8fMtmgTofngFQgPpzGTjEB2 +Sp4JMNMjbCH30JlHvzwlmRBM= X-Google-Smtp-Source: AGHT+IHd2CViZquu8rDIVJve8lgSXsL5f4xbCLXW1g3SwVu/83f5GjAIV9Uz6obIchoDu07uphYeuw== X-Received: by 2002:a17:90b:3852:b0:335:2747:a9b3 with SMTP id 98e67ed59e1d1-349126bd337mr6610930a91.32.1764871119341; Thu, 04 Dec 2025 09:58:39 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf6817397d0sm2431869a12.6.2025.12.04.09.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 09:58:38 -0800 (PST) Sender: Guenter Roeck Date: Thu, 4 Dec 2025 09:58:37 -0800 From: Guenter Roeck To: Jakub Kicinski Cc: Shuah Khan , Christian Brauner , Elizabeth Figura , Thomas Gleixner , Eric Dumazet , Kees Cook , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, wine-devel@winehq.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Kuniyuki Iwashima Subject: Re: [PATCH 06/13] selftest: af_unix: Support compilers without flex-array-member-not-at-end support Message-ID: References: <20251204161729.2448052-1-linux@roeck-us.net> <20251204161729.2448052-7-linux@roeck-us.net> <20251204094054.01c15d1e@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251204094054.01c15d1e@kernel.org> On Thu, Dec 04, 2025 at 09:40:54AM -0800, Jakub Kicinski wrote: > On Thu, 4 Dec 2025 08:17:20 -0800 Guenter Roeck wrote: > > -CFLAGS += $(KHDR_INCLUDES) -Wall -Wflex-array-member-not-at-end > > +CFLAGS += $(KHDR_INCLUDES) -Wall $(call cc-option,-Wflex-array-member-not-at-end) > > Hm, the Claude code review we have hooked up to patchwork says: > > Is cc-option available in the selftest build environment? Looking at > tools/testing/selftests/lib.mk (included at line 14), it doesn't include > scripts/Makefile.compiler where cc-option is defined. When cc-option is > undefined, $(call cc-option,...) expands to an empty string, which means > the -Wflex-array-member-not-at-end flag won't be added even on compilers > that support it. > > This defeats the purpose of commit 1838731f1072c which added the warning > flag to catch flexible array issues. > > For comparison, tools/testing/selftests/nolibc/Makefile explicitly > includes scripts/Makefile.compiler before using cc-option. > > Testing it: > > $ make -C tools/testing/selftests/ TARGETS=net/af_unix Q= V=1 > make: Entering directory '/home/kicinski/devel/linux/tools/testing/selftests' > make[1]: Entering directory '/home/kicinski/devel/linux/tools/testing/selftests/net/af_unix' > gcc -isystem /home/kicinski/devel/linux/usr/include -Wall -D_GNU_SOURCE= diag_uid.c -o /home/kicinski/devel/linux/tools/testing/selftests/net/af_unix/diag_uid > > looks like the flag just disappears. Even tho: > > gcc version 15.2.1 Oops :). I didn't expect that, sorry. Thanks for finding! ... and I guess it's time to set up AI in my environment. Guenter