From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35955C4332F for ; Wed, 21 Dec 2022 10:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234597AbiLUKNV (ORCPT ); Wed, 21 Dec 2022 05:13:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234517AbiLUKNN (ORCPT ); Wed, 21 Dec 2022 05:13:13 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4F9015A21; Wed, 21 Dec 2022 02:13:12 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B1D1C6602CBE; Wed, 21 Dec 2022 10:13:10 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1671617591; bh=n9OD75LWbhmmE+p5PTtkkUSFONy/coTD+gGYR7GYpbk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=X8Mx8SIZzCnbeE3LdffT171/+o2OjubaXA2Kz0R4rzt2ROYvvHQHK23QwaOOMrxG9 RgXxrksd3kUKYNGamMDpIkTSWpo+nloYUaaksHGqT455U8rYXXEigxWXo+6n9ZFIBo VfGJd/2m/7nKps9oxigztO2m1xn6lRd92mvvDX1KP721TPDyUrqnJekwD8+WWLiNKt cyabcbyXsTOmRicICbyjxOCp9SYE3G9/A9pR+Kygn26Kdi5UR4MzVIjeoATQnBTGQj vYq3/RnlJJJqvptlZxMU5ZC6q7A+n2yKAfnI1hF0mC99Dpo7SduiqUjkiybKUojvxL Subs/MjIoR0tw== Message-ID: Date: Wed, 21 Dec 2022 11:13:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RESEND PATCH v4] arm64: dts: mt8195: Add Ethernet controller Content-Language: en-US To: Biao Huang , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, macpaul.lin@mediatek.com References: <20221221022523.8458-1-biao.huang@mediatek.com> <20221221022523.8458-2-biao.huang@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221221022523.8458-2-biao.huang@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 21/12/22 03:25, Biao Huang ha scritto: > Add Ethernet controller node for mt8195. > > Signed-off-by: Biao Huang > --- > arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88 ++++++++++++++++++++ > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 86 +++++++++++++++++++ > 2 files changed, 174 insertions(+) > ..snip.. > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 5d31536f4c48..02112bbf2bdf 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -1046,6 +1046,92 @@ spis1: spi@1101e000 { > status = "disabled"; > }; > > + eth: ethernet@11021000 { > + compatible = "mediatek,mt8195-gmac", "snps,dwmac-5.10a"; > + reg = <0 0x11021000 0 0x4000>; > + interrupts = ; > + interrupt-names = "macirq"; > + clock-names = "axi", > + "apb", > + "mac_cg", mac_cg goes as last clock, as specified in the binding. Order: axi, apb, mac_main, ptp_ref, rmii_internal, mac_cg. Please fix. Regards, Angelo > + "mac_main", > + "ptp_ref", > + "rmii_internal"; > + clocks = <&pericfg_ao CLK_PERI_AO_ETHERNET>, > + <&pericfg_ao CLK_PERI_AO_ETHERNET_BUS>, > + <&pericfg_ao CLK_PERI_AO_ETHERNET_MAC>, > + <&topckgen CLK_TOP_SNPS_ETH_250M>, > + <&topckgen CLK_TOP_SNPS_ETH_62P4M_PTP>, > + <&topckgen CLK_TOP_SNPS_ETH_50M_RMII>;