From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 537D21A683B; Thu, 5 Mar 2026 20:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772743605; cv=none; b=K9iTLNOBmH2YQTk1PgVqQ7Cz6MDccCWpFFbFQqWixtynUT+jvxDXfmfWkFo0z77M+OG9sHJ0sM0GlpgmjvYdFkZtvGCpuP5Fsx4+Mkz77G73II/Gd0ppOu7QXALEPEFyeXrySxF/fcWHGoLkwKFLKQgAKMEO/G3FqgyuqSBzK1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772743605; c=relaxed/simple; bh=SGc8e61EIo9usn5YlBySh3pfPc5LdpfCxn9960wqH18=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NOWajZXyAeyyyxO5ON6JY17Q/nu6fht4DQAq4ZhdFHOv22lH7coYR8fqXrRebyMMRwq6dU3lWSpngpATkNtM7Q1TjSUPUAsuo9qQnB9OzxlHM/1eP46+LHb8QhTPkqKSwUzIWiRSYscrG8m05PGPQ5+aIX+q6aUI88EPPOHwcHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=b/gaIY5J; arc=none smtp.client-ip=80.241.56.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="b/gaIY5J" Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4fRhR439vnz9tjn; Thu, 5 Mar 2026 21:46:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1772743600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G4V8xdt2Ms77ULW7U3IfZn5LVqyv124RlRFnZQs9oYw=; b=b/gaIY5Jwz9/hqRqUJTb8qsl1ucfYvAo4gnaQp5qVFix2ZdOQQ2rI4ymLpEsZZRXO4sicK WDRkBgXIB0y1iggJvLTj6JOTs6f/6TU9o+OvFxBbTVafNqbVe4ClMssGxZV1dain6k9jMN 9skHsEvsvny64kiIpT+Ycv61D6/9lV2B2I2ar370eWt5Fq83tvuVXZJqN3q+AXkP6ahtP9 eBkM6G3vbqzFMGTI3czgUl6UAa+MObHskdNOiws7pNK8lJwdgAYJZty4c6r0iK8H7VgjBf fVJDg6JyLqDfpdC6zBxuKyVr3/JK1FFi+JkQHICUV9NVe1ESw4JFHGHapvku1A== Message-ID: Date: Thu, 5 Mar 2026 21:46:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 1/2] drm/panel: simple: Add Waveshare 13.3" panel support To: Neil Armstrong , dri-devel@lists.freedesktop.org Cc: Conor Dooley , David Airlie , Geert Uytterhoeven , Jessica Zhang , Krzysztof Kozlowski , Maarten Lankhorst , Magnus Damm , Maxime Ripard , Rob Herring , Sam Ravnborg , Simona Vetter , Thierry Reding , Thomas Zimmermann , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20260117005028.126361-1-marek.vasut+renesas@mailbox.org> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-MBO-RS-ID: 5dec64b217e6840a12a X-MBO-RS-META: a4xqjz1o9gn35mckyw4atxf4oepf8tqp On 2/16/26 5:01 PM, Neil Armstrong wrote: > On 1/17/26 01:49, Marek Vasut wrote: >> Add WaveShare 13.3inch 1920x1080 DSI Capacitive Touch Display support. >> >> While the panel is described as DPI panel, it is part of a larger unit >> in non-removable metal casing, so the actual internal configuration is >> not known. The panel is attached to "waveshare,dsi2dpi" bridge via DT. >> It is likely that internally, this panel is an LVDS panel, connected to >> ICN6211 DSI-to-DPI bridge and then another unknown DPI-to-LVDS bridge. >> >> Current device link is at https://www.waveshare.com/13.3inch-dsi-lcd.htm >> >> Signed-off-by: Marek Vasut >> --- >> Cc: Conor Dooley >> Cc: David Airlie >> Cc: Geert Uytterhoeven >> Cc: Jessica Zhang >> Cc: Krzysztof Kozlowski >> Cc: Maarten Lankhorst >> Cc: Magnus Damm >> Cc: Maxime Ripard >> Cc: Neil Armstrong >> Cc: Rob Herring >> Cc: Sam Ravnborg >> Cc: Simona Vetter >> Cc: Thierry Reding >> Cc: Thomas Zimmermann >> Cc: devicetree@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-renesas-soc@vger.kernel.org >> --- >> V3: New patch. Note that the compatible string is already part of >>      Documentation/devicetree/bindings/display/panel/panel-simple.yaml >> --- >>   drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++ >>   1 file changed, 30 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/ >> panel/panel-simple.c >> index 91ab280869bac..40a73c32b0b17 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -4998,6 +4998,33 @@ static const struct panel_desc vl050_8048nt_c01 >> = { >>       .bus_flags = DRM_BUS_FLAG_DE_HIGH | >> DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE, >>   }; >> +static const struct drm_display_mode waveshare_133inch_mode = { >> +    .clock = 148500, >> +    .hdisplay = 1920, >> +    .hsync_start = 1920 + 88, >> +    .hsync_end = 1920 + 88 + 44, >> +    .htotal = 1920 + 88 + 44 + 148, >> +    .vdisplay = 1080, >> +    .vsync_start = 1080 + 4, >> +    .vsync_end = 1080 + 4 + 5, >> +    .vtotal = 1080 + 4 + 5 + 36, >> +    .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC, >> +}; >> + >> +static const struct panel_desc waveshare_133inch = { >> +    .modes = &waveshare_133inch_mode, >> +    .num_modes = 1, >> +    .bpc = 8, >> +    .size = { >> +        .width = 293, >> +        .height = 163, >> +    }, >> +    .bus_format = MEDIA_BUS_FMT_RGB888_1X24, >> +    .connector_type = DRM_MODE_CONNECTOR_DPI, >> +    .bus_flags = DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE | >> +             DRM_BUS_FLAG_SYNC_SAMPLE_POSEDGE, >> +}; >> + >>   static const struct drm_display_mode winstar_wf35ltiacd_mode = { >>       .clock = 6410, >>       .hdisplay = 320, >> @@ -5598,6 +5625,9 @@ static const struct of_device_id >> platform_of_match[] = { >>       }, { >>           .compatible = "vxt,vl050-8048nt-c01", >>           .data = &vl050_8048nt_c01, >> +    }, { >> +        .compatible = "waveshare,13.3inch-panel", >> +        .data = &waveshare_133inch, >>       }, { >>           .compatible = "winstar,wf35ltiacd", >>           .data = &winstar_wf35ltiacd, > > LGTM > > > Reviewed-by: Neil Armstrong Would it be OK to apply this now ? Thank you