From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933133AbdHVPfk (ORCPT ); Tue, 22 Aug 2017 11:35:40 -0400 Received: from foss.arm.com ([217.140.101.70]:45744 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932991AbdHVPfj (ORCPT ); Tue, 22 Aug 2017 11:35:39 -0400 Subject: Re: [PATCH v6 6/6] perf: ARM DynamIQ Shared Unit PMU support To: Jonathan Cameron References: <1503338109-32540-1-git-send-email-suzuki.poulose@arm.com> <1503338109-32540-7-git-send-email-suzuki.poulose@arm.com> <20170822121722.0000712c@huawei.com> Cc: linux-arm-kernel@lists.infradead.org, will.deacon@arm.com, marc.zyngier@arm.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org, frowand.list@gmail.com, mathieu.poirier@linaro.org, peterz@infradead.org From: Suzuki K Poulose Message-ID: Date: Tue, 22 Aug 2017 16:35:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170822121722.0000712c@huawei.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/08/17 12:17, Jonathan Cameron wrote: > On Mon, 21 Aug 2017 18:55:09 +0100 > Suzuki K Poulose wrote: > >> Add support for the Cluster PMU part of the ARM DynamIQ Shared Unit (DSU). >> The DSU integrates one or more cores with an L3 memory system, control >> logic, and external interfaces to form a multicore cluster. The PMU >> allows counting the various events related to L3, SCU etc, along with >> providing a cycle counter. >> >> The PMU can be accessed via system registers, which are common >> to the cores in the same cluster. The PMU registers follow the >> semantics of the ARMv8 PMU, mostly, with the exception that >> the counters record the cluster wide events. >> >> This driver is mostly based on the ARMv8 and CCI PMU drivers. >> The driver only supports ARM64 at the moment. It can be extended >> to support ARM32 by providing register accessors like we do in >> arch/arm64/include/arm_dsu_pmu.h. >> >> Cc: Mark Rutland >> Cc: Will Deacon >> Signed-off-by: Suzuki K Poulose > > Hi Suzuki, > > Was just reading this again out of curiosity and picked up on a couple of > really trivial things. Nothing that should slow down a merge, but if you happen > to be doing a v6... > > Driver looks good to me. > > Reviewed-by: Jonathan Cameron Jonathan, Thanks for taking a look. I will fix those issues. Suzuki