From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DCB323E23C for ; Sat, 21 Feb 2026 15:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771688937; cv=none; b=RHE58IDPjy4Mggn7YeUaapZx7bSsCB9C3oHCTTzS5KRaJNRP4TYttNl/t5jMPRIsbcivHIYJTWHnJVKT4paz+pKR8J48zL68g6BpiKS/kY37zHWqT6Kvi3NU/0pqY3/wbW3RvY8Md4Tk5Jxahu7E9Sl928hO1kUo/W6eqTTsfIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771688937; c=relaxed/simple; bh=vnWocnvA63846HhlJZBx/CXiQhYAUPkA5tMPc5pYk7Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UgaFkj5TkEtouWJNoWXbg9enYG3KmI88zBn5hxlP6yZTV6EjqAYnuGUbdEueafFwQ6LOaXBPfEomuBUMkXB6Hw4/N5FrvNY+PKIAtV3LDARngGc9yMMJWzImOet4uWZeL2hISgSRFtg0668kJeLcI4RwP/ptWy9sqO58Hil93/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BbY0ZSgp; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BbY0ZSgp" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-59dea72099eso3083504e87.0 for ; Sat, 21 Feb 2026 07:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771688933; x=1772293733; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j3y8AY1kiJvcmmu3B0A7ELwunkTenPNVCvL6Mw4W/3A=; b=BbY0ZSgpPVkFJLay3Ro6p/VnVN55WjlGMcItiFSWwIOZV+19lycXco82PrVsGH+8z6 K/ImrsA14QrlLiVNI8gOxyCaqu9PdYgHoYbKf8QKgh5DTlgAK8DRqZRdC3NmoQb6bbFj bN2l4AIYWwhfSF3H4IKHL2Ad2+TwdmsndpDbIdG4ZbRk3ImftkrbgOVDctpJY4Pny5zp 4m234IUHrLxfHqD/7r4gbKyNmoB4ZLzz88OyWF1hXIjUzqXEGdnYsdaEipVV00Qp5msI rhMrF3R2Ort9OUXYhaUGaAfzKEPSPF6/1ptXga6L8JhG8dMHKc2KvydLoqe9WntndrZD taTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771688933; x=1772293733; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j3y8AY1kiJvcmmu3B0A7ELwunkTenPNVCvL6Mw4W/3A=; b=LyqS2yLK35SyDP9PV44PhhMg6MetgplJBcCND9hVmlCHoPWYB9CdOY+CiS1gsXUHAN 7KlQonS45v+SLXqVN2zixE5dHDhns8zDkHtQb9y0Z1cIBmejo2688PrqTL3CqvC+xtJ/ SfwW1xbPvlOOaifU0QaSham8DH1D1iu+cvp6a8D+R2k9dtFfiQILSLHPoqg7mKF6Sjz8 uEW7zXSCuSZjwOs8zRaYhYzTaxQplvo+UyfYZQVPHGqzMp2i/DG3Lj1qvLHyYqiUMUt7 OJIm4QbqE5hyruwUBPHYPT02V7joXRuKCYVZT1wq409hGQNyr9FiWWli2A8Ge6mZhIZu vxMQ== X-Forwarded-Encrypted: i=1; AJvYcCVbb+BIifmDoyg1ZzXNWpI5lWY5YsmLTJhvlqLuUD2hhGcQIaM2kkEki2HHtC4wnx0g/fcQSg+a5Q3JS1E=@vger.kernel.org X-Gm-Message-State: AOJu0Yzyw9w6mMk6XtWODL2YJA5axPeb/685CGZsPbk2rJSwLMgUST4g NDx3KGeVZ9PIRI17YLe2MsWIMcUbQoodJChrNLodSrifHw7Vp1HSmxFe X-Gm-Gg: AZuq6aIUT706BHfrhPvaVVlM/PKJH9ndGjOreKiDv9lxJpjLpqXb7ArRSpnLu0MzIvL F0iXN6H4yFdeKmY9mbGyDDoP6jsQiMaNt4n8Qf7TZ+hFJkdPHsqDjZ21r3mEIDGKO+pu/hhwwTm qGWrw90KKd2ioQ1+fVxyOYxhfV/QSNa3aC2sjFpPCUCeVE0lidJ+M1xf9Fl+uSa9A7kzVpf8ny4 RslQ6VSBxqQFQlmxxOMyUmnt2wVTa+9pvjEpEnijmftXHKI621P7zg6ODzqemZrguMrWxFAoDHC iDnR4ouNgFDw0Cijd+u0D3JkDo2LS06eCNTWRws81F8bwAeS/t/o2dcB519dvTq7xl2EJWGVPt/ CnLOHlPQnLaMl50c76+vIDIeHhnNGnUwds6SQVGxHjVUpu+pjDKQYavnQb6lWNXSGocq54Jmzaa 8UyKpZ25pWfK07mrltQsdARGecGZeUo/3ET5Y= X-Received: by 2002:a05:6512:b8e:b0:59d:e774:db0e with SMTP id 2adb3069b0e04-5a0ed8a4d1fmr1017779e87.23.1771688932356; Sat, 21 Feb 2026 07:48:52 -0800 (PST) Received: from [192.168.0.131] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a0eeb0b989sm515119e87.11.2026.02.21.07.48.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Feb 2026 07:48:49 -0800 (PST) Message-ID: Date: Sat, 21 Feb 2026 16:48:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] media: v4l2-flash: Enter LED off state after file handle closed To: cy_huang@richtek.com, Mauro Carvalho Chehab Cc: Bryan Wu , Kyungmin Park , Jacek Anaszewski , roger-hy.wang@mediatek.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sakari Ailus References: <1106c60cb96786ade1f60c692e566c408d7d8174.1768209230.git.cy_huang@richtek.com> Content-Language: en-US From: Jacek Anaszewski In-Reply-To: <1106c60cb96786ade1f60c692e566c408d7d8174.1768209230.git.cy_huang@richtek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi ChiYuan, On 1/12/26 10:20, cy_huang@richtek.com wrote: > From: ChiYuan Huang > > To make sure LED enter off state after file handle is closed, initiatively > configure LED_MODE to NONE. This can guarantee whatever the previous state > is torch or strobe mode, the final state will be off. > > Cc: stable@vger.kernel.org > Fixes: 42bd6f59ae90 ("media: Add registration helpers for V4L2 flash sub-devices") > Signed-off-by: ChiYuan Huang > --- > Still cannot pass patch integration check, send v3 patch to fix all. > > v3 > - Remove 'Reported-by' tag > - Fix identation check for patch integration > > v2 > - Fix commit message redudant space cause patch robot parsing error > > Hi, > We encounter an issue. When the upper layer camera process is crashed, > if the new process did not reinit the LED, it will keeps the previous > state whatever it's in torch or strobe mode > > OS will handle the resource management. So when the process is crashed > or terminated, the 'close' API will be called to release resources. > That's why we add the initiative action to trigger LED off in file > handle close is called. > --- > drivers/media/v4l2-core/v4l2-flash-led-class.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media/v4l2-core/v4l2-flash-led-class.c > index 355595a0fefa..46606f5cc192 100644 > --- a/drivers/media/v4l2-core/v4l2-flash-led-class.c > +++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c > @@ -623,6 +623,12 @@ static int v4l2_flash_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) > return 0; > > if (led_cdev) { > + /* If file handle is released, make sure LED enter off state */ > + ret = v4l2_ctrl_s_ctrl(v4l2_flash->ctrls[LED_MODE], > + V4L2_FLASH_LED_MODE_NONE); > + if (ret) > + return ret; > + > mutex_lock(&led_cdev->led_access); > > if (v4l2_flash->ctrls[STROBE_SOURCE]) > > base-commit: 8ac28a6642d1cc8bac0632222e66add800b027fa The patch itself looks good, but while at it I started wondering if we shouldn't move below STROBE_SOURCE access before the lock. I don't see now, why we placed it there. Adding Sakari. -- Best regards, Jacek Anaszewski