From: David Ahern <dsahern@kernel.org>
To: Andrew Melnychenko <andrew@daynix.com>,
edumazet@google.com, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, jasowang@redhat.com, mst@redhat.com,
pabeni@redhat.com, yoshfuji@linux-ipv6.org
Cc: yan@daynix.com, yuri.benditovich@daynix.com
Subject: Re: [PATCH v3 1/6] udp: allow header check for dodgy GSO_UDP_L4 packets.
Date: Wed, 7 Sep 2022 18:40:56 -0600 [thread overview]
Message-ID: <f59a8400-54ba-62eb-2e9b-b8a6b7533f90@kernel.org> (raw)
In-Reply-To: <20220907125048.396126-2-andrew@daynix.com>
On 9/7/22 6:50 AM, Andrew Melnychenko wrote:
> diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
> index 6d1a4bec2614..8e002419b4d5 100644
> --- a/net/ipv4/udp_offload.c
> +++ b/net/ipv4/udp_offload.c
> @@ -387,7 +387,7 @@ static struct sk_buff *udp4_ufo_fragment(struct sk_buff *skb,
> if (!pskb_may_pull(skb, sizeof(struct udphdr)))
> goto out;
>
> - if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4)
> + if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4 && !skb_gso_ok(skb, features | NETIF_F_GSO_ROBUST))
that line needs to be wrapped.
> return __udp_gso_segment(skb, features, false);
>
> mss = skb_shinfo(skb)->gso_size;
next prev parent reply other threads:[~2022-09-08 0:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 12:50 [PATCH v3 0/6] TUN/VirtioNet USO features support Andrew Melnychenko
2022-09-07 12:50 ` [PATCH v3 1/6] udp: allow header check for dodgy GSO_UDP_L4 packets Andrew Melnychenko
2022-09-08 0:40 ` David Ahern [this message]
2022-09-08 20:10 ` Andrew Melnichenko
2022-09-07 12:50 ` [PATCH v3 2/6] uapi/linux/if_tun.h: Added new offload types for USO4/6 Andrew Melnychenko
2022-09-07 12:50 ` [PATCH v3 3/6] driver/net/tun: Added features for USO Andrew Melnychenko
2022-09-07 12:50 ` [PATCH v3 4/6] uapi/linux/virtio_net.h: Added USO types Andrew Melnychenko
2022-09-07 12:50 ` [PATCH v3 5/6] linux/virtio_net.h: Support USO offload in vnet header Andrew Melnychenko
2022-09-07 12:50 ` [PATCH v3 6/6] drivers/net/virtio_net.c: Added USO support Andrew Melnychenko
2022-09-08 0:44 ` [PATCH v3 0/6] TUN/VirtioNet USO features support David Ahern
2022-09-08 20:09 ` Andrew Melnichenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f59a8400-54ba-62eb-2e9b-b8a6b7533f90@kernel.org \
--to=dsahern@kernel.org \
--cc=andrew@daynix.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yan@daynix.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome