From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755148AbcHSPPv (ORCPT ); Fri, 19 Aug 2016 11:15:51 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:56745 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754160AbcHSPPq (ORCPT ); Fri, 19 Aug 2016 11:15:46 -0400 Subject: Re: [PATCH V2] block: Fix secure erase To: Ulf Hansson , Adrian Hunter References: <20160815181754.GA9918@lst.de> <1471334375-2585-1-git-send-email-adrian.hunter@intel.com> CC: Christoph Hellwig , linux-mmc , , "linux-kernel@vger.kernel.org" From: Jens Axboe Message-ID: Date: Fri, 19 Aug 2016 09:14:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BY2PR02CA0116.namprd02.prod.outlook.com (10.163.44.170) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: 599f63eb-39d1-40ec-8511-08d3c8438066 X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;2:H/uCpWCrM5PN6sW2QK9uFXHfa1zJ/sf6ZW1rPuYPocpmtuDdPheHZ+MWQxLu8n9rYXXyGoQiC5XJWH/OYwqWeeiwbDxl99rOCEyb4KVIVJwtqsIEFqtWVlpr/kGzS9MEM2ws28Ixlu/i4K01KVHR/5cO203qCXxuXex1LycCuvRShsz3MxvZpvf+kBAYZnUM;3:qYf1/edblJyRupHnevHKfh7HGesQsFngYqNalhT2E2rDm6erktcS/Z1giqgbeA3h+5cUpNJOio+xkREo06YY82r4qNMVkh3Ea07TkARR/97v4DuSUD0irNMvZIok9BT5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;25:Rw/5M+ILbUw9MA/vYbJ8aCxwazAek8gY9xIwe3hWEmPioiQqa+0XHo9YMOrjPH3n0dTvxFUujDe1lsPlT+7R87O+jeKc5qpfiRKKi0SghaABmcFGQ6uYnha1/uD+NLA3Baj/GMuZzpsKWTGltHnfTP9lUE543fHZ50C8zYFFNPYoIb4/IzDJbOpgOR30YCbRKFRy4b6oLnRhQK3i6vlpaglxjS7yg86SkGC7geZA9ZzNNfStnErL9MrkCipf2exAfG49QBxk6MwBNV0e7NhrsURWU1pZh5rdqhBPZoDnVUetnoTHVSYSc97Psmp2S63/81xfJD/0E52wHQzgmzksRI9Oam9RobVu5V7OfIstrv+zBxsAnDCqwm1Zq5uT38BnAX+PkhWlqUddKS0eKGgPRNUAieHjYcFe2FYQn9Y5y3kDLyi4jfBJjuyEDj2ap0XGeI1Pjr0ivzJ/36/oIkx9aXUvXw9+alDGJM8GnEC1c5GevjvXtTlAsZ1zkgOo8YhWD8hGfc/maYTLYAtishudLvNCupWF1CO6APK+u80y327oisibyMudstTmk9tSkze1RiR9xPEI49wNDeGZcmDbn4CWiSMUkTkXXH0J2x+jnzwYKgTKzFW2uBzOFeih0QUFKT3hK5qnR6VOyCvXGlHQqC5pxapdnddnIJHwfxDcb8JXng+lIt2YCc2C82kz3FZ9QYEeQZRki97jXFvrifsZE7wE/kC5n441YjL6SnwFCx1/rqKEZ0zlpW7eLfAfyRb5 X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;31:vtxWfQIixOIqZYj5NaAZTnfLZMvo+Lbiykm6h1YtPX2ua8fr35xxB9YX5DX+o5Hq911fTk95aQHMv3dfU1DBNAfix/Kv9UkPUwhIeybJhLqzckzaJQXAt+mSQbMvwYNl1TK6IN30B01k3hIGYEZ/hT2Y2Z8iu7u6D62GERtXhGeuzPwgH8q52+1Bxq2mam7QsvmaRqNVLvkIMnWc15j1mA8rAFSmiMcKSGkYY5i4e8I=;20:eJckH8maJbmclUJZuRXqjSbJr1lCFxSIfqXtdBXd7n0hk+l1aCAlIMC/q5ZP0aN6afESWWeC6N2FjK9GGDsddHQ2ZtZG1qqCT92ykOleNE7AyngDtGNhKmQXN3sQhadkh6LLZQ8mIrOXsUnSPChZ/vchABFqaXrDg5C4RieWVeo=;4:uZovWfkn2TgvcaZI+ulVWiZDiUmatunHFsGUmkLe3G5v6eUPWPrX7GC4xo9Cw1HKYZm4DFyN4WwQH5Dh9lXO1wBP0dqT6Ixsl1807taUzJaWUlQSY2omalPmHyHV4SN9Q/VBy5AkGkP4/OjXd4C0OA8XZnp0pjOyx/QdSWZENQOyq/lQTf1n9LdncFidZdA0oCYPy/UlNyMt/BQ2uqrmgOVKkSS+3EBF67FJ7BVfaycFRVykQXO7Zbe/9icV5pcStZAX6IKOyqUTaORePC+/H9Rf27+Q0fulu5PlGh87XGUks2SNXyR6iGaHAsIINkxLpgnKSWybY268I8eZ3Kl5chPiSu+H4hMtXbH6MiyaVYqEOxuzdBCFWD+UEM7e4hBLn0qRWxZ0ccJ3gUT5JrlEdHvcg/PSKkfGLnXMhNUYdnekuoTZvaDntrUPl/18Jy5R X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY4PR15MB1192;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Forefront-PRVS: 0039C6E5C5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(24454002)(199003)(377454003)(189002)(19580405001)(54356999)(7736002)(189998001)(23676002)(4001350100001)(106356001)(6116002)(3846002)(42186005)(50466002)(65956001)(33646002)(83506001)(5001770100001)(76176999)(105586002)(97736004)(305945005)(47776003)(19580395003)(7846002)(4326007)(117156001)(31686004)(31696002)(36756003)(8676002)(81166006)(50986999)(92566002)(230700001)(66066001)(2906002)(101416001)(2950100001)(586003)(81156014)(77096005)(86362001)(64126003)(65806001)(68736007)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1192;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjE1TUIxMTkyOzIzOmZVRjZFMmpod29xMmQvT25VWkFTaklLZTdP?= =?utf-8?B?N05nS1R4eUZXcDZPVXRCQ2NQOTBObTVDOXhLZko4U29GK2luWEFyenc5bjN2?= =?utf-8?B?ZUFJMU5ERHZlN3NOQWE5aUM5NW56QTJFbFhEcGRURmw4M0lwMXp1dkEwandm?= =?utf-8?B?ckFJbWFVamxuajRmVmdRbUlIK3JOUzFnMm8rYzcreEJGWEphd0NCcWhhTW9D?= =?utf-8?B?OFZCMU5QZ2dnZ0tOcEdHZU5UYitXcXd0cFFMR2ZqMGF2c1hvNUtJdWRYNXJT?= =?utf-8?B?WUQrL1hEQkxFcTlrY3I0bWNNck1qVW5Cb29ocW1aZjV1UktRVzE3QjR0c3dY?= =?utf-8?B?WWh1Kzh6N2pjcm1EaHZjUWF5RVVMNkVQUnRhbGlmNEhVU21rT0YzMi9hZkRQ?= =?utf-8?B?TklVM2F2Rk5FRVB4WU9wc0RpNHF2UCtJNmxobFdMWFJWWWtYN2UyL1NLbDBV?= =?utf-8?B?Z0hmSktlNVdVNytFdW9ERnZXODRoM0UxRlZJUjlEZmd1T2pLWlhzZG1xRlE0?= =?utf-8?B?Zy91bEJzV2tCM2RaQTR3U1dsZnd2aUVybDNtQlU4b0tmZVdVNWtjSmk4bTdr?= =?utf-8?B?MFlnVFRuSnVUZXVGbW1kTHpmRFo1Z0VhRXhqZ2pLWHIyT3hER3NVeFpMalpq?= =?utf-8?B?L1BPRHArT3lTdHdyZUZNNU5LdHBNR3pLSkl1OXA3Um11Q0JaeitxdFovQnRB?= =?utf-8?B?UHU4cmZvQXB3WW9OQ1pNcHQ3ZS91aEZNa1l4M05zZFNrN2hJMG5XeGZqcmM2?= =?utf-8?B?bDhDOWtlbCttUHRVbmF3VWNUQXBmMkZYb2lDcjhlcWkvUjhvbXlYc0phanp0?= =?utf-8?B?a2luTDQ2QUpzdlBiMzBjeHBOdEphaWJPNHRJV3E5ZCtKT0VHS3BxU3luUkQ4?= =?utf-8?B?UUtJMnhPdWNaMk43eHhua3M0T2lrTzVKVmZhMldxMi9NcEJmb0lkVTZ1YU9t?= =?utf-8?B?Q1BjYVUyRGExSlU1Mi9KS2xqbldnQnVMdjN2VFgwdkt1NSswYUNKME43M09Z?= =?utf-8?B?c3BrU3dGd1U1UGxHUmNBNkVkMkZBQjVVNlJuaHRPNFluMzAvbTg5QitVTVpF?= =?utf-8?B?YUxDV0piMCtzejZoZmtKTmxRdmdDekQrZE9zaUpwRkNYcUpWcEZqRXRsL1pX?= =?utf-8?B?QXltRmwyUm1IZno2U2E4MjNmcUpoaGFTSlJlOUtZaTdza2JqZ1FoSFBNakZT?= =?utf-8?B?RXE5eWxXZWNnWDZHRmFNZG43NDhlUmE4bHhPenlLQWRvWWdOMEtkZjIvVlNJ?= =?utf-8?B?dFJvcVRhblNVdm0wRllSQ2JWcmw4YktBS0JMSUNlZWIrWEZ2N1lFMjNCWGg0?= =?utf-8?B?WG10TEZ6KzB3YmlaejVqVTF3RGdrNFVqcGxBR3FFNFFzeElwZlRudWFXb0lE?= =?utf-8?B?bW5hN1Y3aWFLZVNUSGJMeTh4SytJdklnOGFxb0FQL1JQRkw2NUhsaHVJcUI5?= =?utf-8?B?UDRWNDVyaVZaZEJ1WDM2UzlkTVhyODBTa0xQOTNJd1FFbzhqbi9Rc1huaDY0?= =?utf-8?B?REppcGRLaFZyNmRVbElOYy9jK1RLaWhWdWhlK2FpbElIaHBVQk02WGpEWkNi?= =?utf-8?B?dEw4VDhoVVV0eFNrR0dudGFZR3JtOXNkL3dRWTRKTHpCeXI5Vk9BRldleEh3?= =?utf-8?B?V0hmTGJPSUFhR3lBenUwT2lhb24va3lRYWVRd01Ed1VEV0FZN2VWbnlCUXJm?= =?utf-8?B?M2V1UGhwekdCT1dkQ1dJa3poUTdQeHVvaGp2ZHBmRi9ickVSc2pQZlNqZ1M5?= =?utf-8?B?S0tDcjB3MFB2SVI1STh4Zz09?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;6:fDpdSM789j5DmwkMj4nkTLsfKNIYPAvJ8f+bBrM+80swuwftID6gjSuDglGR54AqICtZE4zMcU1q4S8YORm022wm2fhH77o5lKt1rVFCRy0Fc4jOIlNgNCmrWSZr8GXncOdsqG7TEYNQmL/C3FV/9cEwa4nwKJ5Uo8DlR/W0jcopkXaK+7DpDmtg8mYbC+uI9A01XiJ7FAhw246rJVVMhb8/WExxnCPDT6bnDuvOvR38VzBsQIETzfZQFjh9vvMRjm+6vVtuXrLA1zbxDyB8iz7BV5BGr7eVHXR6+Szi9qs=;5:gFo6ReL8sEHzXyZITx1+ni8plAuAlZZPRuZilzPg2oBDAlIzgnZh5+73Pr9Yel7NNXC7MRjvtlQOBZMcDI5KYmHZapm6mdI17q4hcLxZfAqf01me3dt7yAUHzJ7Q78lN204nEextjVoPJA17x5G0kw==;24:rRFzoMQs7AcutWHIJPaa3KwYlBH2U1eQ1Jn3sGwV70W9PRgPgeXdEYgnyCd0gzMi19lUrQihTb8hL6l2SJRYSzzEDK6ijbLSMmsFCGa1JKY=;7:VS6ERoqcIU/TaXP2uVObAAYbArgukKM+cf6/PD/jOulHXe3RUIQM5I2eAhSQqLzjV7G3pTTMu4zv6IXXofQpBYCV3ya8imXCht/WItXDItSG0A5jaWM6KfMrQNExRycedetsS02pTC2Sb0n1ksxVcbymsCqpVcA5kFwH2/gvYXQNFi+c4aorvfkhM5flW7VUWRoNUInwMk1wP2hOc17xGt6pzYHjxFCAHCP78yfa5l3BRLD22Xo2UO8uxeyBLelg SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;20:m/NGGOt1g4oPhvZRGMnIkS/gomWnp+E5vX5+SBsydNr0zqyRXpyFCEXTU/dLjg87ksp2p6UWGLMxDa64rEAlCZpvvdSnpcAGeUvmxKwBNZsAQZ/+yF2S0UOsXDa5iwBcffHD1ITG1WD3p6stabpLq5TGdrRTiLRdiFSlzHqaJwU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2016 15:14:22.4372 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-19_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/19/2016 05:52 AM, Ulf Hansson wrote: > On 16 August 2016 at 09:59, Adrian Hunter wrote: >> Commit 288dab8a35a0 ("block: add a separate operation type for secure >> erase") split REQ_OP_SECURE_ERASE from REQ_OP_DISCARD without considering >> all the places REQ_OP_DISCARD was being used to mean either. Fix those. >> >> Signed-off-by: Adrian Hunter >> Fixes: 288dab8a35a0 ("block: add a separate operation type for secure erase") > > For the mmc parts: > > Acked-by: Ulf Hansson > > Jens, will you pick this up via your tree? Already did, was applied 3 days ago. -- Jens Axboe