From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 017632AD37 for ; Wed, 10 Dec 2025 02:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765332713; cv=none; b=JOwj3hTA5MwmtcLJ1g+8KFGfKOB3TrK0UUjurNAetvUXnUYwOYgJ+zdPr/zb5uPuPiMUs4Hm+jQSU9dnPMQTyyNHoBM3hL9wUYizOEt1ZTA/lInR9AORLoDc2/1mhrCai/EYuRIudeCSDr7JzSdw8EZX6B3kQmTiw8LCrqMh3BE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765332713; c=relaxed/simple; bh=xnH/dYr6Tbcz5LyRL8zwdXYLOF1pAKGeDZXraGcxNOs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Uap8TsgtRsT9EiMZVbNntKSDhO90GwZuHIMVCL5pxdDc2j4D4eeZ2M3jZ6VC9rQpG5xYM88BL9ooxPQ/wdz59gKqEomcVjJPEOrsKdk+15Z3T1JsgLihHZ7ndB/iRFeyPfMVkUBp5Hx6dhajEVgiXeYva3Cvw8AeM3feuxU1JlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YYVv8sqE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Zhgud5Ys; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YYVv8sqE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Zhgud5Ys" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BA0OcDB863460 for ; Wed, 10 Dec 2025 02:11:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KPbqbtc7HcYJPrik81jdvnPoUbNPmJIJ/+tZEL/7JcU=; b=YYVv8sqE9Xs5AcEq Qk163CgGQWGEM6fhbsXe+TSe8GBJImGlDFT32xL18bEE5bab8XWUmsjBAT3sZUTu EPcbyrMi+wO/Jl/Rgpu1O+juIfhfw1/IoDJBRn5REgBGzeOsmi/6P4Q9YBl3Plv+ L9mjZriao9cTOBftIC6oE/YM8U+oRONGRStcEeiX4cuAwfRoeE1qmIApE9Qx7pLD wExfVBZYXTIWrMCq1hDEAjXoDk+KW4DE2eCuJPE7UQw6VFxU34RI7uTG7hPPCQmy Hl0JeHs01tO8f47dZK7Deh/lsmEafDUoA9uPSnAl1H0MzO6165+5FGIVeE79kXgW RzLDSQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4axjk52ukt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Dec 2025 02:11:49 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29845b18d1aso115510195ad.1 for ; Tue, 09 Dec 2025 18:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765332709; x=1765937509; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KPbqbtc7HcYJPrik81jdvnPoUbNPmJIJ/+tZEL/7JcU=; b=Zhgud5YsSrZ+z4NaLSvKJ1n3jGRva5r1Wfx4y6DNqGCm3X3SmPd1eaPwb6jwDNeBUj gUKkYWo0XnYnx7KO6Q7FBqnbYXmS4pHbYDtkrvDkpxBHsHe3er8D/7asJ/rvuIlGnKR8 lNtwsXe60ncz4s0z7bTHkgk9DP8z3qAbZ1aL8OzOr1EBNNC3HQARbSlT10nQr4mjWCqo tD9ry/4kwLRTrHDOJyV3y3K2N2opwD80mlaIueZp8l8Y1q2qK2p96Xk57fa61fHEntdI M8n25oT7UVu8VfIDha8kX+sZ3y9BOFMGCt+sIdhB14lCP/crFRUC5DY51WIpmDrWuF4J dE8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765332709; x=1765937509; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KPbqbtc7HcYJPrik81jdvnPoUbNPmJIJ/+tZEL/7JcU=; b=XuKoM1MgbjMO5MJuV70H71TDaRBGZJF1JwqGnilTgu6fvaelERTQSL4r5cE77ScMPg /NL8iQQecBigX0MQ0slqljkL5EE6jrGTzUlyrXSVTYI/ZKnyzBtkAUcmLApTaeytOR6q HqaHDIHu1IdwXtJrEe63GKbIDCMb+qKvQkKn/tW5HOlUObcPAinisMGiU92GTNZWFpVh E1nc9pOAJ0w73qIhJih53+q88lrAJBiROQbMi1KjiDTVk7P6Dpd/0BvtxAWzZs1a0unc a5aUOYy0poJ+0cSWpFYMw0O5PORANWbgcGaP+qCEfs+002jq0Wk19GYdZeD5xSCj4VZL VNlw== X-Forwarded-Encrypted: i=1; AJvYcCVElP7eOh+vBy/G7gCrIV2XxLnAiYfU70pLATY22+NlEAPxU/bd0bo4141U7FBumWYFaw2eOrjC2f2by+U=@vger.kernel.org X-Gm-Message-State: AOJu0Yya01qOabw8VCpGGoUXYVU3PsDdkgRFbW2iEglZ9Io6r+GQcbCB RzGnbJh3q9JJf5y7npdBwI4EBlQxiUwPN75gFlO3cuxuA47BfnCDIiWAxEad/hJLxyl2GGA2ww4 KuXtKBub8gSZGlhH7BW+UoFBzCEWWqS4QaWFJGWg7yuZxdD7ejgutS/KNTDsH8VnfhJY= X-Gm-Gg: AY/fxX4j21rdoitC9rplrQoBMuvIn1DT5iE55pGsNJhhhzuLmt1ZL/+6DDurAEgnbpH ngDBM2P/DjRcsT7hZirz2BT9nLxZ3/J3uBgczemWmCmu8SO1O0lz00u9muctShYhxZMVOrW2Dyp On9mPo4NNG4CaZ63UPHA3xgT24+rfJuOy4cT1gcyUG79gB8bf7YAO33+U0gXa2KxAQbtVWNDnLC g95bUvGH+gUaYgC36eMJJLkSq7WlYpsfZDE28CaXfUKO5mxqPU1qrCTcnb3F8mmteTWPncOkDzB SWPcl5ndZvLR8bP/z8w+/X+6CSlSGiqC8tGxYga+gCz16jAANdvlJrlYZ89l1w/YhTW0VHHFdvW +0AFbbaySb82iyZBxi2QcX2uoAGTeYuuj+FYoQcqbcls+gBUNZpzX5hobLpp/Qp+FWHcPvTYTzr 1Mva0c2A== X-Received: by 2002:a17:903:2311:b0:295:9cb5:ae07 with SMTP id d9443c01a7336-29ec25a7010mr7459005ad.38.1765332709204; Tue, 09 Dec 2025 18:11:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXspY0nDKRpyjv6slIy3q0/KUNCNs3aIMdRf45UIyhjR+Tt32D1VTq2WRYPh0TFXFVXlD6hA== X-Received: by 2002:a17:903:2311:b0:295:9cb5:ae07 with SMTP id d9443c01a7336-29ec25a7010mr7458745ad.38.1765332708664; Tue, 09 Dec 2025 18:11:48 -0800 (PST) Received: from [10.133.33.217] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae99fa59sm168140965ad.58.2025.12.09.18.11.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Dec 2025 18:11:48 -0800 (PST) Message-ID: Date: Wed, 10 Dec 2025 10:11:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] media: venus: vdec: fix error state assignment for zero bytesused To: Dmitry Baryshkov Cc: Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251208-fix-error-state-v2-1-255b62ee2eb6@oss.qualcomm.com> Content-Language: en-US From: Renjiang Han In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 8OKJaPeOPTV76Ohbd1CjaPKALH3ySqR4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEwMDAxNyBTYWx0ZWRfX2b97vJS0tq19 IhanxoNrylEgYhGdiuLwo5PiywhCKHrvCCi2d0Pix5OMqTjx8i1PWYzXw7h59c3Ajr2C1uND8vX eU4prjPk1A7AmYFQCenmRF9ZeRBCUciGlam13Co5DQSFz/UnjQ2C2PooWkH74a0QvQU6w81mqyQ wsMO7LLnjHLSyBqFn4+liVVXFkm2gc+li/cJ2f7UnObttNPVDrnyocOFcaZjy0DlGZ+eZDc3hR3 5O/4Yhn0JqYHWaSmnJHFFRucZ/FDeyj3Bd5vW6K+vR4xHA1YVkAzKWuquf4AUXQO8EvF53WXi4i x5/yOYeEF4a/J7/1I/Xx2XLlpLG5iuxXluCR073rl6bwUVS/SFyN/8e7EP2EqP1E9qfVM5S5rqL Bko7vTIHEE0yL+OwjFp7mhEVZiHX9Q== X-Proofpoint-GUID: 8OKJaPeOPTV76Ohbd1CjaPKALH3ySqR4 X-Authority-Analysis: v=2.4 cv=RqvI7SmK c=1 sm=1 tr=0 ts=6938d6e5 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=l48zq0wRcjR2jSCBNtYA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-09_05,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512100017 On 12/10/2025 7:11 AM, Dmitry Baryshkov wrote: > On Mon, Dec 08, 2025 at 09:03:42AM +0530, Renjiang Han wrote: >> When hfi_session_flush is issued, all queued buffers are returned to >> the V4L2 driver. Some of these buffers are not processed and have >> bytesused = 0. Currently, the driver marks such buffers as error even >> during drain operations, which can incorrectly flag EOS buffers. >> >> This patch moves the zero-bytesused check inside the non-EOS branch > Documentation/process/submitting-patches.rst, "This patch". OK, thanks for your reminder. I will update it. > >> so that only capture buffers with zero payload (and not EOS) are >> marked with VB2_BUF_STATE_ERROR. >> >> Fixes: 51df3c81ba10b ("media: venus: vdec: Mark flushed buffers with error state") >> >> Signed-off-by: Renjiang Han > No empty lines between tags. OK, thanks for your comment. I will update it. > >> --- >> This patch refines the error state assignment logic in the Venus vdec >> driver for Qualcomm platforms. Specifically, it ensures that the buffer >> state is only set to VB2_BUF_STATE_ERROR for non-EOS capture buffers >> with zero bytesused, preventing false error reporting during drain >> operations. >> --- >> Changes in v2: >> - 1. Update commit message. >> - 2. Add a Fixes tag. >> - Link to v1: https://lore.kernel.org/r/20251126-fix-error-state-v1-1-34f943a8b165@oss.qualcomm.com >> --- >> drivers/media/platform/qcom/venus/vdec.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c >> index 4a6641fdffcf79705893be58c7ec5cf485e2fab9..d0bd2d86a31f9a18cb68b08ba66affdf8fc5092d 100644 >> --- a/drivers/media/platform/qcom/venus/vdec.c >> +++ b/drivers/media/platform/qcom/venus/vdec.c >> @@ -1440,10 +1440,10 @@ static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type, >> inst->drain_active = false; >> inst->codec_state = VENUS_DEC_STATE_STOPPED; >> } >> + } else { >> + if (!bytesused) >> + state = VB2_BUF_STATE_ERROR; >> } >> - >> - if (!bytesused) >> - state = VB2_BUF_STATE_ERROR; >> } else { >> vbuf->sequence = inst->sequence_out++; >> } >> >> --- >> base-commit: 663d0d1af3faefe673cabf4b6b077149a87ad71f >> change-id: 20251126-fix-error-state-24183a8538cd >> >> Best regards, >> -- >> Renjiang Han >> -- Best regards, Renjiang Han