From: "Arnd Bergmann" <arnd@arndb.de>
To: zhang.songyi@zte.com.cn
Cc: "Robert Jarzmik" <robert.jarzmik@free.fr>,
"Lubomir Rintel" <lkundrak@v3.sk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next] pxa: Remove dev_err() after platform_get_irq()
Date: Thu, 01 Dec 2022 16:31:55 +0100 [thread overview]
Message-ID: <f5b0c1a5-58ea-4ac4-bea0-aa887d42d04a@app.fastmail.com> (raw)
In-Reply-To: <202211301556064978448@zte.com.cn>
On Wed, Nov 30, 2022, at 08:56, zhang.songyi@zte.com.cn wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
>
> /drivers/soc/pxa/ssp.c:150:2-9: line 150 is redundant because
> platform_get_irq() already prints an error
>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/soc/pxa/ssp.c | 1 -
> 1 file changed, 1 deletion(-)
I tried to apply the patch, but it appears to be whitespace damaged
and does not apply, probably something wrong with your email client.
Can you make sure you are following the steps in
Documentation/translations/zh_CN/process/email-clients.rst and
resend the patch, with Lubomir's Reviewed-by added in?
Usually the process it for platform maintainers to pick up patches,
but this time please send it directly to soc@kernel.org (since
there is already maintainer ack) and I'll pick it up from there.
Thanks,
Arnd
next prev parent reply other threads:[~2022-12-01 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 7:56 zhang.songyi
2022-12-01 6:31 ` Lubomir Rintel
2022-12-01 15:31 ` Arnd Bergmann [this message]
2022-12-01 18:15 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5b0c1a5-58ea-4ac4-bea0-aa887d42d04a@app.fastmail.com \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=robert.jarzmik@free.fr \
--cc=zhang.songyi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®