From: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
To: Nicolas Dufresne <nicolas@ndufresne.ca>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Stefan Schmidt <stefan.schmidt@linaro.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Val Packett <val@packett.cool>
Subject: Re: [PATCH] media: iris: Refine internal buffer reconfiguration logic for resolution change
Date: Tue, 4 Nov 2025 10:41:52 +0530 [thread overview]
Message-ID: <f5bc74d2-5d41-9682-68e8-fafd8953040e@oss.qualcomm.com> (raw)
In-Reply-To: <41ef734f56c0168e65e149cabf28d585ee5f2428.camel@ndufresne.ca>
On 11/4/2025 12:03 AM, Nicolas Dufresne wrote:
> Le lundi 03 novembre 2025 à 16:35 +0530, Dikshita Agarwal a écrit :
>> Improve the condition used to determine when input internal buffers need
>> to be reconfigured during streamon on the capture port. Previously, the
>> check relied on the INPUT_PAUSE sub-state, which was also being set
>> during seek operations. This led to input buffers being queued multiple
>> times to the firmware, causing session errors due to duplicate buffer
>> submissions.
>>
>> This change introduces a more accurate check using the FIRST_IPSC and
>> DRC sub-states to ensure that input buffer reconfiguration is triggered
>> only during resolution change scenarios, such as streamoff/on on the
>> capture port. This avoids duplicate buffer queuing during seek
>> operations.
>>
>> Fixes: c1f8b2cc72ec ("media: iris: handle streamoff/on from client in dynamic resolution change")
>> Reported-by: Val Packett <val@packett.cool>
>> Closes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4700
>> Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
>
> Thanks for working on this.
>
>> ---
>> drivers/media/platform/qcom/iris/iris_common.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_common.c b/drivers/media/platform/qcom/iris/iris_common.c
>> index 9fc663bdaf3fc989fe1273b4d4280a87f68de85d..21e176ce49ac2d2d26cf4fc25c1e5bca0abe501f 100644
>> --- a/drivers/media/platform/qcom/iris/iris_common.c
>> +++ b/drivers/media/platform/qcom/iris/iris_common.c
>> @@ -90,13 +90,15 @@ int iris_process_streamon_input(struct iris_inst *inst)
>>
>> int iris_process_streamon_output(struct iris_inst *inst)
>> {
>> + bool drain_active = false, drc_active = false, first_ipsc = false;
>> const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops;
>> - bool drain_active = false, drc_active = false;
>> enum iris_inst_sub_state clear_sub_state = 0;
>> int ret = 0;
>>
>> iris_scale_power(inst);
>>
>> + first_ipsc = inst->sub_state & IRIS_INST_SUB_FIRST_IPSC;
>> +
>> drain_active = inst->sub_state & IRIS_INST_SUB_DRAIN &&
>> inst->sub_state & IRIS_INST_SUB_DRAIN_LAST;
>>
>> @@ -108,7 +110,8 @@ int iris_process_streamon_output(struct iris_inst *inst)
>> else if (drain_active)
>> clear_sub_state = IRIS_INST_SUB_DRAIN | IRIS_INST_SUB_DRAIN_LAST;
>>
>> - if (inst->domain == DECODER && inst->sub_state & IRIS_INST_SUB_INPUT_PAUSE) {
>> + /* Input internal buffer reconfiguration required incase of resolution change */
>
> There is a spurious space here and also, "incase" -> "in case"
Sure, addressed in v2.
Thanks,
Dikshita
>
>> + if (first_ipsc || drc_active) {
>> ret = iris_alloc_and_queue_input_int_bufs(inst);
>> if (ret)
>> return ret;
>
> cheers,
> Nicolas
>
>>
>> ---
>> base-commit: 163917839c0eea3bdfe3620f27f617a55fd76302
>> change-id: 20251103-iris-seek-fix-7a25af22fa52
>>
>> Best regards,
next prev parent reply other threads:[~2025-11-04 5:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fvBCdCb-T9Aph_ehFVcrbBvq0WKOiNeL6BBlMNHABJCm52zzKRfEc5UpSLKfUqgzIYpKyJ1faCTYq111P2LAVg==@protonmail.internalid>
2025-11-03 11:05 ` Dikshita Agarwal
2025-11-03 18:33 ` Nicolas Dufresne
2025-11-04 5:11 ` Dikshita Agarwal [this message]
2025-11-04 10:17 ` Bryan O'Donoghue
2025-11-05 5:08 ` Dikshita Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5bc74d2-5d41-9682-68e8-fafd8953040e@oss.qualcomm.com \
--to=dikshita.agarwal@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=stefan.schmidt@linaro.org \
--cc=val@packett.cool \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®