From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77DF12853F1 for ; Tue, 30 Sep 2025 09:57:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759226228; cv=none; b=WADZZn0E5DNb2xVNuQIsf02w4CWMvuid0LsY5qbVyAfhfesZ9X15gGQ8YccB7oKCyxQeGAS/DRueUan0w5OEA+/1WiaeRf4PMwb3SWgbVPHP3NPTT/r5O9LeOSVv2FRFh+Iz2stUF5XA0IN6jugR7AZjEJNT7wwyXQ6xUtys98s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759226228; c=relaxed/simple; bh=/Z95oUaKIQLElbOUPxd1ZP1jySYZ1kdCyhXJJEW2uQM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N989KaFkef1+RKTpP1xM88AUymrnpaDpqjjSdRRblUjSEiDC5wbqdyzi3rAGzTmcQb6PwGb9Oxz2VTNZHXjuhZyg8jd8S+F3Of5SJ/DLxxpeHeQbroD4RzbMKk8x0Va6VL8/hpiHbxAD4LU3z1gfuJ7hL7XhX2YyoFlv1LWrGYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YeGC58qd; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YeGC58qd" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3b9edf4cf6cso5231180f8f.3 for ; Tue, 30 Sep 2025 02:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759226225; x=1759831025; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oufkVieZ3YIJQin86xushnEct2P0xD9SyQEmKjWVRsw=; b=YeGC58qdL+zEmpaL/Z62WiG2uZ68vk3+jJTB/pqlxJtn85pOcEsTumpaJ4qIf+Jyqj nJBM7YidpwuUHkZgzgTAQ0Lg5HNOx7QP4CjgtVpb3wzvG/nX7VPR+Gz7exovZIC8NcDj g34NdE3vJ3vYHob47NvFakn1VKF4j4dUikbBaGQcn7HAHVOwtAYM/2/6vhqAWBdgXGwf ChJNy63ygLi1fA7qYxfZMSrY+rebCWTYfZHGzPq5uRuF5Lgb/i3PEDM5Jq1ss4ekzZ0b /iJutH++vgXu0kVK4Bc5odCJIwal99DPIBXWlp38gzIHWswiYbbW0X+okEfSC39wnUDz bieg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759226225; x=1759831025; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oufkVieZ3YIJQin86xushnEct2P0xD9SyQEmKjWVRsw=; b=YPy55jQsWdG6YssIecVE37iN9jpDaHQ2GJHSKpFksyn9sDRY/2HY+kHYSChQEHIEs8 PFxj3LMC0QhDkWA5JaaDbVbHMkSrSyiQewEcbRDoT6MyjHD+4NeJklHrcvk/VWljSQo8 U6wl6XoNdQmGTp99qF7Jvsc8xkvJF6sn+qNQwOa4BcILp2jBJCa9S/pdQEipHs4MlxWv r5eKITPAdC94Zdra82s3gxVsmVQyUKkKkEUEqfe9s1L+RXK+fuv1c5M+pT55/2I27Jf1 mlBuDctj0W5UCWBr4Fai1+N2kORJb16OceMa2GsHUjVH+vNgFlIJJVgl+QjMN6x6gfOG /+4Q== X-Forwarded-Encrypted: i=1; AJvYcCUna11lA30jECFl4p8O0b6tJfNZuJCzTHW0L1Wu3wpcjT2W3DZfirr/++oQ7PlzLvMXef90Sy6OJK4d62M=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1nYYit5jZOIKACPIgRxJ1OCn4bfGIFHig285xePWcCQ0twNov +CqKf75jXiMgN2S5O6EDuiPH9xeETCl+LhZYk6owPnn03LMYoBIgoB1NhDBolh3FZac= X-Gm-Gg: ASbGnctX/P6y8HQX7VD29/VE8u/z4Eo3A1L3T8bk95mDVdCHixYVHTgMdKEMFOsZ5yo Q4KNEJO70vGXgOxS5lFMQpcBLiIXDaeZXOZqPe/sBkaNJEs+QoNgaOKIYNMKbhXDYKNkKAip4v3 8py8NkjPO+EBoAxQ0WeDXE8YSd326hUQLpIa63wHvu58e4/9oh52MDg8UV2iZHFB2CPVaPkVin2 bp9ZBY7MJ/1RhLDkazeorqzSp19SVni3b2JEBEHPrksNGI1Xm6VKKjvc2ikL4tZq7UC9Y5ncjZI r6Ts6j/shfDFipLn9HwkmYn6yzNJYI/4AJrSjMKSy7iddA6rWVlT/zfl1FmZlftD61M5NpUcD8t NNrf0Mof52g3rqeJ3ONFZBBNmgbGFD7LbIbRY6DClUO+SbJTm5cqGeg== X-Google-Smtp-Source: AGHT+IGLvmQk/pkaVh0/8LBFR3ZB3qQwoomGXzJTq6OzbBS6z/VS3gIUp+GuzV5+WUsqfER2C+K6dQ== X-Received: by 2002:a05:6000:3101:b0:3eb:df84:62e with SMTP id ffacd0b85a97d-40e46514d32mr17394824f8f.3.1759226224699; Tue, 30 Sep 2025 02:57:04 -0700 (PDT) Received: from [192.168.0.24] ([82.76.24.202]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fc5602df0sm22036410f8f.36.2025.09.30.02.57.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Sep 2025 02:57:04 -0700 (PDT) Message-ID: Date: Tue, 30 Sep 2025 12:57:02 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in Kaanapali SoC To: Raviteja Laggyshetty , Konrad Dybcio , Jingyi Wang , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-interconnect-v1-0-4c822a72141c@oss.qualcomm.com> <20250924-knp-interconnect-v1-1-4c822a72141c@oss.qualcomm.com> <70569fdf-7a3a-495a-b1ca-d35ae1963592@oss.qualcomm.com> From: Eugen Hristev Content-Language: en-US In-Reply-To: <70569fdf-7a3a-495a-b1ca-d35ae1963592@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/30/25 06:06, Raviteja Laggyshetty wrote: > > > On 9/25/2025 6:10 PM, Konrad Dybcio wrote: >> On 9/25/25 10:57 AM, Eugen Hristev wrote: >>> >>> >>> On 9/25/25 02:02, Jingyi Wang wrote: >>>> From: Raviteja Laggyshetty >>>> >>>> Document the RPMh Network-On-Chip Interconnect of the Kaanapali platform. >>>> >>>> Signed-off-by: Raviteja Laggyshetty >>>> Signed-off-by: Jingyi Wang >>>> --- >> >> [...] >> >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - qcom,kaanapali-aggre-noc >>> >>> Hi, >>> >>> Does Kaanapali have a single aggre node, or there are several ? >>> On previous SoC, I see there are two (aggre1 and aggre2). >>> Also in your driver (second patch), I notice aggre1_noc and aggre2_noc . >>> It would make sense to accurately describe here the hardware. >> >> They're physically separate >> > Yes, they are physically separate but the topology treats them as a single noc > with two slave connections to system noc which you have noticed in the topology file. Is it any difference from previous sm8750 where there are two nodes ? If yes, can you mention the difference and reasoning for merging them into a single node. If no, can you reason why the decision to merge them into a single node this time instead of keeping it consistent ? > > Thanks, > Raviteja. > >> Konrad