From: Andrew Lunn <andrew@lunn.ch>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [RFC PATCH 2/2] net: phy: dp83869: fix mii mode when rgmii strap cfg is used
Date: Thu, 27 Apr 2023 14:04:03 +0200 [thread overview]
Message-ID: <f5c5b4e6-c0a6-4782-b1a7-822df6369cc4@lunn.ch> (raw)
In-Reply-To: <cce70be8-4d2a-1499-fea5-5efa6c5f1420@ti.com>
> > If you say so. I was just thinking you could give the poor software
> > engineer a hint the hardware engineer has put on strapping resistors
> > which means the PHY is not going to work.
>
> I understand now. I will update this patch to add a print if the MII mode is not
> valid with the configured "dp83869->mode". Would you suggest using a dev_err()
> or a dev_dbg()?
dev_err(). And you can return -EINVAL when asked to set the interface
mode.
Andrew
prev parent reply other threads:[~2023-04-27 12:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 5:44 [RFC PATCH 0/2] DP83867/DP83869 Ethernet PHY workaround/fix Siddharth Vadapalli
2023-04-25 5:44 ` [RFC PATCH 1/2] net: phy: dp83867: add w/a for packet errors seen with short cables Siddharth Vadapalli
2023-04-25 12:05 ` Andrew Lunn
2023-04-26 5:09 ` Siddharth Vadapalli
2023-04-26 12:36 ` Andrew Lunn
2023-04-27 4:02 ` Siddharth Vadapalli
2023-04-25 5:44 ` [RFC PATCH 2/2] net: phy: dp83869: fix mii mode when rgmii strap cfg is used Siddharth Vadapalli
2023-04-25 12:18 ` Andrew Lunn
2023-04-26 5:49 ` Siddharth Vadapalli
2023-04-26 12:41 ` Andrew Lunn
2023-04-27 4:08 ` Siddharth Vadapalli
2023-04-27 12:04 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5c5b4e6-c0a6-4782-b1a7-822df6369cc4@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®