From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45219C2D0A3 for ; Tue, 10 Nov 2020 01:54:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EACDA2078D for ; Tue, 10 Nov 2020 01:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730284AbgKJByM (ORCPT ); Mon, 9 Nov 2020 20:54:12 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:7509 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbgKJByL (ORCPT ); Mon, 9 Nov 2020 20:54:11 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CVWB14tvvzhjvx; Tue, 10 Nov 2020 09:54:01 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 10 Nov 2020 09:54:08 +0800 Subject: Re: [f2fs-dev] [PATCH v4 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE To: Eric Biggers CC: Chao Yu , , , References: <20201106065331.76236-1-yuchao0@huawei.com> <20201106180324.GA78548@sol.localdomain> <20201107171635.GA841@sol.localdomain> <63efaa5c-bc19-4b16-653d-840bc6a6d9d1@huawei.com> <20201109181204.GA1232946@gmail.com> From: Chao Yu Message-ID: Date: Tue, 10 Nov 2020 09:54:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201109181204.GA1232946@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/10 2:12, Eric Biggers wrote: > On Mon, Nov 09, 2020 at 10:29:25AM +0800, Chao Yu wrote: >>> Oh I see, the cp-related checks are at the beginning of f2fs_ioctl() too. >>> >>> In that case a much better approach would be to add __f2fs_ioctl() which is >>> called by f2fs_ioctl() and f2fs_compat_ioctl(), and have f2fs_ioctl() and >>> f2fs_compat_ioctl() do the cp-related checks but not __f2fs_ioctl(). >> >> Will this cleanup make sense to you? > > I think it would be better to do it the way I suggested. Updated in v5. Thanks, > > - Eric > . >