From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF3B918A925; Mon, 11 Nov 2024 11:51:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731325919; cv=none; b=W2Ab9smrus1h+a4OT+Ze6zClfjJEg1/xiFHAAkkreA26pS5o1QbRlMMCvDEPbF1Nsts8UjhhRWzqLZZwM/psbp8LDe3Uc2oMnPWpK0QoC+X/2xDgRxmdo8GDeKh4LDrjmc/GshS60trlNOVozb0xHOVn1VhiE5B5NHIKOEu1DVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731325919; c=relaxed/simple; bh=2ZRdE/hklbN5yxNc4Bd8fkZA0OS4OFNYOt3zUxtbBFA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=n8dC0ETXGbIjoSuG9ciSQ228yHzNmJNTlGhpywW4NdxULy4Ay7pV7Cgr3qHDWltLJWGIbJ0jMivwNX3NhsDkS2kJar6CH8+4lqNMYRlgu75qKhMruGcLHEqJUCQOBc7BsESGT9u0Whdeimw5HGpa+n0ht7VzyI5OfjkAj8hB7bI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=lip2pPS+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="lip2pPS+" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AANhedH030322; Mon, 11 Nov 2024 11:51:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pi0JfNWi1w0WIDh6nzdtsGpavJ1rJC8KJdmTr5MweWo=; b=lip2pPS+DL/PkDGO 0yoB7G1TIsNWXxL2yHhjhWja+zU0Entp9Vcs/05BYsAR+SyMFW5NyRLR4cL4y5/+ 7ABGKzOuel5CfhyUHKkzlUTx75qHP2sgVwKj7QCBAyFksFYxe5x36Z1qwWin9hQa F1+AOnTLzWKRTjeH/WRrDGhX6WMQRKC7P/Xr7pyXrLMeKIm6TNUFOts7WtYDJZPz MznZE2yquEOXHgR4Mjy9kwZgDIEb+6MElsU5i7NdBAlfiGx+5Pqoj1QBYQwrExUj DoLNycWZ1PpqSdvt+AbLtzXFXEvL9dyn3ccKX4Myh2KEgoLOWa6MBcDxQbVGI83P pHke3w== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42sytsm4ds-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Nov 2024 11:51:34 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4ABBpX3o016228 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Nov 2024 11:51:33 GMT Received: from [10.152.195.140] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 11 Nov 2024 03:51:27 -0800 Message-ID: Date: Mon, 11 Nov 2024 17:21:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/7] arm64: dts: qcom: ipq5424: Add thermal zone nodes To: Konrad Dybcio , Konrad Dybcio , , , , , , , , , , , , , , , , CC: , References: <20241104124413.2012794-1-quic_mmanikan@quicinc.com> <20241104124413.2012794-8-quic_mmanikan@quicinc.com> <91ea0f03-9bbe-491d-9056-ebd9fdc73bfa@oss.qualcomm.com> <8cb665f5-4885-4853-804a-7313decc719c@quicinc.com> <2c7ece9d-95e8-4d01-a9da-c1d5d7388771@gmail.com> <9bd3d4e2-aba1-423c-946a-f5c60da71497@oss.qualcomm.com> Content-Language: en-US From: Manikanta Mylavarapu In-Reply-To: <9bd3d4e2-aba1-423c-946a-f5c60da71497@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: B0ib5jzU4Lmhg0zbaLwMvGAC_4moaKeL X-Proofpoint-ORIG-GUID: B0ib5jzU4Lmhg0zbaLwMvGAC_4moaKeL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411110100 On 11/7/2024 8:17 PM, Konrad Dybcio wrote: > On 6.11.2024 11:25 AM, Manikanta Mylavarapu wrote: >> >> >> On 11/6/2024 2:42 PM, Konrad Dybcio wrote: >>> >>> >>> On 11/6/24 09:47, Manikanta Mylavarapu wrote: >>>> >>>> >>>> On 11/4/2024 7:21 PM, Konrad Dybcio wrote: >>>>> On 4.11.2024 1:44 PM, Manikanta Mylavarapu wrote: >>>>>> Add thermal zone nodes for sensors present in IPQ5424. >>>>>> >>>>>> Signed-off-by: Manikanta Mylavarapu >>>>>> --- >>>>> [...] >>>>> >>>>>> + >>>>>> +        cpu3-thermal { >>>>>> +            polling-delay-passive = <0>; >>>>>> +            polling-delay = <0>; >>>>>> +            thermal-sensors = <&tsens 13>; >>>>>> + >>>>>> +            trips { >>>>>> +                cpu-critical { >>>>>> +                    temperature = <120000>; >>>>>> +                    hysteresis = <9000>; >>>>>> +                    type = "critical"; >>>>>> +                }; >>>>>> + >>>>>> +                cpu-passive { >>>>>> +                    temperature = <110000>; >>>>>> +                    hysteresis = <9000>; >>>>>> +                    type = "passive"; >>>>> >>>>> You have a passive trip point without passive polling >>>>> >>>> >>>> Okay, will remove this. >>> >>> You most likely want to preserve it, while keeping a sensible >>> polling frequency, so that userspace will be aware of the current >>> CPU temperature. <100> sounds like a sensible value here. >>> >>> Konrad >> >> Temperature sensor's present in IPQ5424 supports interrupts. > > Correct. > >> Hence no need to configure polling frequency. > > No, that interrupt firing signifies crossing the temp threshold (meaning > no updates beyond that) or the tsens watchdog barking. > > Konrad An interrupt fires when the temperature crosses a threshold. Thanks & Regards, Manikanta.