From: David Lechner <david@lechnology.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Adam Ford <aford173@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v3 1/3] ARM: dts: da850: add cpu node and operating points to DT
Date: Mon, 8 Apr 2019 08:55:17 -0500 [thread overview]
Message-ID: <f5d08299-8cc5-e70e-fc14-e172be544168@lechnology.com> (raw)
In-Reply-To: <CAMRc=Mf7tT1j5n8kM4TJXy7sHYmyfu8DTOwMKwo-d3VG4qOXgQ@mail.gmail.com>
On 4/8/19 8:51 AM, Bartosz Golaszewski wrote:
> pon., 8 kwi 2019 o 15:47 David Lechner <david@lechnology.com> napisał(a):
>>
>> On 4/8/19 2:59 AM, Bartosz Golaszewski wrote:
>>> From: David Lechner <david@lechnology.com>
>>>
>>> This adds a cpu node and operating points to the common da850.dtsi file.
>>>
>>> Additionally, a regulator is added to the LEGO EV3 board along with
>>> some board-specific CPU configuration.
>>>
>>> Regulators need to be hooked up on other boards to get them working.
>>>
>>
>> I still have the same comments that I made on v1. It would be nice to
>> also mention the LCDK board in the commit message since it is included
>> in this patch.
>>
>
> My bad, I forgot it.
>
>> Also, the 415MHz operating point is something I just made up for testing
>> and I'm not sure that it is actually useful in general. It could be
>> omitted from this patch.
>>
>
> The board file has the 408 opp, I guess this is in line with other
> operating points defined by you which have slightly higher frequencies
> than those in the da850.c. Let's see what Sekhar thinks.
>
> Bart
>
My bad this time. I guess I put more thought into it that I remembered.
:-)
next prev parent reply other threads:[~2019-04-08 13:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 7:59 [PATCH v3 0/3] ARM: da850: enable cpufreq in DT mode Bartosz Golaszewski
2019-04-08 7:59 ` [PATCH v3 1/3] ARM: dts: da850: add cpu node and operating points to DT Bartosz Golaszewski
2019-04-08 13:47 ` David Lechner
2019-04-08 13:51 ` Bartosz Golaszewski
2019-04-08 13:55 ` David Lechner [this message]
2019-04-12 11:26 ` Sekhar Nori
2019-04-12 12:11 ` Bartosz Golaszewski
2019-04-12 13:53 ` Sekhar Nori
2019-04-12 15:31 ` Bartosz Golaszewski
2019-04-15 10:21 ` Sekhar Nori
2019-04-15 11:54 ` Bartosz Golaszewski
2019-04-15 13:02 ` Adam Ford
2019-04-16 8:37 ` Bartosz Golaszewski
2019-04-16 11:48 ` Adam Ford
2019-04-17 8:15 ` Sekhar Nori
2019-04-16 14:38 ` David Lechner
2019-04-17 8:24 ` Sekhar Nori
2019-04-08 7:59 ` [PATCH v3 2/3] ARM: dts: da850-evm: enable cpufreq Bartosz Golaszewski
2019-04-12 13:06 ` Sekhar Nori
2019-04-12 13:09 ` Bartosz Golaszewski
2019-04-12 13:59 ` Adam Ford
2019-04-12 14:23 ` Bartosz Golaszewski
2019-04-08 7:59 ` [PATCH v3 3/3] ARM: davinci_all_defconfig: Enable CPUFREQ_DT Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5d08299-8cc5-e70e-fc14-e172be544168@lechnology.com \
--to=david@lechnology.com \
--cc=aford173@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®