From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57C65233922 for ; Thu, 9 Jul 2026 12:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783601910; cv=none; b=swmyKxYONSYPwemFyyKoN7qofOKoT61+Oy2tqC5oDQdGJHJS+LgLc21k1XQMw0fEt88fljygI++Z697KptDVkZ76+XN4Lw0E4JUSwg6IWX94fb0uV9VstoInTgVvlouTBNNZhbR26eS2bqB6ATlBK1ueYwor/dGtsjlOTx5GXuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783601910; c=relaxed/simple; bh=2ncECmYmGOQWfSlXNAejUij+wOyeq+XTZ9+N+2uYujk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AK6qUB9Cl3OoGoaQGL4MW7ICZTbX6Rss9OSrLxCliqtzwUMgtFtFpzukVEi7I+aW6dWy1V7vhh/FzVGg4iZo3gpBFEinOIjXo3yOwwdyqZkDpfdrTue3SK4sl18pYZOxI4i/GHcoEoghhPpcZGPf1BglZGr7AJIrqX8zLZK74to= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QRO6rqNL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T6J2JnOD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QRO6rqNL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T6J2JnOD" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 669BNMP51626137 for ; Thu, 9 Jul 2026 12:58:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6M8ToX+cI6vvxtv01dKbu6llFvdM/QyNtn4NMUQwymw=; b=QRO6rqNL7ngIgGWG nH0n7MpLDek89Qgyo3Blz1K2m2/sUbLwWsEDUjFyy42oMSg00tQDMo537C2FhCOG T1UaM9f+Rm+QYF5F2nci63FIqFkzmcslRqWQVHvD/Shq8b/zH+1aBY8rIMqN7Dua ciYb+EojJCnMQfrVeOvpknX3R1iqigaK1dL4bvOLT9x1XZNae5+8H3+Oip0ugasZ 66SPN4RNPHMrANPv/vrvelv2i8kDBWYRknEq2tKVsE80jCh4FeOTmtqLydTGilLF n03R8CeU45slUU74D3Zfvmceuc6xrFcF3i/pACZuXc82NnN3r37S9Id9sCtPFSDY qUHTEQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9rq34ny9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Jul 2026 12:58:28 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e6cb57d25so63310785a.3 for ; Thu, 09 Jul 2026 05:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783601908; x=1784206708; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6M8ToX+cI6vvxtv01dKbu6llFvdM/QyNtn4NMUQwymw=; b=T6J2JnODd8SbPyBrFw+TKQHp+2h3AzfpoiNhfyYxAe9RYzrriOoFUTi0ZN5E/3JvpY 9aLz7e3Fo10n9H+2RzB95UR6UM77vqDJ9g56pJyqVC3zojl35E8UgKxOfK2YTIxsnjPB ib8cxZRIIQ2WBn8W+VLZ8tEy2nidG6vwo61XiGNdfun1+TaD1qeZwTQAIwtX7jEPYtsq q2IdGG/hwxxNEpM4Mg5MTrbxw14QSocvh3iIOZeBy1gmL8fdvd5Qk09Q2DvGZkXsZyLq XbHYtSmXMQuk1J4ZIX9tTET+QHt4nhSXISluA+LVepaXoNy0Q8+KUDJ7pcKU5ejRBk2c 3/sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783601908; x=1784206708; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6M8ToX+cI6vvxtv01dKbu6llFvdM/QyNtn4NMUQwymw=; b=fM3thY8uMBMQK+i1MZcwx25JgTyB4mRt8HfL6Z/L4+UraWLLMx9f24+QEPZ1ZhnC0r SdQpZV4o0ZS5/6rH+5aC6yXloC586LBuAmz5tLC+W6jhnUG8n5DbFBzHWmF+NaE1iAln KejID9FQWuKQum4ZquDjoPJEBG1hqZfYPq1znRQtyOmsWvLyAjFYDkSwJxS5FJTt7Olg 7YxyBZfFklysSziCJykiMwI29R4yCpk8jrlz/vBQLmLjgv/inn/akJ8g6Hf4T5xGmYFq U1kntB7bMMboLHsuLEieW5x7lGxOvJaPfBkKGPnvAlsPzX8lnGN318nigZ1KMFvKcF7R yOrA== X-Forwarded-Encrypted: i=1; AHgh+RpejBEbVnK5eLOc10qbewQSL7Z27ap8TwFJi2awd9lEWRoRYi6SOBXtkgXAnpNRFusnGxSiHDcHC0I9Vcc=@vger.kernel.org X-Gm-Message-State: AOJu0YxFDmL+Wpf6eEY1DKi9C01uc5TzrZGXZsvkCBMHjjtm8yWKSB/B uO9CoXzq/cDpVHeINfZRuIG7FICaqKY3BzbajyxzgnxxMVOhSj7vO2VCXK+bN2+FvJKtKr93RX5 H6DGrdN7ag4t4uW9kYVTQxiiXGC4vu3AUYBNAcvVr4kvdZiXMXIBcNN1V5uFjdZiuqNs= X-Gm-Gg: AfdE7cm/LtQ8MKH5dlMlRpEjf2PBder+dJrWrHeUz9QKxJfixEfVHlTz9rtqYlz7WJ2 sU5B1wXxOECe9T2c02mm5h5yawBkKFHe5V9lR062bubOiLKJLTMTK0J+ActjlfqMjpkcEV/lAzS 9pmupHie6/tlEO4k0jpaHVphHzj4mdwg4HsZiWCnWfOOxqDmu+Y4sLTYUIHmUEJdPk0GmZEQ+AR sBTqvpijsgEBJg+Y+n3V43txu2+rgQsQFkGcf/qpx8VO6MB0LzPgxq5HWvMPlpKEx0NQzQJ/cPW xoYhx8759ew6uuUkV2CFEpGfn7axxtrcfL6pZaVhtwOXL3VgOPTgmIqVEgPsPPrf5VTHiUEER0V N5giZE416bu+2xTRMP8BK9Ixdrpq7LR7JyXo= X-Received: by 2002:a05:620a:178f:b0:92e:7436:5284 with SMTP id af79cd13be357-92ed7a1c5cemr287075585a.5.1783601907665; Thu, 09 Jul 2026 05:58:27 -0700 (PDT) X-Received: by 2002:a05:620a:178f:b0:92e:7436:5284 with SMTP id af79cd13be357-92ed7a1c5cemr287073385a.5.1783601907084; Thu, 09 Jul 2026 05:58:27 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15c6bd0d72sm296238466b.7.2026.07.09.05.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 05:58:26 -0700 (PDT) Message-ID: Date: Thu, 9 Jul 2026 14:58:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] powercap: qcom: Add SPEL powercap driver To: Manaf Meethalavalappu Pallikunhi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Bjorn Andersson , Konrad Dybcio , Daniel Lezcano Cc: Gaurav Kohli , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20260702-qcom_spel_driver_upstream-v3-0-434d50f0c5b0@oss.qualcomm.com> <20260702-qcom_spel_driver_upstream-v3-3-434d50f0c5b0@oss.qualcomm.com> <21f13da7-94ee-4eb2-b2bd-6200d70f38f9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <21f13da7-94ee-4eb2-b2bd-6200d70f38f9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: skfyREltT24L2PkJegehVR_kBGgUOejg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA5MDEyNyBTYWx0ZWRfX+uM0M2zT+v2w 857hP/1kUPS6ULNaaxCwxRhF2k/6ZAOnv1RMvuiSDMeQnCntAcyc0eiiAnt7WQuRRP2lE5l8Zsl Zfx9XK8/Fx30DhNWWrOm2MT84R38NYhHi02MMGp9jXfwoNu1XHOlCsovKfqVhavHHbxaGU2OHpk +7Hwi2keahFaeBay3RNdX3LCbRJFqSnzxYjKBN1+llNVzL7R0lf7GwDlMFfVpXRuWvBmX4c8BQj 8wWT6yNpN5uTwo6UGhm5lNm3Zh2tc1vmVB1kL4uVtHhXvrbaplWF5b5ri3gkdjgVjDXi1zRw08N UGeqMvPaDFktv0rgpkKLXMuTdJOfULvl2EgGPsPWgd0mSVsdHv92O/KyQyuW0MoT8pbFObEmGa3 gJjJMy55QwbllRlAyaXlHn6zSvl1oqT/k+KyZiHsL8E71ngoxLxnSZmbi4KkFZ1UgVWKSR5+p1o iFT5iWDTzSML3J4MsCg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA5MDEyNyBTYWx0ZWRfX/lz9gyLp6cKr /JI+JU+BHqWfjF0teG1olu8LE9u6EP7dLf0yUV8r6GtIVnltIjEPPhCpVEViWOBYrA+Bb6vyoPG 39K9w3THs585SLbie6A94L7Ug48N3Kc= X-Authority-Analysis: v=2.4 cv=PYPPQChd c=1 sm=1 tr=0 ts=6a4f9af4 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=fz3elM8aSJ4FunxCNjAA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: skfyREltT24L2PkJegehVR_kBGgUOejg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_02,2026-07-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607090127 On 7/6/26 1:57 PM, Konrad Dybcio wrote: > On 7/2/26 7:22 PM, Manaf Meethalavalappu Pallikunhi wrote: >> The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware >> based power monitoring and limiting capabilities for various power >> domains including System, SoC, CPU clusters, GPU, and various other >> subsystems. >> >> The driver integrates with the Linux powercap framework, exposing SPEL >> capabilities through powercap sysfs interfaces. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi >> --- > > [...] > >> +#define TIME_WINDOW_MASK_L GENMASK(14, 0) >> +#define TIME_WINDOW_MASK_H GENMASK(22, 16) >> +#define TIME_WINDOW_MAX ((FIELD_MAX(TIME_WINDOW_MASK_H) << 15) | \ >> + FIELD_MAX(TIME_WINDOW_MASK_L)) > > I am having difficulty correlating this mask to the register > description I have available. Are you sure what you call > TIME_WINDOW_MASK_L actually exists? > > [...] > >> +/* Constraint configuration */ >> +static const struct spel_constraint_info constraints[] = { >> + /* SYS domain constraints */ >> + { 0x10, 0x70, BIT(0), SPEL_DOMAIN_SYS, POWER_LIMIT1 }, >> + { 0x14, 0x74, BIT(1), SPEL_DOMAIN_SYS, POWER_LIMIT2 }, >> + { 0x18, 0x78, BIT(2), SPEL_DOMAIN_SYS, POWER_LIMIT3 }, >> + { 0x1c, 0x7c, BIT(3), SPEL_DOMAIN_SYS, POWER_LIMIT4 }, >> + /* SoC domain constraints */ >> + { 0x00, 0x60, BIT(4), SPEL_DOMAIN_SOC, POWER_LIMIT1 }, >> + { 0x04, 0x64, BIT(5), SPEL_DOMAIN_SOC, POWER_LIMIT2 }, >> + { 0x08, 0x68, BIT(6), SPEL_DOMAIN_SOC, POWER_LIMIT3 }, >> + { 0x0c, 0x6c, BIT(7), SPEL_DOMAIN_SOC, POWER_LIMIT4 }, > > Similarly, these offsets are difficult for me to correlate with the > register names in the constraints/0x0ef3_d000 space They are apparently correct, I had outdated information at hand Konrad