From: Weiping Pan <panweiping3@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Weiping Pan <panweiping3@gmail.com>
Subject: [PATCH net] bonding: send igmp report for its master
Date: Mon, 12 Mar 2012 16:40:46 +0800 [thread overview]
Message-ID: <f5d199e12d78dadcfb932e103984276d36b186e0.1331539261.git.panweiping3@gmail.com> (raw)
Liang Zheng(lzheng@redhat.com) found that in the following topo,
bonding can not send igmp report.
eth0--
|-- bond0 -- br0
eth1--
modprobe bonding mode=1 miimon=100 resend_igmp=10
ifconfig bond0 up
ifenslave bond0 eth0 eth1
brctl addbr br0
ifconfig br0 192.168.100.2/24 up
brctl addif br0 bond0
Add 192.168.100.2(br0) into a multicast group, like 224.10.10.10,
then trigger a fali-over in bonding.
You can see that parameter "resend_igmp" does not work.
The reason is that when we add br0 into a multicast group,
it does not propagate multicast knowledge down to its ports.
If we choose to propagate multicast knowledge down to all ports for bridge,
then we have to track every change that is done to bridge, and keep a backup
for all ports. It is hard to track, I think.
Instead I choose to modify bonding to send igmp report for its master.
There is a problem in this patch, in the following topo,
bonding will send duplicate igmp reports.
bond0--
|-- bond2
bond1--
The reason is that I do not check whether master_dev is a bridge or a bonding.
I prefer to skip such check, since this topo is rare.
And if we add such check, then for every kind of virtual device,
we should check whether bonding can be a slave of it,
and if we add a new virtual device, we have to add a check in bonding, too.
Signed-off-by: Weiping Pan <panweiping3@gmail.com>
---
drivers/net/bonding/bond_main.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 435984a..300c490 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -794,6 +794,14 @@ static void bond_resend_igmp_join_requests_delayed(struct work_struct *work)
{
struct bonding *bond = container_of(work, struct bonding,
mcast_work.work);
+ struct net_device *bond_dev, *master_dev = NULL;
+ bond_dev = bond->dev;
+ master_dev = bond_dev->master;
+
+ if (unlikely(master_dev)) {
+ __bond_resend_igmp_join_requests(master_dev);
+ }
+
bond_resend_igmp_join_requests(bond);
}
--
1.7.4.4
next reply other threads:[~2012-03-12 8:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 8:40 Weiping Pan [this message]
2012-03-14 13:58 ` [PATCH net V2] " Cong Wang
2012-03-14 17:22 ` Andy Gospodarek
2012-03-15 3:11 ` [PATCH net V3] " Weiping Pan
2012-03-16 3:43 ` Jay Vosburgh
2012-03-16 13:38 ` Andy Gospodarek
2012-03-18 3:23 ` [PATCH net V4] " Weiping Pan
2012-03-19 22:06 ` David Miller
2012-03-17 5:58 ` [PATCH net V2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5d199e12d78dadcfb932e103984276d36b186e0.1331539261.git.panweiping3@gmail.com \
--to=panweiping3@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®