From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>, cocci@inria.fr
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Nicolas Palix <nicolas.palix@imag.fr>,
Ricardo Ribalda <ribalda@chromium.org>
Subject: Re: [cocci] [PATCH] coccinelle: scripts: coccinelle: devm_free: reduce false positives
Date: Mon, 10 Aug 2026 09:05:42 +0200 [thread overview]
Message-ID: <f5da5fe4-c10f-4a33-9910-55a6b2618e00@web.de> (raw)
In-Reply-To: <27fd1773-a8ba-afe3-1cb6-51e4bc94d641@inria.fr>
>>> False positives could be introduced due to allocations using the new
>>> _obj functions. Add these to the "safe" rule accordingly.
>>
>> Can the SmPL disjunction specification be refined another bit?
>
> As usual, a random comment with no context that makes the reader have to
> go look up some other information to have any idea what you are talking
> about.
How hard is it to determine technical details for a running patch review?
> Anyway, since I did take several minutes to go find the file and look at
> it,
You propose to adjust some SmPL code.
> I guess you want the disjunctions to be ordered by frequency in the
> code base.
I imagine that such a design possibility can become helpful.
> But I'm not going to do that.
I assume that further contributors would occasionally like to benefit
more from nicer run time characteristics also for Coccinelle software.
https://en.wikipedia.org/wiki/Short-circuit_evaluation
Can SmPL code become a bit more succinct accordingly?
Regards,
Markus
next prev parent reply other threads:[~2026-08-10 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-09 16:53 Julia Lawall
2026-08-10 6:40 ` [cocci] " Markus Elfring
2026-08-10 6:48 ` Julia Lawall
2026-08-10 7:05 ` Markus Elfring [this message]
2026-08-10 14:24 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5da5fe4-c10f-4a33-9910-55a6b2618e00@web.de \
--to=markus.elfring@web.de \
--cc=cocci@inria.fr \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®