From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3597E3E6DEB for ; Tue, 17 Mar 2026 14:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773757977; cv=none; b=c88bxbghchSCd8C5hszsT+ztiDU/PSQ1/IQGH6c/NTQn+cDeFNVfEEIQ+4G6dFNxqOYzuoIdXoNg7PpaHoEdjeDyJ7SnHKWYYmC1hO5VAvUcTxOQ6hdXxAGUhE2F6TkaYtra90LTnDWEI0aTi6vMeHy9yYni/NLcgh+QvpQ3CdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773757977; c=relaxed/simple; bh=UQhy86RBpO6F0poicol7tkVEH4GfMsaYZqbSFAbiD4Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V491LMESK62SwiCEBG+KfpfH9WqOAQ1ze3kkkGc1+uTC+s+JC35SSm9GbsHU83xK+HvRa3RCUy8vbYsjiMpq+C6weINyOGBaYWk+RqXnuJB+c/xm4RxNrSMqq9cArXfC1NAbmtEPLZlfq/4uvMNvJowjpdASbHAMoksSfNnb6gE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M2Z7fOOM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gwgGlpAO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M2Z7fOOM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gwgGlpAO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773757975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8D9W6spqw8VAUPjpA4QQ9ebhqahz4Vs6fKnlo8CL3p4=; b=M2Z7fOOM8XnULD51FCiiBNLLIH36XnojRLkaJjksG6PmbFiNxwI+cynxaqbY174AV3HC1w sAEHvxTm3dQpscqsYR6kUv0YMw4oqtWdt52JYMBxyRkT+SX+erHkDZI6R14ir4vgZ9EhMa sb8Tovmdjg2JQXp8Kr152RRwbptzh+w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-352-AoboXMfCPWOgP5V2PE3RfQ-1; Tue, 17 Mar 2026 10:32:53 -0400 X-MC-Unique: AoboXMfCPWOgP5V2PE3RfQ-1 X-Mimecast-MFC-AGG-ID: AoboXMfCPWOgP5V2PE3RfQ_1773757972 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43b40c22eaeso1647312f8f.2 for ; Tue, 17 Mar 2026 07:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773757972; x=1774362772; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8D9W6spqw8VAUPjpA4QQ9ebhqahz4Vs6fKnlo8CL3p4=; b=gwgGlpAO32yPu5rSk0MwfJDZA34ZshIuQOudeogeY9kXajKWXYTaII3pVYL6vZ+Kpy Hbp1dSyaQt1FcDGZ2rysEFiQlm+2SaYf860IpEMB2c3zOPAxFoWtYrah7Xy2gQiNBliQ hyqudPVnhezP8dwFy+VMoyBG4nx6o9gUq7TsCZn1YTRCvzeTWI9LZE21Y/pDyv9DGZJM 5Iv1MVxr/fShLY/+mXntBuKyFH+Ie6wFE+18ezlrfV7AOf69mRPISncC8TClHd7KAJX+ mzLtde8raT9399y+zdJBcOAwgcHphpBx+NmdMUyhdlIJ9ILCqciJY/W8YxeBHXZlT9Gr SgYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773757972; x=1774362772; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8D9W6spqw8VAUPjpA4QQ9ebhqahz4Vs6fKnlo8CL3p4=; b=olobLa3lCRtuFiGqMkGX/0bJcUh7ieW4DQRWOr0ZbfjgT+HUITV0KJIBUzfxT6UwAH IqRZntr0uJHNOmNauduotRd3b3DHKsCKxQxnN9Sx2Ebif2rfjCEXqvvpIGlYyH6FkHK1 dDAW7ROyJdt+YcL3jHT0PZGC2zR4SOGYNGdV/2KAyu4VlWZ7i0Njj1BWTClkhNVT2JpE YIa0kjPPom/JgFps7zEYjybT93STAFAGVohu+7J0n66aFHj3xfG9XzSvZlKAwTyi4/oz eyuDRK0G/jMlXS9Y1xIggtNpwDBfA4wszLGET5/wgENr/4kP1npWLTizsGl0NfmgEIIp +xqQ== X-Forwarded-Encrypted: i=1; AJvYcCXQt+Oqipr39j0q32JmczSoAQ9t4fZodflyOvZXg78cCaaUllFB0sFNVe9oX/Fzwfs8G84NiFWcvf+/jA8=@vger.kernel.org X-Gm-Message-State: AOJu0YxlAOyKPrljJxsGbkoaYNR/MkWdVdz6Lr5OVf3yCzewk5n10D4X 5w4jExzawdGxKmAtaCSFT4a+xaW9IL0qOToC3iiFY8ChncRpIuDUFzfVhGWoTP1pXQ31UD68EDI J+tOBLxe0tTQsOpbXTHFOYlMnOFT/L0gOyM46OuHc0CH/nXokkACq48tbHrvSJh8AyQ== X-Gm-Gg: ATEYQzzw3V0zeHzWK7TIhi+Gu15g/DgwwIxa0r2BVEVkHyRuVqemZeC+Yn+2fUkZCv1 AT2VePALH4d+kwg5N66asBNg6Eyg4F7og59W1XuosfMMqAZ/ZPIna6Zs5zymSLqGuT3PT67b4pz DJLCgJtkTXHu9bv/az63GNmuofh+UFYOLGHsUwFXnBmPChpZn7GvEc7WyuxBUXuoYxWYJEpCNmV DZvgv319rb+pMSh9GUuDgV2SJp/UIxdXjJ7luGHCZ66PeFI2wIaIWdbTOMXSubk83sMKLZH6Ytu dZBBpq2W1MBJWyll1mhhWPqhy3CZ0EAf5rrS0wDbySKOrU5JNxj8FdUEoqINEQXzUSOkk4Fp3vq 6FpFyX2X0kW7KvYI/JBvNmz/uKnug40/XttMLgEW2NGV6Lb1sAUb3vdo= X-Received: by 2002:a05:600c:4e08:b0:485:3eba:ab96 with SMTP id 5b1f17b1804b1-485566ca967mr277855385e9.3.1773757972501; Tue, 17 Mar 2026 07:32:52 -0700 (PDT) X-Received: by 2002:a05:600c:4e08:b0:485:3eba:ab96 with SMTP id 5b1f17b1804b1-485566ca967mr277854775e9.3.1773757971893; Tue, 17 Mar 2026 07:32:51 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4855777bd37sm191300515e9.3.2026.03.17.07.32.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 07:32:51 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 15:32:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 5/6] selftests: net: move common xdp.py functions into lib To: Mohsin Bashir , Chris J Arges , Joe Damato , Jakub Kicinski , Andy Gospodarek , Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Shuah Khan , Simon Horman , Willem de Bruijn , David Wei , Daniel Zahka , Carolina Jubran , Dimitri Daskalakis , Nimrod Oren , Gal Pressman Cc: Petr Machata , Cosmin Ratiu , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20260313223029.454755-1-carges@cloudflare.com> <20260313223029.454755-6-carges@cloudflare.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/17/26 7:48 AM, Mohsin Bashir wrote: >> +def format_hex_bytes(value): >> + """ >> + Helper function that converts an integer into a formatted hexadecimal byte string. >> + >> + Args: >> + value: An integer representing the number to be converted. >> + >> + Returns: >> + A string representing hexadecimal equivalent of value, with bytes separated by spaces. >> + """ >> + hex_str = value.to_bytes(4, byteorder='little', signed=True) >> + return ' '.join(f'{byte:02x}' for byte in hex_str) >> + >> + > > Since format_hex_bytes is not exported in __init__.py, Should it be > prefixed with _ to indicate it is private? I agree such cleanup would make sense. /{