mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	John Stultz <john.stultz@linaro.org>
Cc: Shuah Khan <shuah@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Stephen Boyd <sboyd@codeaurora.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-kselftest@vger.kernel.org,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests: timers: Fix run_destructive_tests target to handle skipped tests
Date: Tue, 22 Aug 2017 08:42:55 -0600	[thread overview]
Message-ID: <f5f52f73-08b7-e667-ba35-5e2582183fe8@osg.samsung.com> (raw)
In-Reply-To: <CA+M3ks7We9yiaawesSFcPTVVoHDSmr4HvRiJ6s9c3P6OWzwxxA@mail.gmail.com>

On 08/20/2017 07:08 AM, Benjamin Gaignard wrote:
> 2017-08-19 2:36 GMT+02:00 John Stultz <john.stultz@linaro.org>:
>> On Thu, Aug 17, 2017 at 3:48 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>> When a test exits with skip exit code of 4, "make run_destructive_tests"
>>> halts testing. Fix run_destructive_tests target to handle error exit codes.
>>>
>>> Reported-by: John Stultz <john.stultz@linaro.org>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>> ---
>>>  tools/testing/selftests/timers/Makefile | 26 +++++++++++++-------------
>>>  1 file changed, 13 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
>>> index c805ab048d26..6c1327278d5f 100644
>>> --- a/tools/testing/selftests/timers/Makefile
>>> +++ b/tools/testing/selftests/timers/Makefile
>>> @@ -13,20 +13,20 @@ TEST_GEN_PROGS_EXTENDED = alarmtimer-suspend valid-adjtimex adjtick change_skew
>>>
>>>  include ../lib.mk
>>>
>>> +define RUN_DESTRUCTIVE_TESTS
>>> +       @for TEST in $(TEST_GEN_PROGS_EXTENDED); do \
>>> +               BASENAME_TEST=`basename $$TEST`;        \
>>> +               if [ ! -x $$BASENAME_TEST ]; then       \
>>> +                       echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\
>>> +                       echo "selftests: $$BASENAME_TEST [FAIL]"; \
>>> +               else                                    \
>>> +                       cd `dirname $$TEST`; (./$$BASENAME_TEST && echo "selftests: $$BASENAME_TEST [PASS]") || echo "selftests:  $$BASENAME_TEST [FAIL]"; cd -;\
>>> +               fi;                                     \
>>> +       done;
>>> +endef
>>
>> One more on this...  you might remove rtctest_setdate from the
>> TEST_GEN_PROGS_EXTENDED list, since it too requires arguments to test,
>> and it wasn't a part of run_destructive_tests previously.
>>
>> I see Benjamin added this test not long ago, but I'm not sure exactly
>> how he expects it to be run (just manually?).
> 
> Yes run this test manually is enough
> 

Thanks I will make the change so that rtctest_setdate isn't included in the
destructive tests target and stays in the install so it gets installed on the
target test system. Will send the patch to you both.

thanks,
-- Shuah

      reply	other threads:[~2017-08-22 14:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 22:48 Shuah Khan
2017-08-18 22:13 ` John Stultz
2017-08-18 22:24   ` Shuah Khan
2017-08-18 23:23     ` [RFC][PATCH] kselftests: timers: leap-a-day: Change default arguments to help test runs John Stultz
2017-08-22 17:44       ` Shuah Khan
2017-08-22 17:41   ` [PATCH] selftests: timers: Fix run_destructive_tests target to handle skipped tests Shuah Khan
2017-08-19  0:36 ` John Stultz
2017-08-20 13:08   ` Benjamin Gaignard
2017-08-22 14:42     ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5f52f73-08b7-e667-ba35-5e2582183fe8@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®