Re: [PATCH] platform/x86: tpacpi: Mark charging LEDs as safe

["Mark Pearson" <mpearson-lenovo@squebb.ca>]

On Mon, Nov 9, 2026, at 10:02 AM, Rong Zhang wrote:
> Hi Josh,
>
> On Sat, 2026-11-07 at 13:42 -0800, Josh Triplett wrote:
>> Rong Zhang wrote:
>> > On Sat, 2026-11-07 at 12:49 -0800, Josh Triplett wrote:
>> > > If that is the primary concern, would you accept a DMI-identity-based
>> > > allowlist?
>> > 
>> > I don't think you need this if we take the module parameter approach.
>> > Usually we don't want to introduce a infinitely-growing DMI quirk table
>> > for some niche use cases.
>> 
>> The module parameter approach seems fine, as long as it doesn't taint the
>> kernel to use.
>
> I will go ahead with the taintless module parameter approach as long as
> Mark is not opposed to it.
>
Sorry for the slow reply.

I've had other users who have wanted to turn off that LED (and on a more personal note, it drives my wife nuts in a hotel room too...). So I think it's a nice to have, albeit minor, feature.

If I go and ask the FW team for their formal guidance it will be "don't do that". So module parameter works nicely here IMO. Go for it :)

Mark