From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Lee Jones" <lee@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Will McVicker" <willmcvicker@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 02/17] regulator: dt-bindings: add s2mpg10-pmic regulators
Date: Wed, 11 Jun 2025 14:53:54 +0100 [thread overview]
Message-ID: <f5fcaac5-fa8e-41da-b1d2-e84197992e3c@sirena.org.uk> (raw)
In-Reply-To: <20250611-statuesque-dolphin-of-felicity-6fbf54@kuoka>
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Wed, Jun 11, 2025 at 10:55:44AM +0200, Krzysztof Kozlowski wrote:
> On Fri, Jun 06, 2025 at 04:02:58PM GMT, André Draszik wrote:
> > + For S2MPG10 ldo20m, the following values are valid
> > + - 0 # S2MPG10_PCTRLSEL_LDO20M_ON - always on
> No, use standard regulator properties - regulator-always-on
> > + - 1 # S2MPG10_PCTRLSEL_LDO20M_EN_SFR - VLDO20M_EN & LDO20M_SFR
> > + - 2 # S2MPG10_PCTRLSEL_LDO20M_EN - VLDO20M_EN pin
> > + - 3 # S2MPG10_PCTRLSEL_LDO20M_SFR - LDO20M_SFR in LDO_CTRL1 register
> > + - 4 # S2MPG10_PCTRLSEL_LDO20M_OFF - disable
> I don't think we allowed such property in the past. I don't get what is
> here the actual signal - you described registers in multiple places, not
> signals. Few of these duplicate standard properties, so this looks like
> exact copy of downstream which was doing exactly that way and that was
> exactly never upstreamed.
It looks like we can infer the configuration needed here from the
existing properties, if a GPIO is provided then use value 2 otherwise
use value 3.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-06-11 13:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 15:02 [PATCH v2 00/17] Samsung S2MPG10 regulator and S2MPG11 PMIC drivers André Draszik
2025-06-06 15:02 ` [PATCH v2 01/17] dt-bindings: firmware: google,gs101-acpm-ipc: convert regulators to lowercase André Draszik
2025-06-11 9:04 ` Krzysztof Kozlowski
2025-06-11 9:08 ` André Draszik
2025-06-25 15:05 ` André Draszik
2025-06-25 19:03 ` Rob Herring
2025-06-25 19:04 ` Rob Herring (Arm)
2025-06-06 15:02 ` [PATCH v2 02/17] regulator: dt-bindings: add s2mpg10-pmic regulators André Draszik
2025-06-11 8:55 ` Krzysztof Kozlowski
2025-06-11 10:41 ` André Draszik
2025-06-11 13:53 ` Mark Brown [this message]
2025-06-12 10:59 ` André Draszik
2025-10-06 9:47 ` André Draszik
2025-10-10 7:38 ` Krzysztof Kozlowski
2025-06-06 15:02 ` [PATCH v2 03/17] regulator: dt-bindings: add s2mpg11-pmic regulators André Draszik
2025-06-11 8:57 ` Krzysztof Kozlowski
2025-06-11 10:24 ` André Draszik
2025-06-06 15:03 ` [PATCH v2 04/17] dt-bindings: mfd: samsung,s2mps11: add s2mpg10-pmic regulators André Draszik
2025-06-11 9:03 ` Krzysztof Kozlowski
2025-06-11 9:10 ` André Draszik
2025-06-06 15:03 ` [PATCH v2 05/17] dt-bindings: mfd: samsung,s2mps11: add s2mpg11-pmic André Draszik
2025-06-06 15:03 ` [PATCH v2 06/17] dt-bindings: firmware: google,gs101-acpm-ipc: update PMIC examples André Draszik
2025-06-10 8:39 ` André Draszik
2025-06-06 15:03 ` [PATCH v2 07/17] mfd: sec-common: Instantiate s2mpg10 bucks and ldos separately André Draszik
2025-06-06 15:03 ` [PATCH v2 08/17] mfd: sec: Add support for S2MPG11 PMIC via ACPM André Draszik
2025-06-06 15:03 ` [PATCH v2 09/17] regulator: s2mps11: drop two needless variable initialisations André Draszik
2025-06-06 15:03 ` [PATCH v2 10/17] regulator: s2mps11: use dev_err_probe() where appropriate André Draszik
2025-06-06 15:03 ` [PATCH v2 11/17] regulator: s2mps11: update node parsing (allow -supply properties) André Draszik
2025-06-06 15:03 ` [PATCH v2 12/17] regulator: s2mps11: refactor handling of external rail control André Draszik
2025-06-06 15:03 ` [PATCH v2 13/17] regulator: s2mps11: add S2MPG10 regulator André Draszik
2025-06-06 15:03 ` [PATCH v2 14/17] regulator: s2mps11: refactor S2MPG10 ::set_voltage_time() for S2MPG11 reuse André Draszik
2025-06-06 15:03 ` [PATCH v2 15/17] regulator: s2mps11: refactor S2MPG10 regulator macros " André Draszik
2025-06-06 15:03 ` [PATCH v2 16/17] regulator: s2mps11: add S2MPG11 regulator André Draszik
2025-06-06 15:03 ` [PATCH v2 17/17] regulator: s2mps11: more descriptive gpio consumer name André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5fcaac5-fa8e-41da-b1d2-e84197992e3c@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®