From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F46CCA47A for ; Fri, 17 Jun 2022 03:08:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379969AbiFQDIR (ORCPT ); Thu, 16 Jun 2022 23:08:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379936AbiFQDIP (ORCPT ); Thu, 16 Jun 2022 23:08:15 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B1A905DE4F for ; Thu, 16 Jun 2022 20:08:14 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D2A912FC; Thu, 16 Jun 2022 20:08:14 -0700 (PDT) Received: from [192.168.0.146] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B9533F73B; Thu, 16 Jun 2022 20:08:11 -0700 (PDT) Message-ID: Date: Fri, 17 Jun 2022 08:37:39 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V3 0/2] mm/mmap: Drop __SXXX/__PXXX macros from across platforms Content-Language: en-US To: Christophe Leroy , "linux-mm@kvack.org" Cc: "hch@infradead.org" , Andrew Morton , "linux-kernel@vger.kernel.org" References: <20220616040924.1022607-1-anshuman.khandual@arm.com> <1fe37a32-f11b-fbc4-7fca-46dcc89b50c4@csgroup.eu> From: Anshuman Khandual In-Reply-To: <1fe37a32-f11b-fbc4-7fca-46dcc89b50c4@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/22 10:52, Christophe Leroy wrote: > > > Le 16/06/2022 à 06:09, Anshuman Khandual a écrit : >> __SXXX/__PXXX macros is an unnecessary abstraction layer in creating the >> generic protection_map[] array which is used for vm_get_page_prot(). This >> abstraction layer can be avoided, if the platforms just define the array >> protection_map[] for all possible vm_flags access permission combinations. >> >> This series drops __SXXX/__PXXX macros from across platforms in the tree. >> First it makes protection_map[] array private (static) on platforms which >> enable ARCH_HAS_VM_GET_PAGE_PROT, later moves protection_map[] array into >> arch for all remaining platforms (!ARCH_HAS_VM_GET_PAGE_PROT), dropping >> the generic one. In the process __SXXX/__PXXX macros become redundant and >> thus get dropped off completely. I understand that the diff stat is large >> here, but please do suggest if there is a better way. This series applies >> on v5.19-rc1 and has been build tested for multiple platforms. > > Maybe this patch could be split with one patch per architecture. All you > have to do for that is to guard the generic protection_map declaration > with #ifdef __S000 , then the architectures can be migrated one by one. > >> >> The CC list for this series has been reduced to just minimum, until there >> is some initial agreement. > > Agreement with who if people don't know this series exists ? > > I think you should keep the architecture lists in copy allthough you > don't include individual maintainers/reviewers for now. Sure, will do. > >> >> - Anshuman >> >> Changes in V3: >> >> - Fix build issues on powerpc and riscv >> >> Changes in V2: > > I guess V2 was only sent to linux-mm as well ? Too bad. I was in a dilemma, whether to first arrive at something more acceptable or just engage all stake holders from the beginning. I understand your concern and hence will copy architecture mailing lists from next time onward.