From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 129D5C6FD1C for ; Sat, 25 Mar 2023 12:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231917AbjCYMMX (ORCPT ); Sat, 25 Mar 2023 08:12:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231825AbjCYMMW (ORCPT ); Sat, 25 Mar 2023 08:12:22 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF085113FA for ; Sat, 25 Mar 2023 05:12:20 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id t11so5515862lfr.1 for ; Sat, 25 Mar 2023 05:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679746339; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mx5GKFNJIsSUryNV2aWwLZ8jV1O9SFf3vbPq664rBAE=; b=XKXucM7jXM1x4OMWNfXoq1MPrMiNYQLUQvME3Ywl3Z1iOFCzZrhOvPU7S4kt3zZyWU 9ly8j2CE5F4SZ0pvkzMNh9AmSRr5ES+BlEvcehK3uW3IRmNfIn/oZ9j+4u9kfLWywKNq 0DBCB5G8x1MaKvVcVfUz4MebYt9Rq8K39AyomJjnAs72fp9sV76/CTM8aUdII4rIHEPj YSk+/QkGd8ECm8TgzvhM8Rfu3V5Q8DUuNMVJUpQXXW6CgKZDMcdb1UZZV4Xs63QGz/vV qXMwLPswRsGAE9afmRepGQPaqh7CrTSNLuMfMBQ8C5YB/6x1YINl2cWTDYQpyFLhZveX bH9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679746339; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mx5GKFNJIsSUryNV2aWwLZ8jV1O9SFf3vbPq664rBAE=; b=ksphZsvaAWzBY+4B2MBVAN6CozS3NKNd9ubtsiFeQPEHLsEgsd8viueQMfE5KYtXzT YzaiA1JuQ8Qzn0KsNjFby5puLT/93hDV42wywVD0CZLLlOLrn3BFzxVf9qPSH9FHeKcF R4iYachQmlYHwvleadbyROXkfi3wZbEFtEhS6VSasDrUlnBjK6590YmRWXVyyOUt7Dvq RVmRo2RDS63Tg3xDZ2lWo5sfnWxJ9XizS2dUegf6u3Z/i1i0zVlHARYmuzA6/FyaU+fy 3/gpHX7Nc1WGBxeCB+NJnvHfxRM9MWJifDkpF3T2utFqCKoKN/RSwb1/bRsByoNSAbxy YqKA== X-Gm-Message-State: AAQBX9dMZL3mywpPRqSHS7pWKnuu4zh0rebY/hCFYr/q79TV0VTI7Qhz vvLOKryVkZFzshoCbHy1HtE7lA== X-Google-Smtp-Source: AKy350aF/hWJDU6/B+zXSPwlitxzpBseuHLcNf7bdpQocER3sjipiZaGiW6Mg0s5VGAVbSocSqvQOA== X-Received: by 2002:ac2:5a4b:0:b0:4ea:918a:4b97 with SMTP id r11-20020ac25a4b000000b004ea918a4b97mr1925641lfn.63.1679746339021; Sat, 25 Mar 2023 05:12:19 -0700 (PDT) Received: from [192.168.1.101] (abxj225.neoplus.adsl.tpnet.pl. [83.9.3.225]) by smtp.gmail.com with ESMTPSA id q4-20020ac25284000000b004e1b880ba20sm3798241lfm.292.2023.03.25.05.12.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 05:12:18 -0700 (PDT) Message-ID: Date: Sat, 25 Mar 2023 13:12:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] ARM: dts: qcom: sdx65: add IPA information Content-Language: en-US To: Krzysztof Kozlowski , Alex Elder , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andersson@kernel.org, agross@kernel.org Cc: quic_rohiagar@quicinc.com, caleb.connolly@linaro.org, mka@chromium.org, evgreen@chromium.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230324201528.2540564-1-elder@linaro.org> <20230324201528.2540564-2-elder@linaro.org> <98fcbdd4-77b3-5b17-7102-c590f1a5a63e@kernel.org> From: Konrad Dybcio In-Reply-To: <98fcbdd4-77b3-5b17-7102-c590f1a5a63e@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.03.2023 12:14, Krzysztof Kozlowski wrote: > On 24/03/2023 21:15, Alex Elder wrote: >> Add IPA-related nodes and definitions to "sdx65.dtsi". The SMP2P >> nodes (ipa_smp2p_out and ipa_smp2p_in) are already present. >> >> Enable IPA in "sdx65-mtp.dts"; this GSI firmware is loaded by Trust >> Zone on this platform. >> >> Tested-by: Rohit Agarwal >> Signed-off-by: Alex Elder >> --- >> arch/arm/boot/dts/qcom-sdx65-mtp.dts | 5 ++++ >> arch/arm/boot/dts/qcom-sdx65.dtsi | 38 ++++++++++++++++++++++++++++ >> 2 files changed, 43 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts >> index ed98c83c141fc..72e25de0db5fc 100644 >> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts >> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts >> @@ -245,6 +245,11 @@ &blsp1_uart3 { >> status = "okay"; >> }; >> >> +&ipa { >> + qcom,gsi-loader = "skip"; >> + status = "okay"; >> +}; >> + >> &qpic_bam { >> status = "okay"; >> }; >> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi >> index 192f9f94bc8b4..360d6dc144811 100644 >> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi >> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi >> @@ -11,6 +11,7 @@ >> #include >> #include >> #include >> +#include >> >> / { >> #address-cells = <1>; >> @@ -299,6 +300,43 @@ tcsr_mutex: hwlock@1f40000 { >> #hwlock-cells = <1>; >> }; >> >> + ipa: ipa@3e04000 { >> + compatible = "qcom,sdx65-ipa"; >> + >> + iommus = <&apps_smmu 0x5e0 0x0>, >> + <&apps_smmu 0x5e2 0x0>; >> + reg = <0x3f40000 0x10000>, >> + <0x3f50000 0x5000>, >> + <0x3e04000 0xfc000>; >> + reg-names = "ipa-reg", >> + "ipa-shared", >> + "gsi"; >> + >> + interrupts-extended = <&intc GIC_SPI 241 IRQ_TYPE_EDGE_RISING>, >> + <&intc GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>, >> + <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, >> + <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "ipa", >> + "gsi", >> + "ipa-clock-query", >> + "ipa-setup-ready"; > > These look misaligned. > > With above: > > Reviewed-by: Krzysztof Kozlowski With this and moving iommus below interconnect: Reviewed-by: Konrad Dybcio Konrad > > > Best regards, > Krzysztof >