From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbcFYAfu (ORCPT ); Fri, 24 Jun 2016 20:35:50 -0400 Received: from megous.com ([83.167.254.221]:52379 "EHLO xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbcFYAft (ORCPT ); Fri, 24 Jun 2016 20:35:49 -0400 Subject: Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 To: Chen-Yu Tsai References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-4-megous@megous.com> Cc: dev , linux-arm-kernel , Zhang Rui , Eduardo Valentin , open list , "open list:THERMAL" From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= Message-ID: Date: Sat, 25 Jun 2016 02:35:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3Pg3jK0BLPjgKWrlpgJ0SdCTknL5Kp2cO" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3Pg3jK0BLPjgKWrlpgJ0SdCTknL5Kp2cO Content-Type: multipart/mixed; boundary="ORgQ4O8JilJloVgcJGoCox2bXDse8f51g" From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= To: Chen-Yu Tsai Cc: dev , linux-arm-kernel , Zhang Rui , Eduardo Valentin , open list , "open list:THERMAL" Message-ID: Subject: Re: [PATCH 03/14] thermal: Add support for sun8i THS on Allwinner H3 References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-4-megous@megous.com> In-Reply-To: --ORgQ4O8JilJloVgcJGoCox2bXDse8f51g Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 24.6.2016 05:09, Chen-Yu Tsai wrote: >> +static int sun8i_ths_h3_init(struct platform_device *pdev, >> + struct sun8i_ths_data *data) >> +{ >> + int ret; >> + size_t callen; >> + s32 *caldata; >> + >> + data->busclk =3D devm_clk_get(&pdev->dev, "ahb"); >> + if (IS_ERR(data->busclk)) { >> + ret =3D PTR_ERR(data->busclk); >> + dev_err(&pdev->dev, "failed to get ahb clk: %d\n", ret= ); >> + return ret; >> + } >> + >> + data->clk =3D devm_clk_get(&pdev->dev, "ths"); >> + if (IS_ERR(data->clk)) { >> + ret =3D PTR_ERR(data->clk); >> + dev_err(&pdev->dev, "failed to get ths clk: %d\n", ret= ); >> + return ret; >> + } >> + >> + data->reset =3D devm_reset_control_get(&pdev->dev, "ahb"); >=20 > IIRC with the new shared reset control stuff merged, you are supposed > to specify whether you want a shared or exclusive one when you ask for > it. Here devm_reset_control_get will get the exclusive reference. So this should be ok. regards, Ondrej >=20 > Regards > ChenYu >=20 >> +MODULE_LICENSE("GPL v2"); >> -- >> 2.9.0 >> --ORgQ4O8JilJloVgcJGoCox2bXDse8f51g-- --3Pg3jK0BLPjgKWrlpgJ0SdCTknL5Kp2cO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXbdHeAAoJEG5kJsZ3z+/xwwAP/jujcjRFy6xSls5iyTLtqF2R IsnQYMKv3nuSKrijkt86TO0YdqcJg8sOsViw7skCyemPkczz8neD5C/FMowTsQ5t OqaxRMmbfrXcOqt3ls4SNtInSPvUnnB9vcBWV4HhvCz2WQ9iPkpRXqWQCVIegZek jvmHMHXE9ez00ZL0Cq2jdkPB6KMYbg5k+93odHHQfFjVv23/+Tti2nqDBtWRykip lF5wt+mKRTtNddvS9HhNCmeZ8Rd29q7CdZLIus34UnqLcvvAlM5UaQfIf4CxqztZ /NaBEhnkDbfftOr86035/JeZETlUwKA4SrSAKZq8J+v2aR+/44yWKkDSaUFwSIVx Sec3hvLAX6A0GlL0cONZrJwnWQpra9ZCU48m5YzmTH8QWcYuQqR6aOj/fh6RQLBB oSD7CR8Mb+BFkktFdft48Weud0n9lcDkfQXsSSDqpHDU9QVVK2WlxzVETAvU5mh9 Ftn1o//Up/TUc8yjUw2bzB3q7TF5VPhD0qrBNs3cNKl8CqiAJYzEXJdjvujEQr3i a8NytkOt0U2DJweO4MYlztro3WDNWgZM80jQGQ2JEQl6drQxidWSc+xJUU8RxPE8 3gl3OvtyN0r6c/kXJbeRFmKODcnjn7p5wXixXMGb8fE5l9aJZZEwsPkqJ8hBcDn0 I6d3CeLTRFm0fgJc57sb =aahp -----END PGP SIGNATURE----- --3Pg3jK0BLPjgKWrlpgJ0SdCTknL5Kp2cO--