From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 171A43BF67C for ; Tue, 10 Mar 2026 13:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773148129; cv=none; b=tnYo6ObTJ+YrvWP5Wfiw7jwIWa2sPC4VuVxbcFVZpHMTnM3ZDDLwtQ4FHZwACmbV6M91OVKwL+DugAPcGFtfKvx9eaVbgc/ggGS3c/RkFFQPMKAuOiphuAGlzJ0A2eoVPWX9bxaAntlwedXlXF0P3Duulx9JuHmvMYnZS2Tcsx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773148129; c=relaxed/simple; bh=stHxacrGV9KcZ4zqvwZhJDnTd1vC4ABYqp/A+JKkwRI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dQ3rTYQna7MnZhemIZU3hoihMiLTAKK5y3rwUTWptLt20Q1idAwWdlg6W8plvf8vOvX54P/J7nz8T3nKwoIfx8CGntrK2H9RGXQa6bfzIOzi0ihwIXG99focWVGFxPSLjqmdO3pipfFgBzYkNqPMcSVnvvSfLAepmImXDcU03sU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TkRo8HVJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d/fzimb0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TkRo8HVJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d/fzimb0" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACap343417921 for ; Tue, 10 Mar 2026 13:08:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8L7QotNediNGV0w65apbqeaG9lSdLcK+7UQkqiJf0ZQ=; b=TkRo8HVJ/OdwumuV b7NJ0vZ1WRCQVVOlOk5E9TNZIsr6cMmBG0uKzqGarvC44Xb3qIULBifw6c/WuZ+W HsSjggXpd5Dwjqr/1qcgO3e9wMmWQRyBvoSqYpHgqKtNFBmxps6ZrHIZpXtIk+ZA xmCCL7aR39KxPJ+l4xHRqFJTItMuTRdiCdfbqBogBmUM6Mq2rPDUHd6CJDv07Z3Z ArD1jeAdHfS/GWyMEmO+QIqtLpHUTOshxOLUfs7sIWRL7XoErPy7+UftOu1i52hj wwN7+W2DHY4nm0zG98aIyh+luKMaCfzpkcgHEm5s/a6kEzrvTgsumUWX6pDUfnX5 Vf9rEw== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctja28c02-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 13:08:46 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5ffa8d1a111so1048273137.0 for ; Tue, 10 Mar 2026 06:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773148125; x=1773752925; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8L7QotNediNGV0w65apbqeaG9lSdLcK+7UQkqiJf0ZQ=; b=d/fzimb0aJMQBXdxafcsrZXwJsGOn00vdWpNaHZx7sg0k+5M2h36hSCbspwr0Q+PsN 2WR3lBmpEg+4Kj7PlYxhiD/azVfBY6Jfr4RIgTAi5A9ueZvecTLOQ7eeilJOk3ojoRxz SR5UBwA//LmP+2hRrZVaseRtajVu88XdVcWGVtI5SA0aYIwQDPdvpWQVZ58K3k2bp8zX UPdWHi3SSGHtjVV6wYpJYo+/2yQ3LNGkSuH7Vg0nc/yZsNQNHjy/KutW4bxtkKHJYvor dTabqnJefUN5g4PfQsOA8YMap68UohlSpNfxzN4VvtZVifeXJtDJMgO8lZY/OPzEko/x B1+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773148125; x=1773752925; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8L7QotNediNGV0w65apbqeaG9lSdLcK+7UQkqiJf0ZQ=; b=B9rqIYv3f/41qJD0qTs6pEjzOPmqyYCH/DgIZT8ZEkbXVhS5eLapeAdMs31rCLji3h Rzs5GFdYdGK4qiS675TvZ6AbzC+O2bfsYH6idnkrFq9dqeGEFzQNhM/ZcXug8Ix/m8p0 t4Vo2MJbosjQ85E67M8f6+gKVLqh151kjGAkoJnlZcD7cIjA0Wp1G8E4Dx5pr45FOJ5a Y9FXggt3A5OP6j0vFOXz1bGnSTo6KXNaYZBCTyJFspQWrx/5qXZPaT806Ps+xAeW/jSn 76ZkVlNOQXo+dgMunE6sW3EwK6Q3OJWjeYvUKlV0FdZEGcCoHXzCN2StrXc403mJB8F7 DYvA== X-Forwarded-Encrypted: i=1; AJvYcCUyDpfNqQHki7umj/AQxxYX2rYFdoTQj5LueYzqbqI84XkUEtYOtIbnNqB5qBXw3RUhuHuoePz7+hwBzW8=@vger.kernel.org X-Gm-Message-State: AOJu0YxNJbYyO5QPIg83jGRwMSrCBhPSeTSa4b8aeAFIiecXp2yCp5eH 2oNpw4FeanlnAsbmAlCHW5L7K9Z+39bXxgnsM8gUiX2ooHkZBTxoVgOJHjXGYJACVe6cO3nxg+/ kOiPqLcI4vpOL2hzo8eZ0SP2Ru9dILgRgZjk+CsFhHDVAimdrZTGoCb9gc6/7Fw2/aX0= X-Gm-Gg: ATEYQzwac/PTheK+SyMRmwWr2nuCFBmDIUyXEdvVF+8yu7vnhdtLJGccQ12o3XHYPnb 18u19KUgRPG5KtKBUv9mY2B2Z9b/4pkiJ5S18Hnrf1M9jLepV5y5hib5vWw6mV/QBhA6RT52u1A tyI3n23caUQwPxuf/vPU+gBXuouRkoe+1r7cQdnXKzXlT5+r/PUkgpUm8/w1qrUDQfXYnmTJ2Ar 0zYsj4/Efy6aZPmcaVbkGnxPDnHGEDgzG4PadRdVpth5CIPCC4svAT/ikB9O15el6y4xuLy+VTK I12T/PIQzQdxcHSiyUgbZ12/OSMXZFwCXkEIXmSm2b7zv23DqoMf6Fe9c5HVamHd9zvIvklMUl6 tKmDkJu85an025EQRyp5oNyf4nqdqtbBeYuKojIECiZD/Tmdg78LM6NfzDieOYLQ3yemY623u2O H2Db4= X-Received: by 2002:a05:6102:50a6:b0:5ff:d7be:fdeb with SMTP id ada2fe7eead31-5ffe6391715mr2638061137.7.1773148125413; Tue, 10 Mar 2026 06:08:45 -0700 (PDT) X-Received: by 2002:a05:6102:50a6:b0:5ff:d7be:fdeb with SMTP id ada2fe7eead31-5ffe6391715mr2638044137.7.1773148124886; Tue, 10 Mar 2026 06:08:44 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942f139e24sm488542566b.38.2026.03.10.06.08.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 06:08:43 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 14:08:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen To: cristian_ci@protonmail.com, Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260308-rimob-new-features-v1-0-aa2c330572c0@protonmail.com> <20260308-rimob-new-features-v1-5-aa2c330572c0@protonmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260308-rimob-new-features-v1-5-aa2c330572c0@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=c9WmgB9l c=1 sm=1 tr=0 ts=69b017de cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=sfOm8-O8AAAA:8 a=SwJZ1EMs1T1tlsjO-F8A:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 a=TvTJqdcANYtsRzA46cdi:22 X-Proofpoint-ORIG-GUID: cCDJmcFOt2G1964YxCt27IgcpVzx2oOi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDExNCBTYWx0ZWRfX8fjOUT2bgbVt id76idrp9pI6WK4sgHLOohKqGxWFe8YXU6bylzJQQqXagGYX6QtR5mbyeHfISjfKRXYSSSlamDQ MlJKlhepLzURTTD9YD9Yj4z0/mXm5yiBTEEL8ykoCFE7T1g2O4BjFaTeYua+2O9jYgF2yJTx0Km Xf4bsoMR1JeMl7YCCPVwneJqryOo3Povdo9/US/WjRE82P5szExNvq8kN7rBM5sNyeytEOu5Pnl jAex3QKPHpwsejBWsVwSuZ3+NcrLR7dhzgbdlOl5jvoUVo3+nSeJczZYLj6ZAH3sWw1Tlp9gIyo KgNRVCsvsUW9J4ALvga+7Gum6QNKWaMn6/agSJI2WJkUmSzhBSwzojheDn4pyXbH9MNCrNCzKvh vdUye2wL1oIGKFgb/sdEU28xwkP99gBk9A5fU466zS1OoaRTw4ISoCyAnMjPtwmfGEbugM5+gjq cGoxI2jFgi//FhpmwJg== X-Proofpoint-GUID: cCDJmcFOt2G1964YxCt27IgcpVzx2oOi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 clxscore=1015 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100114 On 3/8/26 4:52 PM, Cristian Cozzolino via B4 Relay wrote: > From: Cristian Cozzolino > > This device uses a Goodix GT5688 touch controller, connected to i2c_3. > Add it to the device tree. > > Signed-off-by: Cristian Cozzolino > --- > .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > index 7b2849405462..709ea6fc9fbb 100644 > --- a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > +++ b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > @@ -94,6 +94,31 @@ &hsusb_phy { > status = "okay"; > }; > > +&i2c_3 { > + status = "okay"; > + > + touchscreen@5d { > + compatible = "goodix,gt5688"; > + reg = <0x5d>; > + > + interrupts-extended = <&tlmm 65 IRQ_TYPE_LEVEL_LOW>; interrupts *and* irq-gpios sounds wrong.. and I think the driver doesn't even consume the former. Trying to read through some of that, I think it's on purpose since the IRQ GPIO is repurposed for setting the I2C addr (which nota bene doesn't match between the comment in that driver and this submission - perhaps that's just a SKU difference) during the reset sequence i.e., does the touch work any different if you drop the above? does /proc/interrupts differ? Konrad