From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: phy_led_triggers: Fix a possible null-pointer dereference in phy_led_trigger_change_speed()
Date: Tue, 30 Jul 2019 10:25:36 +0800 [thread overview]
Message-ID: <f603f3c3-f7c9-8dff-5f30-74174282819c@gmail.com> (raw)
In-Reply-To: <20190729134553.GC4110@lunn.ch>
On 2019/7/29 21:45, Andrew Lunn wrote:
> On Mon, Jul 29, 2019 at 05:24:24PM +0800, Jia-Ju Bai wrote:
>> In phy_led_trigger_change_speed(), there is an if statement on line 48
>> to check whether phy->last_triggered is NULL:
>> if (!phy->last_triggered)
>>
>> When phy->last_triggered is NULL, it is used on line 52:
>> led_trigger_event(&phy->last_triggered->trigger, LED_OFF);
>>
>> Thus, a possible null-pointer dereference may occur.
>>
>> To fix this bug, led_trigger_event(&phy->last_triggered->trigger,
>> LED_OFF) is called when phy->last_triggered is not NULL.
>>
>> This bug is found by a static analysis tool STCheck written by us.
> Who is 'us'?
Me and my colleague...
Best wishes,
Jia-Ju Bai
next prev parent reply other threads:[~2019-07-30 2:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 9:24 Jia-Ju Bai
2019-07-29 13:45 ` Andrew Lunn
2019-07-30 2:25 ` Jia-Ju Bai [this message]
2019-07-30 3:32 ` Andrew Lunn
2019-07-30 3:41 ` David Miller
2019-07-30 8:03 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f603f3c3-f7c9-8dff-5f30-74174282819c@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®