From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754197AbdK1Tlw (ORCPT ); Tue, 28 Nov 2017 14:41:52 -0500 Received: from mail.netline.ch ([148.251.143.178]:44210 "EHLO netline-mail3.netline.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbdK1Tlu (ORCPT ); Tue, 28 Nov 2017 14:41:50 -0500 Subject: Re: [PATCH] platform/x86: hp-wmi: Actually use mask parameter in hp_wmi_hw_state To: Andy Shevchenko Cc: Darren Hart , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" References: <20171128151758.9234-1-michel@daenzer.net> <20171128165724.GA16349@fury> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Message-ID: Date: Tue, 28 Nov 2017 20:41:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-11-28 08:30 PM, Andy Shevchenko wrote: > On Tue, Nov 28, 2017 at 8:06 PM, Michel Dänzer wrote: >> On 2017-11-28 05:57 PM, Darren Hart wrote: >>> On Tue, Nov 28, 2017 at 04:17:58PM +0100, Michel Dänzer wrote: >>>> We were always checking bit 0 (which represents the docked state) >>>> regardless of the mask. >>>> >>>> Fixes the "tablet mode" state always being reported the same as the >>>> docked state, which with current libinput can cause the built-in input >>>> devices of laptops to be incorrectly disabled while docked. > >>> Merged in 4.15-rc1 >> >> AFAIK commits without >> >> Cc: stable@vger.kernel.org >> >> don't get automatically picked up for stable branches. Can you manually >> nominate 9968e12 for stable? > > AFAIK Greg picks up patches based on Fixes tag as well. > Feel free to ping us or just forward that one yourself if Greg will > not pick up in reasonable (month?) time. Both 4.14.1 and 4.14.2 were released after Linus merged the fix, but neither has it. Given that, and that a fair number of people seem to be running into this, seems like a good idea to do it ASAP. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer