From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8374F4C6535; Tue, 29 Sep 2026 08:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790671751; cv=none; b=DoJpBJ/C03UdFRGkAqqaPcxBMTvOhfH0tQbw12jEPGM+S5pXisfrAIDEmJYLTcG78KC0i/3N3sNgCI9Sx0e1Ea7jXKuzZLRAQY1+J4RAvqBFLxJ3XsXdZjeB4ciK/5YIhlDLJ4sap0vGyXwvW+oMtQUcn+nfeCoSXLrKP0XDtTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790671751; c=relaxed/simple; bh=GeRbolGkRr40FWu3ik7N3Vv2bkK9bU16sOeBMCfR+RM=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=V7pnQMFI3ymHK36fxqmU+2MJwXzROanreQJKWY9jJtHqRvT0B1TB04srW2+NCHWijXIGX2EmxKC0AGFnTyPZcAEoYU+XBk8f5LlWrQDfLEm42MEfK8qnPk292BI+Kc3gsWpN810zac7TOKIAy/idKRys8QYWXzuFnFD4bZsqBJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Z+Ry2pZw; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Z+Ry2pZw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790671743; x=1822207743; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=GeRbolGkRr40FWu3ik7N3Vv2bkK9bU16sOeBMCfR+RM=; b=Z+Ry2pZw9pFLeLoGgq2pq5rMMLDoFylAl3tOjTW+xL/FxI0rj6a5ta4P qtVZ8S1K0AbWn2Glfy+NUK2zvIz/o6j0+upbhDb4fuWSjGSM4L5gr6ykE 1L3YsyfxnjkSja2BhP5rbZBitwp5bmCoXoKzGQEo0CRtTiKrJd142Ee/8 eXvA094lLyfq/7TBxVcBIsqYZ52Tt+pe6oVGrq6siC/5VfG+4aod1hvxC hzu5SZ90hXPLpi3IliXIM4hMU8XRBxgbH/pF+oyHhc3TaUrW89DpLG8PX nfZ6JDK4c2XSkmVuOvITgoAkYjLco8TehVJJJdOV8c30AV3l4rtqHONh9 Q==; X-CSE-ConnectionGUID: d7vHLkIXSieppGaAn5oCQQ== X-CSE-MsgGUID: iFQg3YNvQkCPqIgz33rJAg== X-IronPort-AV: E=McAfee;i="6800,10657,11919"; a="90336359" X-IronPort-AV: E=Sophos;i="6.27,130,1787036400"; d="scan'208";a="90336359" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2026 01:48:57 -0700 X-CSE-ConnectionGUID: M3HkRzwlQBiXSlERqb3VYw== X-CSE-MsgGUID: 2+7AT7l0RYmTcnFCTcWMCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,130,1787036400"; d="scan'208";a="274415256" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.234]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2026 01:48:53 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Tue, 29 Sep 2026 11:48:49 +0300 (EEST) To: Mingyou Chen cc: W_Armin@gmx.de, foxido@foxido.dev, Hans de Goede , LKML , nika@nikableh.moe, platform-driver-x86@vger.kernel.org, vlku.milos.fun@gmail.com, i@rsplwe.com, wolf109909@outlook.com, rahulbheda131313@gmail.com Subject: Re: [PATCH v5 4/6] platform/x86: redmi-wmi: Drop redmi-wmi driver In-Reply-To: <20260816100813.300450-5-qby140326@gmail.com> Message-ID: References: <20260816100813.300450-1-qby140326@gmail.com> <20260816100813.300450-5-qby140326@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sun, 16 Aug 2026, Mingyou Chen wrote: > The redmi-wmi driver is no longer needed because its functionality > has been superseded by the new generic bitland platform driver. > All supported Redmi laptop models are now handled properly via the > updated WMI interfaces in bitland-mifs-wmi. > > Remove the obsolete code, Kconfig entries, and Makefile references > to clean up the platform directory. > > Signed-off-by: Mingyou Chen Hi, What are your plans with this series? This patch no longer applies cleanly as there were redmi-wmi side changes which I think this series does not not properly cover. -- i. > --- > MAINTAINERS | 6 -- > drivers/platform/x86/Kconfig | 12 --- > drivers/platform/x86/Makefile | 1 - > drivers/platform/x86/redmi-wmi.c | 154 ------------------------------- > 4 files changed, 173 deletions(-) > delete mode 100644 drivers/platform/x86/redmi-wmi.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index af86b1df1a94..b92bc4816fa6 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -22768,12 +22768,6 @@ S: Maintained > T: git https://github.com/pkshih/rtw.git > F: drivers/net/wireless/realtek/rtw89/ > > -REDMIBOOK WMI DRIVERS > -M: Gladyshev Ilya > -L: platform-driver-x86@vger.kernel.org > -S: Maintained > -F: drivers/platform/x86/redmi-wmi.c > - > BITLAND LAPTOP DRIVER > M: Mingyou Chen > M: Gladyshev Ilya > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index b54b5212b204..036fc76f62df 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -90,18 +90,6 @@ config XIAOMI_WMI > To compile this driver as a module, choose M here: the module will > be called xiaomi-wmi. > > -config REDMI_WMI > - tristate "Redmibook WMI key driver" > - depends on ACPI_WMI > - depends on INPUT > - select INPUT_SPARSEKMAP > - help > - Say Y here if you want support for WMI-based hotkey events on > - Xiaomi Redmibook devices. > - > - To compile this driver as a module, choose M here: the module will > - be called redmi-wmi. > - > config GIGABYTE_WMI > tristate "Gigabyte WMI temperature driver" > depends on ACPI_WMI > diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile > index 872ac3842391..0da4876f766e 100644 > --- a/drivers/platform/x86/Makefile > +++ b/drivers/platform/x86/Makefile > @@ -12,7 +12,6 @@ obj-$(CONFIG_HUAWEI_WMI) += huawei-wmi.o > obj-$(CONFIG_MXM_WMI) += mxm-wmi.o > obj-$(CONFIG_NVIDIA_WMI_EC_BACKLIGHT) += nvidia-wmi-ec-backlight.o > obj-$(CONFIG_XIAOMI_WMI) += xiaomi-wmi.o > -obj-$(CONFIG_REDMI_WMI) += redmi-wmi.o > obj-$(CONFIG_GIGABYTE_WMI) += gigabyte-wmi.o > obj-$(CONFIG_BITLAND_MIFS_WMI) += bitland-mifs-wmi.o > > diff --git a/drivers/platform/x86/redmi-wmi.c b/drivers/platform/x86/redmi-wmi.c > deleted file mode 100644 > index 58898630eda6..000000000000 > --- a/drivers/platform/x86/redmi-wmi.c > +++ /dev/null > @@ -1,154 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0 > -/* WMI driver for Xiaomi Redmibooks */ > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > -#include > - > -#define WMI_REDMIBOOK_KEYBOARD_EVENT_GUID "46C93E13-EE9B-4262-8488-563BCA757FEF" > - > -#define AI_KEY_VALUE_MASK BIT(8) > - > -static const struct key_entry redmi_wmi_keymap[] = { > - {KE_KEY, 0x00000201, {KEY_SELECTIVE_SCREENSHOT}}, > - {KE_KEY, 0x00000301, {KEY_ALL_APPLICATIONS}}, > - {KE_KEY, 0x00001b01, {KEY_CONFIG}}, > - {KE_KEY, 0x00011b01, {KEY_CONFIG}}, > - {KE_KEY, 0x00010101, {KEY_SWITCHVIDEOMODE}}, > - {KE_KEY, 0x00001a01, {KEY_REFRESH_RATE_TOGGLE}}, > - > - /* AI button has code for each position */ > - {KE_KEY, 0x00011801, {KEY_ASSISTANT}}, > - {KE_KEY, 0x00011901, {KEY_ASSISTANT}}, > - > - /* Keyboard backlight */ > - {KE_IGNORE, 0x00000501, {}}, > - {KE_IGNORE, 0x00800501, {}}, > - {KE_IGNORE, 0x00050501, {}}, > - {KE_IGNORE, 0x000a0501, {}}, > - > - /* Xiaomi G Command Center */ > - {KE_KEY, 0x00010a01, {KEY_VENDOR}}, > - > - /* OEM preset power mode */ > - {KE_IGNORE, 0x00011601, {}}, > - {KE_IGNORE, 0x00021601, {}}, > - {KE_IGNORE, 0x00031601, {}}, > - {KE_IGNORE, 0x00041601, {}}, > - > - /* Fn Lock state */ > - {KE_IGNORE, 0x00000701, {}}, > - {KE_IGNORE, 0x00010701, {}}, > - > - /* Fn+`/1/2/3/4 */ > - {KE_KEY, 0x00011101, {KEY_F13}}, > - {KE_KEY, 0x00011201, {KEY_F14}}, > - {KE_KEY, 0x00011301, {KEY_F15}}, > - {KE_KEY, 0x00011401, {KEY_F16}}, > - {KE_KEY, 0x00011501, {KEY_F17}}, > - > - {KE_END} > -}; > - > -struct redmi_wmi { > - struct input_dev *input_dev; > - /* Protects the key event sequence */ > - struct mutex key_lock; > -}; > - > -static int redmi_wmi_probe(struct wmi_device *wdev, const void *context) > -{ > - struct redmi_wmi *data; > - int err; > - > - /* Init dev */ > - data = devm_kzalloc(&wdev->dev, sizeof(*data), GFP_KERNEL); > - if (!data) > - return -ENOMEM; > - > - dev_set_drvdata(&wdev->dev, data); > - > - err = devm_mutex_init(&wdev->dev, &data->key_lock); > - if (err) > - return err; > - > - data->input_dev = devm_input_allocate_device(&wdev->dev); > - if (!data->input_dev) > - return -ENOMEM; > - > - data->input_dev->name = "Redmibook WMI keys"; > - data->input_dev->phys = "wmi/input0"; > - > - err = sparse_keymap_setup(data->input_dev, redmi_wmi_keymap, NULL); > - if (err) > - return err; > - > - return input_register_device(data->input_dev); > -} > - > -static void redmi_wmi_notify(struct wmi_device *wdev, union acpi_object *obj) > -{ > - struct key_entry *entry; > - struct redmi_wmi *data = dev_get_drvdata(&wdev->dev); > - bool autorelease = true; > - u32 payload; > - int value = 1; > - > - if (obj->type != ACPI_TYPE_BUFFER) { > - dev_err(&wdev->dev, "Bad response type %u\n", obj->type); > - return; > - } > - > - if (obj->buffer.length < 32) { > - dev_err(&wdev->dev, "Invalid buffer length %u\n", obj->buffer.length); > - return; > - } > - > - payload = get_unaligned_le32(obj->buffer.pointer); > - entry = sparse_keymap_entry_from_scancode(data->input_dev, payload); > - > - if (!entry) { > - dev_dbg(&wdev->dev, "Unknown WMI event with payload %u", payload); > - return; > - } > - > - /* AI key quirk */ > - if (entry->keycode == KEY_ASSISTANT) { > - value = !(payload & AI_KEY_VALUE_MASK); > - autorelease = false; > - } > - > - guard(mutex)(&data->key_lock); > - sparse_keymap_report_entry(data->input_dev, entry, value, autorelease); > -} > - > -static const struct wmi_device_id redmi_wmi_id_table[] = { > - { WMI_REDMIBOOK_KEYBOARD_EVENT_GUID, NULL }, > - { } > -}; > - > -static struct wmi_driver redmi_wmi_driver = { > - .driver = { > - .name = "redmi-wmi", > - .probe_type = PROBE_PREFER_ASYNCHRONOUS, > - }, > - .id_table = redmi_wmi_id_table, > - .min_event_size = 32, > - .probe = redmi_wmi_probe, > - .notify = redmi_wmi_notify, > - .no_singleton = true, > -}; > -module_wmi_driver(redmi_wmi_driver); > - > -MODULE_DEVICE_TABLE(wmi, redmi_wmi_id_table); > -MODULE_AUTHOR("Gladyshev Ilya "); > -MODULE_DESCRIPTION("Redmibook WMI driver"); > -MODULE_LICENSE("GPL"); > -- i.