Re: [PATCH 1/5] dt-bindings: arm: qcom: Document Microsoft Surface Laptop 8th Edition

[Sibi Sankar <sibi.sankar@oss.qualcomm.com>]

On 15/10/2026 19:02, Konrad Dybcio wrote:
> On 10/15/26 2:47 PM, Gopikrishna Garmidi wrote:
>> Hi Konrad,
>>
>> On 10/13/2026 2:09 PM, Konrad Dybcio wrote:
>>> On 10/7/26 9:11 AM, Gopikrishna Garmidi wrote:
>>>>
>>>>
>>>> On 10/6/2026 3:20 PM, Gopikrishna Garmidi wrote:
>>>>> Document the Mahua-based Microsoft Surface Laptop 13.8" 8th Edition.
>>>>>
>>>>> Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
>>>>> ---
> 
> [...]
> 
> 
>> Thanks for checking. The only matches I see are in the MPTF thermal
>> package, which ships"883ROT13Inch.bin" and "883ROT15Inch.bin". Nothing
>> else mentions ROT.
>>
>> I also checked all the ACPI tables but didn't find a codename there.
>> The tables are here:
>>
>>    https://github.com/aarch64-laptops/build/pull/176
>>
>> Following the Lenovo gen8 naming, would something like
>> "microsoft,surface-laptop-gen8-13p8in"
>> (mahua-microsoft-surface-laptop-gen8-13p8in.dts) work? I'm open to
>> whatever you and Krzysztof prefer.
> 
> FWIW the "gen" naming comes directly from Lenovo's product name,
> i.e. if you go on lenovo.com it says "ThinkPad T14s Gen 7".

Official Documentation say "Surface Laptop, 13.8 inch (8th Edition)"

We have to create a dedicated board file for the fifteen inch variant
since it is expected to have a sd-card port and another one for 13inch
specifically to enable ufs. All of them will have only lcd panels. So
how about if we go with the following?

microsoft,surface-laptop-8-lcd13
microsoft,surface-laptop-8-lcd13p8
microsoft,surface-laptop-8-lcd15

With this is mind it might make sense to create a common
file mahua-microsoft-surface-laptop-8.dtsi that all these
boards can import from as well.

-Sibi
> 
> Konrad