mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	ChiYuan Huang <cy_huang@richtek.com>, <linux-usb@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Bear Wang <bear.wang@mediatek.com>,
	Pablo Sun <pablo.sun@mediatek.com>,
	Macpaul Lin <macpaul@gmail.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Chris-qj chen <chris-qj.chen@mediatek.com>
Subject: Re: [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property
Date: Wed, 16 Oct 2024 12:17:28 +0800	[thread overview]
Message-ID: <f624ea86-1754-c365-ab22-a2890960b94c@mediatek.com> (raw)
In-Reply-To: <20241015222046.GA2164669-robh@kernel.org>



On 10/16/24 06:20, Rob Herring wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On Wed, Oct 16, 2024 at 01:21:00AM +0800, Macpaul Lin wrote:
>> Add optional 'mediatek,usb3-drd' property to MediaTek MTU3 DT Schema.
>> This flag specify whether it is a USB3 Dual-role device hardware.
>> 
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>>  Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> index d4e187c78a0b..1e70af0dac82 100644
>> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> @@ -155,6 +155,12 @@ properties:
>>        property is used. See graph.txt
>>      $ref: /schemas/graph.yaml#/properties/port
>>  
>> +  mediatek,usb3-drd:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description:
>> +      Specify whether it is a USB3 Dual-role device hardware.
>> +    type: boolean
>> +
> 
> Don't the standard properties such as usb-role-switch or dr_mode work
> for you?

I've found there are some hardware capability registers could be read
when probing the device. I'll try if the platform I'm using could access
these capability registers.
This patch can be discard. If the hardware really need specify the 
capability in dts and there is no capability registers, I'll resend
this patch that time.

>>    enable-manual-drd:
>>      $ref: /schemas/types.yaml#/definitions/flag
>>      description:
>> -- 
>> 2.45.2
>> 
> 

Thanks!
Macpaul Lin

  reply	other threads:[~2024-10-16  4:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 17:21 Macpaul Lin
2024-10-15 22:20 ` Rob Herring
2024-10-16  4:17   ` Macpaul Lin [this message]
2024-10-16 10:52   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f624ea86-1754-c365-ab22-a2890960b94c@mediatek.com \
    --to=macpaul.lin@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bear.wang@mediatek.com \
    --cc=chris-qj.chen@mediatek.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=macpaul@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=pablo.sun@mediatek.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®