From: Stefan Agner <stefan@agner.ch>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: jslaby@suse.cz, jingchang.lu@freescale.com, shawn.guo@linaro.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] serial: fsl_lpuart: fix various DMA related issues
Date: Fri, 12 Dec 2014 17:19:02 +0100 [thread overview]
Message-ID: <f6255321feb06d32f257b7b41d5d58a3@agner.ch> (raw)
In-Reply-To: <20141212143244.GA2219@kroah.com>
On 2014-12-12 15:32, Greg KH wrote:
> On Fri, Dec 12, 2014 at 02:44:06PM +0100, Stefan Agner wrote:
>> Any thoughts on this patchset? Would have hopped that it makes it into
>> 3.19 as those are mostly fixes.
>
> "mostly"?
>
Well, all of them fix a bug, but PATCH 2/4 does this by also moving DMA
allocation to probe. I would really have to split up that patch and make
two incremental steps (split-up of RX/TX DMA allocation to make each
single action revert-able and move to probe). But this would lead to
more changed lines in total. The patchset as is already somewhat tested
since we use it in our 3.18 BSP, whereas a new set would not be tested.
One could also argument, it only affects fsl_lpuart (UART in rather not
very widespread SoC's Freescale Vybrid and LS1021a).
> I'll get to these after 3.19-rc1 is out, but it really looks like these
> will be for 3.20-rc1, unless you break them up into "bugfix only" type
> patches.
PATCH 1/4 fixes a bug which happens on a normal console rather often on
my setup. So if you decide that patchset is for 3.20-rc1, that one would
be nice to have in 3.19 as well...
--
Stefan
next prev parent reply other threads:[~2014-12-12 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 0:23 Stefan Agner
2014-11-28 0:23 ` [PATCH 1/4] serial: fsl_lpuart: delete timer on shutdown Stefan Agner
2014-11-28 0:23 ` [PATCH 2/4] serial: fsl_lpuart: move DMA channel request to probe Stefan Agner
2014-11-28 0:23 ` [PATCH 3/4] serial: fsl_lpuart: avoid new transfer while DMA is running Stefan Agner
2014-11-28 0:23 ` [PATCH 4/4] serial: fsl_lpuart: update RX timer on successful DMA transfer Stefan Agner
2014-12-12 13:44 ` [PATCH 0/4] serial: fsl_lpuart: fix various DMA related issues Stefan Agner
2014-12-12 14:32 ` Greg KH
2014-12-12 16:19 ` Stefan Agner [this message]
2015-01-09 22:14 ` Greg KH
2015-01-09 22:19 ` Stefan Agner
2015-01-09 22:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6255321feb06d32f257b7b41d5d58a3@agner.ch \
--to=stefan@agner.ch \
--cc=gregkh@linuxfoundation.org \
--cc=jingchang.lu@freescale.com \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®