From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D5F22701C4 for ; Sun, 21 Jun 2026 13:28:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782048540; cv=none; b=GIRFgTu3RLUmCtTlTgKVD/NUcOTLsopHax6dDtfXS0A2F89VlzAF88ambA/XMZNul3c8HoqJEtdhrMmF0EVJpPdYZII/G/vOdthTkqcfzlnxKDHyBvOXaAx7my9bjcBpGZxt3owm6SO0JeCuQbmS6HDrgSBc8jC2uRvHKgPrnfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782048540; c=relaxed/simple; bh=/1gwxImvfbX+kqBJ2oxN0RD9tJRZuIRghmQumNZUES0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=FRzGSxsSe/fJLeki50CL5oAhph3Bjo3gC7rMmh1BckN42RVPgejvOlUnoXsotU0sQaBPusvqR4f+Kdzb2Apd1kUWJnzHyt8wSxGxp8MA0/WXOzyMOoeu+vEQucQa4eIwwgHV4XRaIQoy03grYDHIROmao4ZnA2doz8Fyfl+Em+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bEAi7yhu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H01v9mvs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bEAi7yhu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H01v9mvs" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65L9uVjM1807700 for ; Sun, 21 Jun 2026 13:28:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WXxgbr+zoksqo3z7jo/Wh9E0btSV/B3EVlHkOx3aGMk=; b=bEAi7yhuLxyWRDfy fmlQRK+XtqEnkLrvKOjKqZsXMKj8f2IAU2o39gzHYPYeZsamlJQ5P2Mc9i1NM/2R K8KErIqV6Viy/XBwKtQtDUn1zDUcaAPEl8oZrOKIN76RsiiPlUSlk07eI0yOHn3U uiN0d54oezdqaAIahSdRypFh++kmOCIziTxycF6asy4RDLsmYEymGd0vZlZ1seDm A5mLHt9m9wdFm7bi7uPItUdd0DBUuuhOIU2/fjeMVsflELBfHjlVyJ755NPDdBao 1Evn30WjdtTY6z3fMcjEWP/s7fXv8ekMNy4Rl2lYxnU/TkUdJTDJZhhYQ1BcMc2y 12YyYw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ewk8830nx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 21 Jun 2026 13:28:58 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2bf1dece2ecso37805095ad.1 for ; Sun, 21 Jun 2026 06:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782048537; x=1782653337; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=WXxgbr+zoksqo3z7jo/Wh9E0btSV/B3EVlHkOx3aGMk=; b=H01v9mvsUfKcuZwkuOzftANW0Kdg9QFCX5uMgLwpj1q7drfjOCduY0hDftx746j5qV /YrHAMq5uAy3R38katQS2fuu5Iy8gUHkbdaEYXXNe+YIst9FNSWzURzxVJDrrw/zlyRI izckcrGPDDNr9P2hWZRx8l79aYLPO4PSb4qEACn/6ypKwOBrBbQx67GRj+4+n6g6nytx bJD0iSYpqT1DfMleL76oGO81Z3HuCPTdaL6Q6g4ch8az/CNQdHE7bVljn+4RrikGtnk8 Fi20DmBXvSJXUf/EJxFFrO9jZqTz19gv+W+Djrrp4DQqLOFiwn5uIjBgSypn9vvNtABB jaJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782048537; x=1782653337; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WXxgbr+zoksqo3z7jo/Wh9E0btSV/B3EVlHkOx3aGMk=; b=CNpskyDz4eA4JoX5kV4xsgSDSWdwUjItzo+mVj/cEHX05m3ZlFRonvXgNTUqhB9Lj0 TCyKcTVGSjsl2K5NOd5hqHFTVFJG8KR1pd++Vp6d1U+fhrgZH0KVcuITozLEr2sijsEe Pjnb0Wn9PqmNxiMPvXE27wkPGTcQcfBFo85UtSGPjKgoZeufdPRlu9/qSU1i0oZJDzTn +AC8sCpS5TxQVzmW79LdFNLbwJU7Z9aqCsnotZvfUdQ/xsr9J+2qHFVgI4oms884UQny UiGc0tLSuV4x1KAT2j8GxaoxkTuFJ40yOiGLzZJOqv8wwtmpyvfERHkNvOiOD5Ht3e0M O9Wg== X-Forwarded-Encrypted: i=1; AHgh+Rq2Q41gLSycN9rO4lzFfj7QtmgDDBxkFBinXgfRAG0kIZlTPNCXGqWH9RR96nT0gHd2EpU5kgszK9shKhc=@vger.kernel.org X-Gm-Message-State: AOJu0YzNhVEm/LTtlbi06rgMoNPf9RhDBfbjFLWiqXAnjjjp4igsXLhN tme3JEFBV7rJ8HeQlQw3DlQUDO3wRfPe8RFCHIw1aaqFAKly/cjhTbOWlWqb2YG401I3Vg5z29d sRDR/tThiPQERzkDVGZuiuLOQyWH03L0PRZbXtlAZbgoDB0OgR3rRjbpRkKraRRORkUY= X-Gm-Gg: AfdE7cnQx2PePTTyngwVzIvMKXfkPODF3q+OTvo4NnGI/DIB0MTWyHugKKG74s7/MB3 qQCrc8pSpFG45V2JlnJPCLrsz1Mq8qga3yI6uFlfvPZgPPZGITs0MvX6FNzYWRXelV7Y/tsTCOI Fkp8LKsRxpiTVYy9Fj4kxfUkhKUg3cqoggpcKKvePjZ/eEK2a4XUlUfSBDqmeBbubk2XK5A3AGX gY03odr1UNtYfKL+Xa9MrhLoSrcAzH5uFyEDEbmNxvIU/qKdESYgaBhlYJIwLUiqtYd3+kjWK+Q NlxTIIl1F/n3bHBaTKoELiq9cNgiDzm32UhW4A78ZFy9EJnAJIIk+RJh0Mj5kLsjnKdpCt4Ntht mdgXyV180iUERpfL+yEU+//pVpQDqZVAFdAuzOcwS X-Received: by 2002:a17:903:94d:b0:2c0:aef8:23eb with SMTP id d9443c01a7336-2c719001a1amr130799795ad.25.1782048537214; Sun, 21 Jun 2026 06:28:57 -0700 (PDT) X-Received: by 2002:a17:903:94d:b0:2c0:aef8:23eb with SMTP id d9443c01a7336-2c719001a1amr130799415ad.25.1782048536750; Sun, 21 Jun 2026 06:28:56 -0700 (PDT) Received: from [192.168.29.32] ([49.43.225.115]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7439f8524sm52980105ad.47.2026.06.21.06.28.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jun 2026 06:28:56 -0700 (PDT) Message-ID: Date: Sun, 21 Jun 2026 18:58:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Imran Shaik Subject: Re: [PATCH v4 01/13] clk: qcom: gcc-qcm2290: Keep the critical clocks always-on from probe To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Loic Poulain , Brian Masney , Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260604-shikra-dispcc-gpucc-v4-0-8204f1029311@oss.qualcomm.com> <20260604-shikra-dispcc-gpucc-v4-1-8204f1029311@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIxMDEzNyBTYWx0ZWRfX13f7jND+7x77 IP0XxX2TrHcfRDsqGMzcSKarWaHyikN+e5F2qWFD5NnZzmbAT0EH4g2CV10fWjP+8lvMawVODSi 8B4vNd+SKzy3KRi3oZZF7wZKbobEHArn+zV7ZUReSDhLguOhqmplXkfr2w7M4oL+IjIjtrutxGL l5k7Cl4zOicOnXyWWNHB5M9SHoqOlIxBdCth4eGLoEFBQeJkrkb4jORDaf5IWL1yFPBCNPTDw47 w45B0bvbpmu4eNKp0tGZEDpAsTnaSssqROZI1IFl6LPEs65Zga8TaXQSyFa4xKuUN9zDP7gITwS MScmeuZOf47Tyf+8nTCAYYmSe9DgobTjinFkeUiH6YmwgxCKRpWN5UejAZA6ipdfj8cr/77DuMT sPwKhzvde1MV9Y7Z5P0ElSAJrDMFVTh8ssatV5bOSiI09/KSoe+S74DoJaG7+xkXoptkVTs7mTf jKIaSJTU2cs2E5TEkrA== X-Authority-Analysis: v=2.4 cv=b9qCJNGx c=1 sm=1 tr=0 ts=6a37e71a cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=HwFTmRh04JSsUSWzyQ2edw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=1Eoo6ObXIGekxtLEpGMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: bkNLqmrSiUqMPNLSlw41n6BltNquWuxL X-Proofpoint-ORIG-GUID: bkNLqmrSiUqMPNLSlw41n6BltNquWuxL X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIxMDEzNyBTYWx0ZWRfX+wHCG/xqtMxy 7gA9/WHoTW0AglnYy6j1daE/fwrrJ4cwkvqfVS0qpavtL2ir6XkUnEh+rYUNUkJ33ENjKvfHwmA l9BOLiab68F3VeWUEQw8IZgUNedtauo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-21_01,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606210137 On 06-06-2026 04:54 pm, Dmitry Baryshkov wrote: > On Thu, Jun 04, 2026 at 10:56:07AM +0530, Imran Shaik wrote: >> Some GCC branch clocks are required to be kept always-on due to the >> hardware requirements. Drop the modelling of those always-on QCM2290 GCC >> clocks and use the latest .clk_cbcr convention to keep them enabled from >> probe. > > You got the feedback, but it got ignored. There is no explanation about > gcc_gpu_iref_clk and several other clocks becoming always on. > Apologies for the late reply. I have updated generically that few clocks are required to be kept ON due to the hardware requirements. For gcc_gpu_iref_clk clock the Power-On-Reset value is default ON, and such clocks are kept ON from probe. As Agatti is working functionally, I will keep this clock modelling same as before. And I will update commit text that the GCC video ahb/xo clocks are required to be kept ON similar to other camera/disp ahb/xo clocks. Thanks, Imran >> >> Signed-off-by: Imran Shaik >> --- >> drivers/clk/qcom/gcc-qcm2290.c | 160 +++++------------------------------------ >> 1 file changed, 18 insertions(+), 142 deletions(-) >> >