From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62D8413B7A3 for ; Sat, 27 Dec 2025 09:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766829306; cv=none; b=VjhHJ4Uu2QbTxxWgzC6LEqW/I2GSyPZRXBi3kcUSfS4Uj+Sjy0JMcc9Kbk6/aJwUiglBiwWbOkTQFz++FE3TaGmYH8UGY/brN1DdnAyZVl3tC5ET+FKSGGtdqKR6YZjKCA9Mq0dCFHurB9Dc0UdRvNmJ79+C69UQYybVWIkUgp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766829306; c=relaxed/simple; bh=9I1QiKUrMKVoaDhcMv5cYRF+th8Im4R1rdTl9uvbj2g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n3WvM/ONN2Ee5WP/6Qxx/5Gr0IW1CPOFkGR21icfcrHcSP6aqWxqsHkrMKFQKUqmRYv/+C0rA5vfN8CIkhfqaotaMWwsfW6E6EwU5Rl3hXVXiAknG45J3PcW0QIOk5DKWE1+7vQMAxKAQvn+0Q98P5p1TPfJpkfPCFfFLsZeBq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47d182a8c6cso33690595e9.1 for ; Sat, 27 Dec 2025 01:55:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766829304; x=1767434104; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MgeNdy0YuWWyqKLgp+AdynMOEeVGb+eYNCxj8IBexms=; b=vDZBDBcf4+5+8nPdd2SGS/xmZbJmTLvvgY2sipYrA2nEc9FNi6PPieqnXcCPk4oMfj lm1zTypg9fZbi797Cmxh28lx443rdG/c+Uc70r6/uzQDOFoaYzrpc91qy49jy87qwQAa L9G9Mi6aXorkDi9qQVPCyUbe6pFGBJg6MAZ2UkIowg9+QL+GM8Qgk+6S+VdQJbMAleiZ cOpZLCc4pDVNSlgTkqmiPGxMWvasKmPNcqQPRsTZ8vatyzlQW2VYlxljuMA9AxC33iuY lzQ2xvukwJDj+Xc/Ke02sdC02K23Cz8iqH6zZHExl/LmMKTy7jj+5QUK5/iPGf1FZkA2 zssw== X-Forwarded-Encrypted: i=1; AJvYcCWZp/OlH/1RSBPzhoVWbqMcvNqT41nzytGoYOf5EZpkkbwvz/c8dwXGB6YBTVUaOeEtQWEIqwfu6Lcyobg=@vger.kernel.org X-Gm-Message-State: AOJu0YzRydwJO0fiNvTx5HAg2RNiX/0hDkQITnkIESFPe/tN1VEC1vjT FtefcsIq1khReOxiUFQC2+BBC7LAtXJ/UNQyH1VsLu7LolsdWauw5Ytb X-Gm-Gg: AY/fxX5bH+lIIT+6vtHtXXp8UqXB8vDQxMv+fdjLtmffqCFK31Rc4/Cq+BuQQF5YqFE koku5w963/197ieX6EFamoExYot2i1AKmlV91m3YijA9gq7/xyisOfmSlVVFVEt0v46EOS+p5rD 7F/z/BWBVDyz9qq90Hta4njS5ciima04QqdJRA+mwKd7VlOBCQOIwmZWropZwEw9TRD7FcZxbXo y7nHnPZoT/I/3xf9FPmj1PXLDb+HLPKMliyQgz8DisFux8UfSOFbXwpELudpCbHlQ3/VGPQTmmn bvg8N3wyJ62wOPdLrOt3OgpTbzPzvUIooWu27+RynucqLGDQ7ZpWBRkGF1IFUa+CAnEA/rjG9R5 KPcLQvksiVorGesb6K1Mdd6dGWPX3Kie+69nxee34ymAwHAkCGdqqJiLV9QPCpqVdJt2U1evQ/5 zTCCP8o0SyQ4zclp0zs5ZGMFXLAZa8DiMu/hDWrnvyiXJYsWtRVgoCvw== X-Google-Smtp-Source: AGHT+IG+l0xXVfn/4KRXXX22pOz4Ge/Cx7X0UB1DTt9IgD0ZtWp7FnyqM1ZBFwbrjAr4tWDaUm+Yaw== X-Received: by 2002:a05:600c:3b2a:b0:477:b734:8c22 with SMTP id 5b1f17b1804b1-47d1953bd29mr266480285e9.8.1766829303709; Sat, 27 Dec 2025 01:55:03 -0800 (PST) Received: from [10.100.102.74] (89-138-76-94.bb.netvision.net.il. [89.138.76.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193d5372sm453678675e9.14.2025.12.27.01.55.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Dec 2025 01:55:03 -0800 (PST) Message-ID: Date: Sat, 27 Dec 2025 11:55:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 07/14] nvme: Add RECOVERING nvme controller state To: Mohamed Khalfella Cc: Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Aaron Dailey , Randy Jennings , John Meneghini , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251126021250.2583630-1-mkhalfella@purestorage.com> <20251126021250.2583630-8-mkhalfella@purestorage.com> <20251225171709.GA8129-mkhalfella@purestorage.com> Content-Language: en-US From: Sagi Grimberg In-Reply-To: <20251225171709.GA8129-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25/12/2025 19:17, Mohamed Khalfella wrote: > On Thu 2025-12-25 15:29:52 +0200, Sagi Grimberg wrote: >> >> On 26/11/2025 4:11, Mohamed Khalfella wrote: >>> Add NVME_CTRL_RECOVERING as a new controller state to be used when >>> impacted controller is being recovered. A LIVE controller enters >>> RECOVERING state when an IO error is encountered. While recovering >>> inflight IOs will not be canceled if they timeout. These IOs will be >>> canceled after recovery finishes. Also, while recovering a controller >>> can not be reset or deleted. This is intentional because reset or delete >>> will result in canceling inflight IOs. When recovery finishes, the >>> impacted controller transitions from RECOVERING state to RESETTING state. >>> Reset codepath takes care of queues teardown and inflight requests >>> cancellation. >> Is RECOVERING really capturing the nature of this state? Maybe RESETTLING? >> or QUIESCING? > Naming is hard. QUIESCING sounds better, I will renaming it to > QUIESCING. I actually think that FENCING is probably best to describe what the state is used for...