From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 922A5ECAAD1 for ; Thu, 1 Sep 2022 00:01:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbiIAABE (ORCPT ); Wed, 31 Aug 2022 20:01:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230421AbiIAAA6 (ORCPT ); Wed, 31 Aug 2022 20:00:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88C0E7B282; Wed, 31 Aug 2022 17:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=Vy9viZo5c1Cs22twzs93d/4uL2Kw42CK2c0Hxu3ubro=; b=1soSmH97o8W8jbuZ1w3OF5EvDF T8O7g8vlBZakvoElaYA/OrfyamBoMy2Mv1r7ia6r/8+CP+muZpWdmTNCGzZLUgisQhnKpFe+tJPYg qcCNA3ohp0mPbstAVcXLiAEJEKC5BGEDqs7YWLtdLhfmOTIruBYHIu0Pu/aNU4FAB7SOqGzdjo75m 8DHGmXVSpNQ5Ww5yPQduf5BHn0+e5WSDHKB/4elNXe25sLrIxAhH30CUdez1YmoAnpiPzEqzeX6YP mJiEMvBCmVcMzFZsz1EfG86mDMxjgGxf83JeeudoJ6Xy7t7Cz0ipkagy6eRFT6+YxrooWZm2rZbX1 wLR0VYeA==; Received: from [2601:1c0:6280:3f0::a6b3] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTXde-008l8i-Ay; Thu, 01 Sep 2022 00:00:54 +0000 Message-ID: Date: Wed, 31 Aug 2022 17:00:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: configuration x86/Kconfig bug? or AMD feature request Content-Language: en-US To: Steven J Abner , linux-kernel@vger.kernel.org, Hans de Goede , "open list:X86 PLATFORM DRIVERS" References: From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi-- On 8/31/22 16:54, Steven J Abner wrote: > Hi > I am tailoring a kernel for AMD 2400g on ASRock B450 using 5.18.12 as base. > I found a feature I don't believe I need, and the system seems to work just > fine without it. A quick glance at the code seems like I'll be just fine, too. > In /drivers/platform/x86/Kconfig:1159  I altered the text to: > > config PMC_ATOM >      bool "Intel Atom SOC Power Management Controller Driver" >      default y >      depends on PCI >      select COMMON_CLK I can't tell what you changed it to. > Please have a look and decide if x86 must include this code to function properly. > Nothing but being x86 selects this. 'default y' was chosen only because forced y before. > Steve > > I wish to be personally CC'ed the answers/comments posted to the list > in response to my posting, please. I not part of the list. That kconfig option has been deleted: commit 3cd8cc98d634 Author: Hans de Goede Date: Tue May 3 16:02:07 2022 +0200 platform/x86: Drop the PMC_ATOM Kconfig option The def_bool y PMC_ATOM Kconfig option provides a couple of symbols used by the code enabled by the X86_INTEL_LPSS option and it registers some clocks. These clocks are only registered on Bay Trail, Cherry Trail and Brasswell Intel SoCs and kernels targeting these SoCs must always have the X86_INTEL_LPSS option enabled otherwise many things will not work. Building the PMC_ATOM code on kernels which are not targeting the mentioned SoCs and which do not have the X86_INTEL_LPSS enabled is not useful. This means that we can simplify things by replacing the PMC_ATOM Kconfig option in Makefiles with X86_INTEL_LPSS and then drop the option. Maybe that commit should be backported? -- ~Randy