From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2065.outbound.protection.outlook.com [40.107.236.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF96A18FDC8 for ; Thu, 2 Jan 2025 05:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.65 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735796966; cv=fail; b=YL0hF/RsKrrwX2oVuKkxN21XX2auLgdEodIxjpHvl9tYtlPvDGouLgD64gKPQA+2gHtTobyKOn9f5KsqkIR6BkVQSzqmReK5PTiSdB8w946H5nW+rcE16Xh7mzI12Lgrk3g3ijSoMtIa4xK0WSFoRfkXDh5vA9PqbUuqqPX/SYM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735796966; c=relaxed/simple; bh=2nXIWBcIe/HnqHIUVLGD7KUMTID+k/5Ly1ZFezaSNsw=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=RYqlNgLpiDkELUgPs6KlgyPKfERGO2LYWsuSXRFJPLLoJuVtjmv88W5oBH23F0v4Q7VPITzN01FI76xdOonBRnIRQ8OGgUt9VDgBT+zyAWbrBmg7bFnT1jHDMEAcHsDQ3/poZsj1YHRQL3KztOvXMekgXOMdSq0PZYxhOsb8FYw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=XpGrsYKn; arc=fail smtp.client-ip=40.107.236.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="XpGrsYKn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oAFVUbWdkp3XCakTsLjQZAl913j7qkwwrm+jMlxzteAkNB90tjJKET+Nc2I/SVjQ27f3leKf9qE3FCzGWkFno4n4o1JeHieb1nl/y4v4B8Iwr6EneQHRHyknh8uYQVdmk/Hp4BwGyYMuA3Y3Ke69F9vBIWFOHz1j9uMa3nv0liYCwjD0cDQR0NDNPvEDXf6oYpV80YGI32VWGEqTt2aG9nttTMHq58YDzjt4D35Mm9hqRnillFrJtcpm5IAO5iNHaXICEFy7eLPah2t3qeU3KBQ2EjsRP8aja9rE/4z+ZlbSt3Z15tLNDJ/lATE+IaYo57t/2jwDSectWgInhgjYmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DAKoAwDB5n2M+tlCwFIWvkTMAgQXfQ188CrTCeNL6dA=; b=MUuLbSu3B1Fgofp3mLwvPD1gMCgKu5SAryVEI0aPZZR343aKYHtZCQ1NbinSOcR2yLSBrIwJSmsV38ayr/EeO2L/d9EvaW2s+lHCDoy+WHLectAFm6ua9GWlsarTjalxgmxQ/7QE6m58naCd36l9Gk9RIaUDCQObor/0OMmXjEqTK3WY9P75l1Ysk62BxnDvD1DryAOvpg7zg0QK/oSHks4RQUzsVsiQPRfF+1NrgK0y7SwlkLRUs4iFnMJLR9mBL+8ghReKSVSpiE/4+FmYbUn+8KdAafoRi3P1qAET0MIHFcfIyEutfJl33NwhNbAG5lMXdBRZZ2+rzgCL6+fZvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bytedance.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DAKoAwDB5n2M+tlCwFIWvkTMAgQXfQ188CrTCeNL6dA=; b=XpGrsYKnaXitwl7IyDI7Fcm+N6eg8NtOrkPWh1boE2MPJmP7oPoYEvwVeVZpxj6KfdHmeVd9SRkpl9B9QU8td2hKMRhmUDfqA2f/vrL9kmHUdtCQ3oUs95MiBDDgSICRvfhiz6TfKVgPAwgw7NUpcn88mVv4QHOyhDwgCX3uadY= Received: from PH8PR07CA0003.namprd07.prod.outlook.com (2603:10b6:510:2cd::17) by PH7PR12MB9102.namprd12.prod.outlook.com (2603:10b6:510:2f8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.11; Thu, 2 Jan 2025 05:49:15 +0000 Received: from SN1PEPF000252A1.namprd05.prod.outlook.com (2603:10b6:510:2cd:cafe::ce) by PH8PR07CA0003.outlook.office365.com (2603:10b6:510:2cd::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8314.12 via Frontend Transport; Thu, 2 Jan 2025 05:49:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF000252A1.mail.protection.outlook.com (10.167.242.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8314.11 via Frontend Transport; Thu, 2 Jan 2025 05:49:15 +0000 Received: from [10.136.35.245] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 1 Jan 2025 23:49:11 -0600 Message-ID: Date: Thu, 2 Jan 2025 11:19:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] sched/fair: Ensure select housekeeping cpus in task_numa_find_cpu To: Chuyi Zhou , , , , , , , , , CC: , References: <20241216122357.1276382-1-zhouchuyi@bytedance.com> <20241216122357.1276382-4-zhouchuyi@bytedance.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A1:EE_|PH7PR12MB9102:EE_ X-MS-Office365-Filtering-Correlation-Id: 24b0e56d-0c93-41d9-4f52-08dd2af130ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|36860700013|1800799024|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N3VyRndhdk45cHJxL2tucXROMWJDbk0yRTZoT1AwQ2Ztc1N1L3BaTHlXSGpM?= =?utf-8?B?NWhibStlWjg1QXRCUWQvUHZzdXpJWFlHVlpkbStrdllUb0NDai9mOERJejEx?= =?utf-8?B?NE9PN1ZGSi9SdVJydDFhVVRyTWJjOU9YZ3V2VEZnOXZnZ0lXK1ZmaUtENjZn?= =?utf-8?B?U3oySXJ1UWJzU2hZT3hQN2k1YzZjakxCSFZsRWwwNnN1R25ZLzQ3Y3JLYVlL?= =?utf-8?B?Q1NjcEJyWmk1eWpUVURWWVF2UTlad2xlTWE3bld4MnZiY042OGFTYVFScXN2?= =?utf-8?B?YU1JdHdHaElpN05ZMEl1aEw4V055RmVnWFZWbFdlRUsreUhvdi9USTZhVkR1?= =?utf-8?B?TGRFWEliaW1KdGlTbkdhQjJLZW1NNjBkdjFlOXp3Q3BZQktNQlZVWXJPWVZk?= =?utf-8?B?ejdob1lUS1U5V3VHTFRUSnZxSkQxdGxZeitOMWVPT3dLQ0Y2UW5RN0Q2QVhU?= =?utf-8?B?K3RVSnk2T21COWR3V00vMXBnZkZlK1BTZlMwMXpOamdQUUp4d0VUZzE3Wjk1?= =?utf-8?B?bm1jV0I1WVFuNURnVnFyM0Q4S2FrZWFLdktKOGZHL2hXZlM4YTJ5c250OWdr?= =?utf-8?B?WmVqUUZrWnk5djNJVlFPc2lDd1pESUp2d0YybEZ3ekZQeklNcytZYUJNRGdu?= =?utf-8?B?S3k5MnlUR1g3UDNzRkM5VS8yMVhWRmsvK3oyTEZVU2twUStCUHF5c3d2dStw?= =?utf-8?B?SVY2R21razdiT0k0NDRkYU81YUZjS2JRV2hUL2w1ZmJnV0p1bnFqT3NxdGp0?= =?utf-8?B?c0pTOHIyMWVSeENHNGgvMXRhN29JcVRDREozOE95MGN3cGE5L0FTTkVtTU1y?= =?utf-8?B?Qk5BRW5LV0cyMU93bExieTFDRDJhWTJybllBUlJiQjdzWWhqLzYvQlpNM2Uv?= =?utf-8?B?NmxGZG9rTDlIVFMreGpWeURTWnpOKzhPRFhQa1BBeDlzejkxN09ibVBFSlNT?= =?utf-8?B?QzhHdUlsUC8yaWgyclZrSHE0YVVkb3lMMkFpU1VVNnhDaW5jTW9XVVNBcFdX?= =?utf-8?B?cVA2ZThyWHh0Qms4ZlhDNkRIYW50RU5JY21Jb09jUnZhb3J0eVFXcEZySFZN?= =?utf-8?B?RHFmVENKdC94WlJrZEwyODVWcW5QYm9yRkxXb3lSVUZVL2pwNklpVFpTcHU0?= =?utf-8?B?QWVsNnpINHJFUkVNUGcyenF2YVpHSnJ5Tk4zTHI0NFB5L3dRU1Z2bVIvOWoy?= =?utf-8?B?RnIxZ0R2VmowVU9ESy9HZ0grYkpOT1lENENlOHFEaElWeHp2VzhSc3BVUGwx?= =?utf-8?B?UStNZENWVER6aEw0T3lGOTRiTFp2WGlseWoxVS8vb0dmRWZPQS9mekl2RXQv?= =?utf-8?B?eVd2WkdPMFFOaXE2dVhvcGR6anR3bGE2ZjhnWU4vTjdjN2VBYXZRUTFoZEor?= =?utf-8?B?R0ZrVUdpMG9la2lJMnJVb1djbHJrNXdrVlRoVFdtOFpmNTc3QUdDOW0ybTFm?= =?utf-8?B?dEw2RXdnM0Y0b1V0K1lnRVlGd1ZJZzB4SFE5OVVycDNuRC9aMm5pMTR0c3dw?= =?utf-8?B?MW03enNIUTREWWxxajd0bVRDT2ZjbGt4eVdUL1pMZTJYcEk4cVlIRWR3Tlk2?= =?utf-8?B?S0ZJa0gxWW9HdzNia1hqYWVaTTlicWxtbXBCVTJ1UDlzc211Y1BySUdTUEY0?= =?utf-8?B?b1dldFlQWG8yVEx3SWF0TlpPRTVHZWkrUWEvNVBTbmxYZHQ4MDF2SVlNNm9I?= =?utf-8?B?SFRHSnN6WnEwT2VhK0FLRzVkUlVCdG8yYnFyWU9OOVN0MnNhTlpPRGt6anFX?= =?utf-8?B?WTJocVg4eUxOc0J0aTBSZ09UOUs0b3FodEQrN29udVdhcUs1aGxmUTVONytv?= =?utf-8?B?cDlSWEhIUjREYnFYdXlmTE9LQlUreXZ1czBIVm51Tk95TVU4MDRPNmRYeGIx?= =?utf-8?B?SzZ4MEJ3YUZDSDFkVjdZaHR4ZU9ObDF5YnNCQ1duSm4wMm1WV3ZRMXlnL3VZ?= =?utf-8?B?ci91a2g0b0d5c1NYdUpuWm5XYUZoL0oxOGZhSUp1NkxhYjhsY21pYlZHT3FQ?= =?utf-8?Q?Kfo6lx+/s8rUm6g9h4n84g+7jR6//o=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(36860700013)(1800799024)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2025 05:49:15.1950 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24b0e56d-0c93-41d9-4f52-08dd2af130ee X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A1.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9102 Hello Chuyi, On 12/27/2024 1:29 PM, Chuyi Zhou wrote: > [..snip..] >> >> I think the for_each_cpu_wrap() was used to reduce contention for xchg >> operation below. Perhaps we can have a per-cpu temporary mask (like >> load_balance_mask) if we want to reduce the xchg contention and break >> this into cpumask_and() + for_each_cpu_wrap() steps. I'm not sure if >> any of the existing masks (load_balance_mask, select_rq_mask, >> should_we_balance_tmpmask) can be safely reused. Otherwise, perhaps we >> can make a case for for_each_cpu_and_wrap() with this use case. >> > > > for_each_cpu_and_wrap() is a good idea, but it might be slightly off-topic for this subject. Perhaps we should stick with this implementation for now and see what others think about v2. Sure thing! No strong feeling from my side :) > > > Thanks. > -- Thanks and Regards, Prateek