From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEE261A9F91 for ; Thu, 19 Feb 2026 11:34:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771500875; cv=none; b=Q1bQ8gglVtKMssaUAvT1sfpHcAlXZEOqnpQdu1kOL8dgJqTn/YwGs1cW/mojFrywtujggiaNZ3YpRdPbyf65TEIY3/y2CbWW9fTEs0fFgHSdSn7kzZ95WYLAl6OyBTYizXoMjaC9aGRtnW+GlLsjd18m9BpjJUfKiAEJ0ymTs9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771500875; c=relaxed/simple; bh=oUyXB+CcIwbGHWIhJYWqa28ISLsKSEJ27xTfntLMOyA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r6/kx/zjqtPCqr5IDq+Tm6qX3nCbLQZED61oHKU/WfgGQVX7Jemq7wSSwqQ9P/tYA2d42OUuEfqt1RkqsJPqKVayGK/8aNNwGW/SWFv8qez6Fuyxm20tbKHDWRMsdD6C4eGH1p4L1/ZLQKVyNdrayo7Zw3GeHLFjplp70vbfK1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bYxjMDFg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TNO4LkR1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bYxjMDFg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TNO4LkR1" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61J2j3rN3272014 for ; Thu, 19 Feb 2026 11:34:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P9+d9vwGLTBNf371LFltJnF/8rrYiRV01DBK1yVs86I=; b=bYxjMDFgorXVUUXl BlS/Rco9z96Vgbz0ba35wh+pF9ehymEJSOzR/NcG5qMwKEcOaLI0vyg5H6IcEeHj 06jCpXm1FToqo07ciGAhIaFhwyUDm1/cjntQTi+65SgCheFmToXVm/0tqH061RNH HlRovB9OM0eaQEsoSjDc1T8aoFkITHdqQ6b1xOlAbLYJzjjpcwJo4BjJZ962ilQM 8hZd3yVHmI6PKBIVQTiPWD1DXGScsFDiFryEicblbSv51f8ndg+aP+24YcNyEj9f +dGH81WhdVsCNXxL+wq+4r+e+oLU8/32jmEQ9g2VaCoQu8BgX4SowaeMdKGSZuSl p9ddGw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cdrk819w0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 11:34:31 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a7d7b87977so9635895ad.0 for ; Thu, 19 Feb 2026 03:34:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771500871; x=1772105671; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P9+d9vwGLTBNf371LFltJnF/8rrYiRV01DBK1yVs86I=; b=TNO4LkR1LzVbr1jJApm6A0jA09JBG1GM5LWFKtyLUm7DYv/YpWXlGau3yYUO6dW4PS vPLQJ1DDlPIGOES2M5zNslft+4SAyOjLqXaXoRqWzazhAh/ZV+a/NxEqNwldsXrsSQ2a Sz/e48PdMHg9QMSsrvkN1Gz4Adjt/xYLLjykt0t4mbDN3gv2bjCK2KOj1pglGFNDk8E5 N+sC0TTt5Q+1yOu5HiGJ8I0FFE8uXZla9kHxcNZnCY1qvfu3PSMwHoKAWb10gRccuUPk yWOqW+Fc1U/DxT+bK1oaGEKysMaK6T2kS6nDrRTyEx86jUrPg9YkwEgxll3+Ir5fyTQD f9Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771500871; x=1772105671; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P9+d9vwGLTBNf371LFltJnF/8rrYiRV01DBK1yVs86I=; b=qhfyM6IKsgOaOI9jluaf0xYTki52QYVaoiolyG9V1ZJ6Nxn0Tm6epVNzdMkBEkD4gt oZfqjOIDUrQMzu8eqkMpYCBSBRTvM42CMmz7ErB+yiRqhykSw3++1+4etQk9T2uxMKM/ 2ZdIg820DgveHhBKTlX7ddWJh0prLMt+CAPgX6qc3gX50ZpDHRNUSFcL54ToaOjCzAZh Wj/a/LkzgD6owzkp/0XcNqtoB/hOxCsy9yszzRVxOIH6oHZk+bC80YCcshYWR8xqclL6 7DqLf4I6COvdn3qR8zsrjcOOJ1jit4gT24ggHGWS/IMvPdsGztMXf9zB3FPpk3cI0zxp r4Iw== X-Forwarded-Encrypted: i=1; AJvYcCWkBvzuVMQ513Lo+xCUBu16HBpfNWAtbgUo64hk5EEVmKHz/VRMJQU3Wk++NsgK3VAKVh7VR9EalNEvWIw=@vger.kernel.org X-Gm-Message-State: AOJu0YyLEgtWDMHcygwqg37c79FUFn+vcI2c1N2v6qY/+QS7t+gKHi/e qi0ATOQIETttr2Z2kRz8U18O9ZNMlX5zB9GnVLl7it/pNiNV1YNP6SBs90zPIQNrE0nOlJkp8LW Ctqxmt+hIuFtB+nijnrkoZkPpZomg4N8SwC8dGghE9ZWCPeiL/c7eCKky/J1cQtXVxy0= X-Gm-Gg: AZuq6aKuNuZIhBHW7xI/d+1AFux5DD96Ci14/GllGQcoB1NOq0d/0L29SXLgc1FgCFW LGn04hZw9eGbseQFFGjbAKSZpg9hBdYK/P9TDyMiDaAi9tVW2s4vBahd3i1SwI412S7I29IRK64 bmiu7YyEVCbL9a7KzxN6fc9Qohni1gkKZHFXkwO8ZIPkSmia+L8k8scLLFBAoLiep8isOurdNEu m/ov5vd2YYH5+0ujB7jy2MMTAGmltLcSAY8AJZrJ94k7UcyfK5cpxQBjnTgJ9brXL15fHVEInCa FX8vAFl+q+iiXxuokSIUmwjgczYEdGQsibumZ0vV7O7KFffFAZy5R8e/X4nQhtbLH/IdgFEWlZM Fv+PVvtzsT7tWZA/bRefqDLJwUv3/w28QprqepC55OCja8yGoFd4gVDX/4g== X-Received: by 2002:a17:903:3c68:b0:2a9:3211:29f0 with SMTP id d9443c01a7336-2ad50ff2e5bmr40930225ad.58.1771500870510; Thu, 19 Feb 2026 03:34:30 -0800 (PST) X-Received: by 2002:a17:903:3c68:b0:2a9:3211:29f0 with SMTP id d9443c01a7336-2ad50ff2e5bmr40929965ad.58.1771500869953; Thu, 19 Feb 2026 03:34:29 -0800 (PST) Received: from [10.217.198.130] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a73b0fesm163193945ad.38.2026.02.19.03.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 03:34:29 -0800 (PST) Message-ID: Date: Thu, 19 Feb 2026 17:04:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: pm7250b: Enable Qualcomm BCL device To: Konrad Dybcio , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , amit.kucheria@oss.qualcomm.com, Daniel Lezcano , Gaurav Kohli Cc: linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260206-qcom-bcl-hwmon-v1-0-7b426f0b77a1@oss.qualcomm.com> <20260206-qcom-bcl-hwmon-v1-3-7b426f0b77a1@oss.qualcomm.com> <98ad13d8-82d0-4def-917d-b99cf455c5f1@oss.qualcomm.com> <91425550-35f6-4941-917c-f639dfadb42d@oss.qualcomm.com> Content-Language: en-US From: Manaf Meethalavalappu Pallikunhi In-Reply-To: <91425550-35f6-4941-917c-f639dfadb42d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: mFEp9i3PenrjKWLa46bvdrmnYYbQvSqS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDEwNSBTYWx0ZWRfX/hG5NK9ejkNa oc6Gl1D8S+fQ7CgGcpuLghv7WGf82x4uk/1MHUK5lwTWRu94zmsC1YlbwP1X+NkUPg+GVtCBNiT VuvGvNs7KWzGLVjO3Q28DzaIAe5doOobnhgBMMgOUsumZLaGgt0nD+Aq8CKbRwsakc7KHcv2fbq n6FsrP4df9Fv32zJmIar0d8YGAuINPtWkL89aIKWDk4Uxa3UpyGzOL0JYS96gekkW6Ids/wt5J/ 3B6CFnpiqbUkPRYp7SlTecf1GRNeQPB2pVZ6ex0xrF+rMZ7kyOgZEm8wa4TLqBe/BONGkXvE7Sf snXUT16M+rCJ1T+IjT+s+Da6IrQkj1tDuQYC6afNCj448Pv8d35IeHg0gxR6JLywSHMvZEIhTqw 1MdCr3v0mK1VRwKoOBVzxjAm1xFnVlegK+BiwIhgzsG0geSIEecYIIsBWXpZiw+xJXEN/qQD0Zx dTJGaWmQCWRdtlu/83w== X-Authority-Analysis: v=2.4 cv=MJBtWcZl c=1 sm=1 tr=0 ts=6996f547 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=qeKA5tGg5t4KbAWVeC4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: mFEp9i3PenrjKWLa46bvdrmnYYbQvSqS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-19_03,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190105 Hi Konrad, On 2/16/2026 5:18 PM, Konrad Dybcio wrote: > On 2/13/26 12:55 PM, Manaf Meethalavalappu Pallikunhi wrote: >> Hi Konrad, >> >> On 2/6/2026 2:41 PM, Konrad Dybcio wrote: >>> On 2/5/26 10:14 PM, Manaf Meethalavalappu Pallikunhi wrote: >>>> Enable Qualcomm BCL hardware devicetree binding configuration >>>> for pm7250b. >>>> >>>> Signed-off-by: Manaf Meethalavalappu Pallikunhi >>>> --- >>>>   arch/arm64/boot/dts/qcom/pm7250b.dtsi | 10 ++++++++++ >>>>   1 file changed, 10 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi >>>> index 0761e6b5fd8d..69ad76831cde 100644 >>>> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi >>>> @@ -202,6 +202,16 @@ pm7250b_gpios: gpio@c000 { >>>>               interrupt-controller; >>>>               #interrupt-cells = <2>; >>>>           }; >>>> + >>>> +        bcl@1d00 { >>>> +            compatible = "qcom,pm7250b-bcl", "qcom,bcl-v1"; >>>> +            reg = <0x1d00>; >>>> +            interrupts = , >>>> +                     ; >>>> +            interrupt-names = "bcl-max-min", >>>> +                      "bcl-critical"; >>> We should strip the "bcl-" prefix, since these interrupts happen >>> to be under the bcl device >> Ack >>> >>>> +            overcurrent-thresholds-milliamp = <5500 6000>; >>> Is that something that we expect to change between boards, or is >>> that an electrical characteristic of the PM7250B? >> Yes,  It can change based on battery used for that board as these thresholds will be close below battery OCP spec. >> It is not based on pmic spec. Max current threshold support for specific pmic bcl is taken care in driver pmic data. > > Okay, so this property must not live in the common PMIC DTSI then.. Ack, I will move it into board file wherever it is required in next revision > > I think ideally this could be communicated over battmgr, since it already > has a lot of information about the battery that's currently connected to > the device. Do you think that would be reasonable? Would you know who we > could talk to internally? We are not adding any battery information here. This configuration is specifically for the BCL peripheral to monitor current and trigger an over‑current alarm. While the BCL settings are derived from battery specifications, they are not the same as the battery’s own limits,the BCL thresholds will always be set below the battery’s OCP specification. The intent of the BCL is to provide early detection of over‑current or under‑voltage conditions, notify the SoC/peripherals, and allow corrective action before the system ever reaches the battery’s actual protection limits. Thanks, Manaf > > Konrad