From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4FB631716D for ; Thu, 16 Jul 2026 10:10:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784196646; cv=none; b=nKgeDCyJBAmMa/Bf7qyKOm3wDf8pDUYzIDzfs7h8wRePkz4jZQm/koixrV7HLlkxRXM5pTXZVju3zVasop1e6Uuh8q/gds1XgPRYnpOvXFkZYYFQXwsHOLaPXYylKQvKHa+FrO0NvyXfkWVyLkVllR0AktQVO0MlxEN/P3cXDlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784196646; c=relaxed/simple; bh=twhUx38eH4qiG2ma4mh6WJi4kCf8F8rtWTBtv0EIWpU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k4fuUiuoolsbsKOtzoPk1OYSWg9rBFro7hJ0lxioUXdp9WdhGQJQLKGhiQUqcegoTJGDc1gWVCMkctfMrY2xGBEdvMJ1PoOS/Z7NZBzIp5jgtree9H7dyZTBxAn3mxmtpe71SFhbN7r9PFtC2g6Xe+u0vDXiSh8UovKp3Et6Blk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jLViiwzL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D5sffXLE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jLViiwzL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D5sffXLE" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66G9s0NJ2248504 for ; Thu, 16 Jul 2026 10:10:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QN0SyLSXER9wXPtaRKAI1HftDAC7W1HO9axuocXmIPw=; b=jLViiwzLF34KY+zg TeJflCON7eMVGt+27rpCdtlqnUPTewEouBMTD3YilGBi/3T0KuUEtie43rF2Pmso VkgVn3b/dkiQr7GQ//PsObnI4iS7ElE6ISV6MJQZglcqh/Ls6H0Sy/LQhyIEleH/ tPbSdlmatPg5PrTDE5NvE7CaRRdVFhy959cyIoPCJ+OYw+oYX2lwzEbVdfgCuGBj xgVcLBlX75OZ/M5Ddz18WSqw+7R0Gkm4/ZREuxE34EVxEdbCNVEf5kz2LvuEuoGX pQDSh43gscrNlbfqMQY4VJhbFH4lArCY7CHgecaZj+WLnmcW7HVl0GRjdIFG6+V2 1dLeJA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4feehvb6y8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 10:10:44 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c9c26587e67so680576a12.0 for ; Thu, 16 Jul 2026 03:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784196644; x=1784801444; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QN0SyLSXER9wXPtaRKAI1HftDAC7W1HO9axuocXmIPw=; b=D5sffXLEuLToFtkLo30y9TQnu/uzv91xgpHi2CNJpt406t8Zg1Go/hCq9uxRtsbtsB N5HR2z+vcl5ecYEJspcNpduLrPmGdX/6jsDu7SMUE3EerWVk1cQV/njtgiG0UdKPJpkT yEt8OY+Twstmy7cWe3d88rMKXZWgq5E2DPVBcg/4n6Vb5hWzD1euXP3Nj+ChpJPMyo3X sdeuoUn6KziKZFfdVqvewd7IF7E7JCccCeF+bLuqMPnJLP5xwrbD+v9AIakgqL7oQ0Si vkS2RoXbhzFhrisKhXgUPqO+aUj+SG11oKgaTyc8BrJul46xeswd+iRMRoQtZxNkfbdF t0kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784196644; x=1784801444; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QN0SyLSXER9wXPtaRKAI1HftDAC7W1HO9axuocXmIPw=; b=GhQhCI4U8CU82J2o7mQNJqy3YOKnpCqOLgRtkOjwO1sJCnUriOPPIGJsl8YwSDJoQd N6fD4zen0f00L+jpuwkEnO7BKbv/exMtUDus3KILLoSUEcODZhNARClJvq7aSBjPJY7n SCRopQL4qTuCT88f4amYcHYyiJJI1GqKqB7IFwi97MxMKCIcAu8EVw3KUTTLvXG3TqLa OTnOv87P6fmHRuuZz346NLpNIDt7eqaoq8ZtlDF2ovPj8CIsSxW8u9BHlSce38z7Tsv1 cyL/LgBDjNBFY6en68svqOi/tXA8NGSBSsnEO+hcwxu2hEPAZi3yej6GEUQ4lAqZkxlf IR9w== X-Forwarded-Encrypted: i=1; AHgh+RqB/anaF+KTrDd8cMTTw38F0DLxhB+L/buLOe+kaEuk8Pt250HayWNR3J9UKUwJ51gerfhD3FX5snRHkK8=@vger.kernel.org X-Gm-Message-State: AOJu0YwGPkfsp+ZVsJDUtKEki703tVHKggq2yKcTc6p/WxuVjYR33kJL kXjME1vrlT2tPRj2qcOfcheR5x9y4RMQroN99ske1s5kQUF33ydwdQRDxLSrzwftoG7NXH8aSpT T9TUGF5ZoiV9Ip3Xsrr5xKnAqQQBpusu9H5MwejydntDG/WhdTWiiufFdw4C7HqWuxRY= X-Gm-Gg: AfdE7ckEgUA0Xh2cjpdHeFWbpVCBaGP2dP26njzGXteZmjoMb8b4lsILl0wR0p+iupy 8UXKYUK+7+/fYS8ey+xzIccL5+KDFYcBvuNSW+G+Eo4mDVvBcUtjntZhrK8tGNgZGhk7nuhX3uz j2GOXe/Lu7R4HmQseVAUkA+kmT60pNAy2g9p7k+s6kO47ctrPaUk+Y5nzqGZu46aETp+OCheiwQ 8wB0fCBEFC1hdOzEhSmSiO9wDDYn9Ylfci7FBIeOiNm5ZnBRn5Y24m86ps+/+LuSsAnSFd3zNeZ FVuaTnbHLNnhLUnaNV/nsAyAaqnnynH9C3q6+XO7vZTTKnWP26d8ueGHO3xOK/TrNSWS+Qecl05 uCYnmsfqLeSV32+bK5ag9ph1Ubl0x0iA39Zo= X-Received: by 2002:a05:6a20:e293:b0:3b4:6af4:bdd5 with SMTP id adf61e73a8af0-3c38d90e685mr2611989637.15.1784196644208; Thu, 16 Jul 2026 03:10:44 -0700 (PDT) X-Received: by 2002:a05:6a20:e293:b0:3b4:6af4:bdd5 with SMTP id adf61e73a8af0-3c38d90e685mr2611951637.15.1784196643655; Thu, 16 Jul 2026 03:10:43 -0700 (PDT) Received: from [10.217.219.142] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13cd4344b8bsm9552696c88.13.2026.07.16.03.10.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 03:10:43 -0700 (PDT) Message-ID: Date: Thu, 16 Jul 2026 15:40:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] spi: geni-qcom: Fix sticky ret causing wrong return value on invalid proto To: Praveen Talari , Mark Brown , "Rafael J. Wysocki (Intel)" , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter References: <20260716-fix_return_error_code-v1-1-3295003aacd5@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260716-fix_return_error_code-v1-1-3295003aacd5@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ZpDd7d7G c=1 sm=1 tr=0 ts=6a58ae24 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=hRfWpAjuP3xw3JzzUMgA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDEwNCBTYWx0ZWRfXyt3gqq35yFNK s2VauFvVQOJWNqWH3k3lRfb1Inr2DukMTrgOMbSzi+N1AdLMB6HEe3GCD+/4yU9rgkuWMnzBuou cvs2rTUkmorVt2VsbYG21VCD3X+kivGiTUY9yUCEJzsDlOjKdNzgUqWoASTl0ljXiZvAi8Dr+4H owx9BAjcKTSgAC+zWGbWkRNYeGyu25JMfg0firX1OnCg0iIsvMbgF9X7mB+sRYq39xlRpkfOnAJ RFeqtRKMhzNHvU4RCSfQ77Q3CWE7cqwIObVNxgJ2WQWx+eibG/bn+wg/k03b34zuTnkkwezwCLK DgvTwSB3ZjwKn8F978zWeWQr6r1uHSKv6uQX/yN9j7N7XE11lP9fzUHYrbGGhJcwn1pV8gdo2cI N2kyGR/FleFxBPUqJjjwLWL0w2Sqi3I/JDoLVyhc4eqlTj+yWjyUlSUOvm81VLXK5dIWD5XaDM2 iRek24urOx+9AXZcE3A== X-Proofpoint-GUID: lxg1zwdPFOq_jEVgiMA6GqdSZTkYaqKW X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDEwNCBTYWx0ZWRfX8MdxCE9XhFXt 8TdPYrltGgNUTLjUNDKiwujraPmRngxQM5Ei+UJ75c77o6SpTHwecVAvPk/KJ9hMXPpTmrar4fb iD/Vh49dOPghczkmz62X0l0ckByyxF4= X-Proofpoint-ORIG-GUID: lxg1zwdPFOq_jEVgiMA6GqdSZTkYaqKW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_04,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160104 On 7/16/2026 1:55 PM, Praveen Talari wrote: > spi_geni_init() reuses 'ret' after it has already been set by the > runtime PM acquire check earlier in the function. When an invalid > protocol is later detected, the function returns this stale 'ret' > value instead of a proper error code, so it can end up returning 0 > (or some other non-error value) even though the protocol check > failed. > > Fix this by returning -EINVAL directly on both invalid-proto paths. > > Fixes: d8e9ea989acb ("spi: qcom-geni: Fix missing error check on pm_runtime_get_sync()") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/202607122241.qzP3QAXF-lkp@intel.com/ > Signed-off-by: Praveen Talari > --- > drivers/spi/spi-geni-qcom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Mukesh Kumar Savaliya