From: Devarsh Thakkar <devarsht@ti.com>
To: Jiri Slaby <jirislaby@kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sebastian Fricke <sebastian.fricke@collabora.com>
Cc: <mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sebastian.fricke@collabora.com>, <linux-doc@vger.kernel.org>,
<praneeth@ti.com>, <nm@ti.com>, <vigneshr@ti.com>,
<s-jain1@ti.com>, <r-donadkar@ti.com>, <b-brnich@ti.com>,
<detheridge@ti.com>, <p-mantena@ti.com>, <vijayp@ti.com>,
<andi.shyti@linux.intel.com>, <nicolas@ndufresne.ca>,
<davidgow@google.com>, <dlatypov@google.com>, <corbet@lwn.net>,
<broonie@kernel.org>, <rdunlap@infradead.org>,
<nik.borisov@suse.com>, <Dave.Martin@arm.com>
Subject: Re: [PATCH v2 1/6] math.h: Add macros for rounding to the closest value
Date: Fri, 30 Aug 2024 21:39:32 +0530 [thread overview]
Message-ID: <f6331333-dc3c-b28c-2bbb-229a180c9ede@ti.com> (raw)
In-Reply-To: <8bcddd10-6699-4e76-9eaf-8768f1c1ae66@kernel.org>
Hi Andy, Randy, Sebastian,
On 29/08/24 15:24, Jiri Slaby wrote:
> On 29. 08. 24, 11:19, Jani Nikula wrote:
>> The stupid thing here is, I still don't remember which one is the
>> generic thing, rounddown() or round_down(). I have to look it up every
>> single time to be sure. I refuse to believe I'd be the only one.
>>
>> It's okay to accidentally use the generic version, no harm done. It's
>> definitely not okay to accidentally use the special pow-2 version, so it
>> should have a special name. I think _pow2() or _pow_2() is a fine
>> suffix.
>
> Concur.
>
We have got 2 votes to change round_closest_up to round_closest_up_pow_2 and
likewise for round_closest_down to round_closest_up_pow_2.
Kindly let us know if you have any concerns w.r.t above name change. Else, I
was thinking to proceed with the suggestion.
Regards
Devarsh
next prev parent reply other threads:[~2024-08-30 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 15:08 [PATCH v2 0/6] Add rounding macros and enable KUnit tests Devarsh Thakkar
2024-08-26 15:08 ` [PATCH v2 1/6] math.h: Add macros for rounding to the closest value Devarsh Thakkar
2024-08-26 17:44 ` Andy Shevchenko
2024-08-27 11:27 ` Devarsh Thakkar
2024-08-27 12:40 ` Jani Nikula
2024-08-27 15:14 ` Devarsh Thakkar
2024-08-29 9:19 ` Jani Nikula
2024-08-29 9:54 ` Jiri Slaby
2024-08-30 16:09 ` Devarsh Thakkar [this message]
2024-09-30 1:18 ` Randy Dunlap
2024-08-30 13:45 ` Dave Martin
2024-08-26 15:08 ` [PATCH v2 2/6] math.h: Use kernel-doc syntax for division macros Devarsh Thakkar
2024-08-26 15:08 ` [PATCH v2 3/6] Documentation: core-api: Add math.h macros and functions Devarsh Thakkar
2024-08-26 15:08 ` [PATCH v2 4/6] lib: Add basic KUnit test for lib/math Devarsh Thakkar
2024-08-26 15:08 ` [PATCH v2 5/6] lib: math_kunit: Add tests for new macros related to rounding to nearest value Devarsh Thakkar
2024-08-30 14:07 ` Dave Martin
2024-08-26 15:08 ` [PATCH v2 6/6] media: imagination: Round to closest multiple for cropping region Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6331333-dc3c-b28c-2bbb-229a180c9ede@ti.com \
--to=devarsht@ti.com \
--cc=Dave.Martin@arm.com \
--cc=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=b-brnich@ti.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=detheridge@ti.com \
--cc=dlatypov@google.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jani.nikula@intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=nik.borisov@suse.com \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=praneeth@ti.com \
--cc=r-donadkar@ti.com \
--cc=rdunlap@infradead.org \
--cc=s-jain1@ti.com \
--cc=sebastian.fricke@collabora.com \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®