From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Pali Rohár" <pali@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Marek Behún" <kabel@kernel.org>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds: register-bit-led: Add active-low property
Date: Fri, 19 Aug 2022 09:46:56 +0300 [thread overview]
Message-ID: <f635d5a7-6817-cd62-e395-63e346775716@linaro.org> (raw)
In-Reply-To: <20220818172528.23062-1-pali@kernel.org>
On 18/08/2022 20:25, Pali Rohár wrote:
> Allow to define inverted logic (0 - enable LED, 1 - disable LED) via
> active-low property.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> Documentation/devicetree/bindings/leds/register-bit-led.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/register-bit-led.yaml b/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> index 79b8fc0f9d23..5c6ef26f1a94 100644
> --- a/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> +++ b/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> @@ -43,6 +43,11 @@ properties:
> 0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000,
> 0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ]
>
> + active-low:
> + $ref: /schemas/types.yaml#/definitions/flag
This could be shorter: type: boolean
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Although the question is - where is the user of it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-19 6:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 17:25 Pali Rohár
2022-08-18 17:25 ` [PATCH 2/2] leds: syscon: Implement support for " Pali Rohár
2022-08-26 8:05 ` Linus Walleij
2022-08-31 11:49 ` Pali Rohár
2022-10-09 11:40 ` Pali Rohár
2022-11-01 22:32 ` Pali Rohár
2022-11-08 12:42 ` Linus Walleij
2022-08-19 6:46 ` Krzysztof Kozlowski [this message]
2022-08-19 6:56 ` [PATCH 1/2] dt-bindings: leds: register-bit-led: Add " Pali Rohár
2022-08-19 8:08 ` Pavel Machek
2022-08-19 8:38 ` Krzysztof Kozlowski
2022-08-19 8:42 ` Pali Rohár
2022-08-19 9:08 ` Krzysztof Kozlowski
2022-08-19 9:11 ` Pali Rohár
2022-08-19 8:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f635d5a7-6817-cd62-e395-63e346775716@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kabel@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pali@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®