From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF4A530567E for ; Tue, 23 Jun 2026 16:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782230580; cv=none; b=e3BbDQ5DRdquFZna/dFudzMeuqMPvJfG8hmj4OCLtXBbWmTWSmqLs/GoW0qKvLzel1GWdmEPNjANkqo9x+elXHnhMVc9iDBSdqKcWhETq4sQu+CuuEuFZKXfPP0EjosnyMM03LCO22IZzaLDy8ecyVW8uIhYgSMv1htgTbx4Z1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782230580; c=relaxed/simple; bh=/UrQ1a5jEoyvccg5tsS/vfbkMBLFSzVTkQSDcxQ5qys=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q01Y/MznrIzH3BbqgeZ28+Bgiqg7JqX7L0yzebLi0i0KUnT4v9QAxSosYSrN6j6/maqgLsyiShC6cIpBTamIlTj/6/uMX1mhqCx3UbftdxwtpbmpBS0YnXSazcDM913Ugpp/jK+SA6+Qf6au56bwh5ajK2kfaZYgEIX3p3GdSKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jwk1pkc+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jtbFu6dG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jwk1pkc+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jtbFu6dG" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBZD3w031271 for ; Tue, 23 Jun 2026 16:02:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EDBaC1eXq5Juv4WWLDTwG9RBd5emtPKDg9brhkdKs00=; b=jwk1pkc+AGsWUUK9 dieU2WZWUbpVICpERalDXpEDuZLM9VJPIyIbpY0nLZUanFazpPhCGmj8jpYYRVqe rlymjFByyNLcA+jtd4O991Z/3dPPGxCoZl7Hrk+Y4vkJ8y9CscF3LvftTPYNV+Mt vt0LP5FUzvxIF+mRMYf+na/pMtrI0u6rD31yka+ieA1WC5LK7OCaQxDExGdDdvnz wmjf3uG2m97NlpftWNbzJnAQxD2C5zFAOgW5K7RDs+gYd0GsJXt3NUIE4KKxSvos x0emNgfvhqQL1V0O8F858JhFm5y9SUmWvWAND4k7k5dh3xqZnv332eJEW+/FPUS+ TeP0rQ== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyqe69pap-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 16:02:57 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7e5fb37ac4bso4163a34.3 for ; Tue, 23 Jun 2026 09:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782230577; x=1782835377; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EDBaC1eXq5Juv4WWLDTwG9RBd5emtPKDg9brhkdKs00=; b=jtbFu6dGbQqJDRg0IBDVAvJBt9WFE2a4RUvCBzmb0xizsF5eJvwwPpX8c42poo22j3 1Frfscvm6DOykeol98/B2m6QmyuJKsSsmgg8rc8fmSwYfyaDD+yyM9gl+NuWriBS8/HM HHzOtl+jFg6M+fR37FIpXy+dX5cet06+zq7P2RNuN+M6+514Uk5rqo7kFIbeVz47wnd5 S1IyLdkPIhdTpk3EHz18ALHxisC86ai76w3N7b2U7b1bGf1NOap/gUuCDb7Pauz2Uc8M lDoNV3uEvWxCqSdujDSphOD7VOqbaujyk8d4WHbiPFxHyZy0HqV+MEh0vX804Ze4NJUh JR3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782230577; x=1782835377; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EDBaC1eXq5Juv4WWLDTwG9RBd5emtPKDg9brhkdKs00=; b=rBheNmTw3B1D+b9ZSnJahbJiNiKZ/SvlHuvukkgBKy2I/AcYo3OkVaDpXSSlqRKgJk ffu0gDWk9tPfuyJZrondWwy3uB2B7jg8ygy7K2YXYYcQ+QfRpPHBqxDJEzQ9V5FuTIoV Pp/Z0xeEOKSh6ZYuAMEDYKlydtqRDh7IRWTbGHVD64hLIDaywkAxUCuY1LHDOrrmAEzL FUe6+TFdda5ou3v9XTH6/iY8O9x2obTaPhJHs489KGQ6DEOmBmd8ek0vW0cokmWD2mmr PCwRKAFfbHkHP866OfkW5EVW8YwO+0uzWIZW5YzfPtyF5EIL2q2dOLYOp97w3coK8JmY f4Xw== X-Forwarded-Encrypted: i=1; AFNElJ/7y9LbMV/3gNkDguKt15ywXcyvi8UbT1GIHRnG1AHGuTj98xUV9BpooKUgNQaYpgftmqaTrO69HpiDoLs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzamd8f/HpSCRUgwqaEFXPDsYtswkATFBCjjbGXshvxu2RH66t0 BQEM8txcz9WdjClGe1YKdsyd4qUElJ6fjiGWcQE9B0mIBTKOf4iFJHye/9wxm5lyxqOhSZSFjLW RtFqXJcXCkPJ0+wZ6WRsxxCqq2x3I2qrTpx7tyvyqPxgfmfeXxOjpRbRBTCD7Rn6AL8a2mCPGL9 g= X-Gm-Gg: AfdE7ckVP9sZorrozLIaOZJ6zep7Ud2D9D3tdtOxoVlJhCLPBVLttjeXmp9b1r/hTVc CQdstCTA1AC7S8slTLnra1F+5WhRa8cEn9T6KwlUohWdHJXy+ZPu7yDhAh3UU6Ea0tritGjHsfB 5GsA0SiyAnqNgNP8VRPTU8EaSYFXkPvL6fg96iyNBwgpXh7mfOwoSvqSwZYLkGDuwS9INZhn1xG NzeDz3/3ErpmgVkjnVhhAhRC4qP+Vyu+EOeRY1+66tnUGEWP19S6MgX1VQTyk3XzxTN5n16OzZ1 OqzDdPw0MxdOMh+LJgsZV3mEnx2Uvo8Cy81jn7MfhOo2/8v7+/2dHHOk7IWk/lioaCB82x7xqVE dvn/heel1oS2TrC8kJr8mE4KnPZeU6/n4E4s= X-Received: by 2002:a05:6830:82b4:b0:7e3:f809:7984 with SMTP id 46e09a7af769-7e93c26c950mr8027515a34.1.1782230576855; Tue, 23 Jun 2026 09:02:56 -0700 (PDT) X-Received: by 2002:a05:6830:82b4:b0:7e3:f809:7984 with SMTP id 46e09a7af769-7e93c26c950mr8027473a34.1.1782230576359; Tue, 23 Jun 2026 09:02:56 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6977b86de31sm4777390a12.12.2026.06.23.09.02.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 09:02:55 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 18:02:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/8] iommu/qcom: Check pm_runtime_resume_and_get() return in probe To: Mukesh Ojha , Rob Clark , Will Deacon , "Joerg Roedel (AMD)" Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> <20260623122034.1166295-4-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623122034.1166295-4-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: cxBRRP46R4RU7HrqZv9_N8-F3KMtzPzX X-Proofpoint-ORIG-GUID: cxBRRP46R4RU7HrqZv9_N8-F3KMtzPzX X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEzMSBTYWx0ZWRfX1M8KMFA1kkcP I6q7/J9OxQpFJyTPNKxaYHkdPRzwsgqnvcvNoJz4i3NPmb0ig0WgLqBd7gB9G6llKZuLYarYRtD G1DsVjn2LcoYcUgrSm1eU+oHYlFBpcw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEzMSBTYWx0ZWRfX/Mrl0bmbhsaI HDPU9YzeFRg1urbLb5/mmbU/aWXR2EGwm4rKXRmJW0wGacrdfrx7Fmp6ayU3xwtWc7SNyJdcGz9 ODzQsTFfFeUK9Bt3VpQdUNdYKxOFc9Z2/Q1rNpzz9BhRf46j7n+eodvLp2pxMwyC8Q5p59k90oE 147eJPb14zOHqsgpm+qJeeq43+28h1QD3JTszAzfzkfo7MmuvyFVs8Rqu+5+7KNj7ETqgOvc9Sf cYk0c6KN5elAt2TrN6SqipS0f8xTsyGPvlxdZ6LpWbBg7DVN7DjUm8IFhTWcE+UQdTXyqZGRBFS /AXBku0AXTmeN8Q3guRIXxICpKAwfg3KAC4qePklkkoyy8kVix4066fsE62fVX2ZC9Le/hhkQT+ ggnktC0QX5e1Tg1oDEv6qL55Mx92X/kBBruugswGTis1sliNmGf0adHNT8rTdwbhRmvngFxS48i eCFPvu3H9BOG5+yLleg== X-Authority-Analysis: v=2.4 cv=OeKoyBTY c=1 sm=1 tr=0 ts=6a3aae31 cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=v1Fw_KadxetzZ5l6LqkA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=zZCYzV9kfG8A:10 a=eYe2g0i6gJ5uXG_o6N4q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230131 On 6/23/26 2:20 PM, Mukesh Ojha wrote: > The SMMU_INTR_SEL_NS register write in qcom_iommu_device_probe() uses > pm_runtime_get_sync() without checking the return value. If runtime > resume fails the subsequent writel_relaxed() would access hardware with > clocks potentially disabled. > > Switch to pm_runtime_resume_and_get() which handles the usage-count > cleanup on failure, check the return value, and unwind the already > registered iommu device on error. > > Signed-off-by: Mukesh Ojha > --- Reviewed-by: Konrad Dybcio Konrad