mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Wang <peter.wang@mediatek.com>
To: Daniel Lee <chullee@google.com>,
	<James.Bottomley@hansenpartnership.com>,
	<martin.petersen@oracle.com>
Cc: <alim.akhtar@samsung.com>, <avri.altman@sandisk.com>,
	<bvanassche@acm.org>, <tanghuan@vivo.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] ufs: sysfs: Add WB partial flush mode support
Date: Thu, 19 Nov 2026 17:58:55 +0800	[thread overview]
Message-ID: <f63d7506b930b710d9a31f082b97a0e43e75dd50.camel@mediatek.com> (raw)
In-Reply-To: <20261117004729.635562-1-chullee@google.com>

On Mon, 2026-11-16 at 17:47 -0700, Daniel Lee wrote:
> @@ -1672,8 +1753,29 @@ static DEVICE_ATTR_RW(max_number_of_rtt);
>  
>  static inline bool ufshcd_is_wb_attrs(enum attr_idn idn)
>  {
> -	return idn >= QUERY_ATTR_IDN_WB_FLUSH_STATUS &&
> -		idn <= QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE;
> +	return (idn >= QUERY_ATTR_IDN_WB_FLUSH_STATUS &&
> +		idn <= QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE) ||
> +	       idn == QUERY_ATTR_IDN_MAX_FIFO_SIZE_WB_PFM ||
> +	       idn == QUERY_ATTR_IDN_CURRENT_FIFO_SIZE_WB_PFM ||
> +	       idn == QUERY_ATTR_IDN_PINNED_WB_SIZE ||
> +	       idn == QUERY_ATTR_IDN_NON_PINNED_WB_MIN_SIZE;
> +}

Hi Daniel,

May I know why the ones below are not included?
QUERY_ATTR_IDN_PINNED_WB_CURRENT_SIZE = 0x42
QUERY_ATTR_IDN_PINNED_WB_AVAIL_PERC = 0x43
QUERY_ATTR_IDN_PINNED_WB_CUMULATIVE_WS = 0x44

Thanks
Peter


      reply	other threads:[~2026-11-19  9:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  0:47 Daniel Lee
2026-11-19  9:58 ` Peter Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f63d7506b930b710d9a31f082b97a0e43e75dd50.camel@mediatek.com \
    --to=peter.wang@mediatek.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@sandisk.com \
    --cc=bvanassche@acm.org \
    --cc=chullee@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tanghuan@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®