From: Matthias Brugger <matthias.bgg@gmail.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Enric Balletbo i Serra <eballetbo@kernel.org>,
Ben Ho <Ben.Ho@mediatek.com>,
Fabien Parent <fparent@baylibre.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183: Fix out of range pull values
Date: Tue, 9 Sep 2025 14:42:28 +0200 [thread overview]
Message-ID: <f6402ac5-114f-415f-ad79-4f523c601126@gmail.com> (raw)
In-Reply-To: <20250722171152.58923-2-robh@kernel.org>
On 22/07/2025 19:11, Rob Herring (Arm) wrote:
> A value of 10 is not valid for "mediatek,pull-down-adv" and
> "mediatek,pull-up-adv" properties which have defined values of 0-3. It
> appears the "10" was written as a binary value. The driver only looks at
> the lowest 2 bits, so the value "10" decimal works out the same as if
> "2" was used.
>
> Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")
> Fixes: 19b6403f1e2a ("arm64: dts: mt8183: add mt8183 pumpkin board")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Queued, thanks
Matthias
> ---
> This is just a few of the warnings related to mt8183-pinctrl... Mediatek
> is #1 for DT warnings on arm64. And by #1, I mean worst. :( It would be
> nice to see some progress on fixing them. Otherwise, seeing new Mediatek
> bindings rather than fixing the existing stuff makes me grumpy.
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 +++++++-------
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 14 +++++++-------
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index 400c61d11035..fff93e26eb76 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -580,7 +580,7 @@ pins-cmd-dat {
> pins-clk {
> pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
>
> pins-rst {
> @@ -609,13 +609,13 @@ pins-cmd-dat {
> pins-clk {
> pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
>
> pins-ds {
> pinmux = <PINMUX_GPIO131__FUNC_MSDC0_DSL>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
>
> pins-rst {
> @@ -633,13 +633,13 @@ pins-cmd-dat {
> <PINMUX_GPIO33__FUNC_MSDC1_DAT2>,
> <PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
> input-enable;
> - mediatek,pull-up-adv = <10>;
> + mediatek,pull-up-adv = <2>;
> };
>
> pins-clk {
> pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
> input-enable;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
> };
>
> @@ -652,13 +652,13 @@ pins-cmd-dat {
> <PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
> drive-strength = <6>;
> input-enable;
> - mediatek,pull-up-adv = <10>;
> + mediatek,pull-up-adv = <2>;
> };
>
> pins-clk {
> pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
> drive-strength = <8>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> input-enable;
> };
> };
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
> index dbdee604edab..7c3010889ae7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
> @@ -324,7 +324,7 @@ pins_cmd_dat {
> pins_clk {
> pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
>
> pins_rst {
> @@ -353,13 +353,13 @@ pins_cmd_dat {
> pins_clk {
> pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
>
> pins_ds {
> pinmux = <PINMUX_GPIO131__FUNC_MSDC0_DSL>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
>
> pins_rst {
> @@ -377,13 +377,13 @@ pins_cmd_dat {
> <PINMUX_GPIO33__FUNC_MSDC1_DAT2>,
> <PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
> input-enable;
> - mediatek,pull-up-adv = <10>;
> + mediatek,pull-up-adv = <2>;
> };
>
> pins_clk {
> pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
> input-enable;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
>
> pins_pmu {
> @@ -401,13 +401,13 @@ pins_cmd_dat {
> <PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
> drive-strength = <6>;
> input-enable;
> - mediatek,pull-up-adv = <10>;
> + mediatek,pull-up-adv = <2>;
> };
>
> pins_clk {
> pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
> drive-strength = <8>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> input-enable;
> };
> };
prev parent reply other threads:[~2025-09-09 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 17:11 Rob Herring (Arm)
2025-07-23 8:16 ` AngeloGioacchino Del Regno
2025-09-03 1:50 ` Rob Herring
2025-09-03 4:10 ` Chen-Yu Tsai
2025-09-09 12:42 ` Matthias Brugger
2025-09-09 12:42 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6402ac5-114f-415f-ad79-4f523c601126@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Ben.Ho@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@kernel.org \
--cc=fparent@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®