From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55481C00140 for ; Thu, 18 Aug 2022 14:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245523AbiHROoi (ORCPT ); Thu, 18 Aug 2022 10:44:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240240AbiHROof (ORCPT ); Thu, 18 Aug 2022 10:44:35 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FAF130F53; Thu, 18 Aug 2022 07:44:30 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 7702922239; Thu, 18 Aug 2022 16:44:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1660833868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o8TzLOIHkA9jPFBeoLG9hbRTDArAPujE1v/yZsjtRfM=; b=Gw8z/bD59+WbiyvzE+lONb3CQRcZyAosv/fDEYz5rgDJ1H9LmKroyyEnjiJuTzTWwtUcY8 2LkwFUrg2vAnFVQ8qndULgAtR/MqFzKxB9U7V2V5smh8MtNbaoqSHantbVV0YdgyE0Ih9D 69DxV0pIo86vRtx//sIros1E5u/SBH8= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 18 Aug 2022 16:44:28 +0200 From: Michael Walle To: Vladimir Oltean Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, Shawn Guo , Li Yang , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH devicetree 2/3] arm64: dts: ls1028a: mark enetc port 3 as a DSA master too In-Reply-To: <20220818140519.2767771-3-vladimir.oltean@nxp.com> References: <20220818140519.2767771-1-vladimir.oltean@nxp.com> <20220818140519.2767771-3-vladimir.oltean@nxp.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-08-18 16:05, schrieb Vladimir Oltean: > The LS1028A switch has 2 internal links to the ENETC controller. > > With DSA's ability to support multiple CPU ports, we should mark both > ENETC ports as DSA masters. > > Signed-off-by: Vladimir Oltean > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 3da105119d82..455778936899 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -1170,6 +1170,7 @@ mscc_felix_port5: port@5 { > reg = <5>; > phy-mode = "internal"; > status = "disabled"; > + ethernet = <&enetc_port3>; status should be the last property, no? -michael