From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933741AbcLIOiN (ORCPT ); Fri, 9 Dec 2016 09:38:13 -0500 Received: from mout.web.de ([212.227.17.12]:65080 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933154AbcLIOiL (ORCPT ); Fri, 9 Dec 2016 09:38:11 -0500 Subject: [PATCH 3/4] staging: greybus: light: Check return value of a kstrndup() call in gb_lights_light_config() To: devel@driverdev.osuosl.org, Alex Elder , Greg Kroah-Hartman , Johan Hovold , Rui Miguel Silva References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Fri, 9 Dec 2016 15:37:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:YgsLlzIZ7Kypk7kNz7T9ZMFkPG3sip1Aufh/poPl0GdEpT/CHEu FSe9r4Mx6Z2+exITZ47WaupSZiwLlqUKnhz/pW9Vz+TJOZ2lwnmvVwJ9hp9ZlBW0z0cIAP5 DBsdRPDSwSEuYUobvKopG7baIukyRgz+oGuCalWaCx6/N+Zm1VwBSGKn6uaJiJsBr/Ge1t2 4MiAgArZbNHYusuUS4GqA== X-UI-Out-Filterresults: notjunk:1;V01:K0:4I8zzzeEd7Q=:NnVOoA4HC3MVwxSg+zn9ZU h8PtRvyrQVRG46Wvo/IM45KICQNxdCbH5AhKhnrfu2wRvLoqiDRUZbsvvONGrmpo0aHynSluK ZsUiqoFeGVcWG50jbOB36dkRgeQzz1nEaOtQOYiVD0uLSG04pvZbr6e0JJU2Dvg1I7ye/N7qx KpzIbPInbf2GnczH75fK7LqBSrF0CYruR3otGH4AF9m7kHqcvkgfvdJXcerxPN5E9aOItRfw8 u+HNLziYD2zFqWepq5Ox3q0VvQ3dfzbGCt6gk8mHj+X0iQ4xiFbYvzC5UJrYTXBq9lSF++G7g YUJpqrc5JXW8vMNfeWuihujHyBD062YnoeA14J2Z8S+KMEw5rZxF6EtTquxwUvRYdY1rZUy4z MTCdIVwOm7EHAXyowtZmFW/Ez9GxWiwtgY3zIHaJ/t4y70SZL0mbcKAr3cXu6XTWYZX/S0Gtq s5wilUv4xv3KtbAS9q7aQQgXbdLLSJ+ZHTaYBp4+ztFz+FmS6ugfmtvANYi/Iq6dSmP7eSox6 vKFNBvA/zs+cB7Wk2o0dD7ZUd8iq2TI1IOYPq4ZBUkoIAw0WrgEL9FDGw/dZO605C3RAhYqn1 hrcXcCYykGKRmtFy4uq4Ef1HuTe/eZJ22SfRmHxBWCYLdV+ds5r714Cl0EjCR/yEAtga4sLMY 6bKMIVw1xclfPkwinZ3398eQygiIjUMYAbSlBFgdmXCzlUddb2Y5jAKcgSiZ+QAJWeRKCt8TL pReL4j8dagq7MdGTgQRJld14Z/XRyyESRaVjaUIy3mtTAv6Y/kEWrkE5KecJgy+Ll55TTFPB7 /zKLuq1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 9 Dec 2016 14:36:16 +0100 A return value was not checked after a call of the function "kstrndup". This issue was detected by using the Coccinelle software. Add a bit of exception handling. Fixes: 2870b52bae4c81823ffcb3ed2b0626fb39d64f48 ("greybus: lights: add lights implementation") Signed-off-by: Markus Elfring --- drivers/staging/greybus/light.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 27bfc20eb9a5..c9c377f40f56 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1030,6 +1030,9 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) light->channels_count = conf.channel_count; light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); + if (!light->name) + return -ENOMEM; + light->channels = kcalloc(light->channels_count, sizeof(*light->channels), GFP_KERNEL); -- 2.11.0