From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67C9938FB0; Mon, 2 Sep 2024 15:31:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725291120; cv=none; b=fDFfdVr2DmSMXubO2NMVQDoEbNqGgTUtH9mbY59VfbFWkDUUGeDgP+OSTE/kC91k5CCHsmcA1K/TcvoesxrMJq3iAMThBqP4kdg923yaC2OTP7oXe4QZfy2lbKpMlzkecgw3X9EfVfI5bbv7/r8mM20mVmacNF5IhH/DhLEtFOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725291120; c=relaxed/simple; bh=DRcS/eDXPxHpY5M/LuFQM13QEB+saRntbeQcU1Jk7ks=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=OCXiZzFtV06eRQYFhsi4niXgqEpcGX9qIta98RUKOxIZX/GsEfkLOCkyFwB3Uo04Vu4K/qM4aUCTE0CzgSECPnylD9/QSBl+IC/cwYuRLz2bimSBrKCJKICuZTs85KvkyuhMLPLmDmvjaobkavUkhHaKZxh7DVkyJ2Rzc/G7bik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RFMDEdhk; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RFMDEdhk" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52f01b8738dso3103838e87.1; Mon, 02 Sep 2024 08:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725291115; x=1725895915; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=1lEAaITg61rMOKoeV9sGqIv6NT56UG0eY9VP45Si6Hs=; b=RFMDEdhkIOQZ8uj68lLjoKioN+7zvdVdCunb99DWu54BI6klyR1e9G5Quc/bDu/d4S 1dExMkQhKU+Ons+ilHTROoIGUOiI0NdHDJCvsxiCtcAYFXp320MQvgXSJKkX5uG8cdNg guFEp3iixGOdd/scmHLj3kI/7a1tz1Cew4eYPRwbrRa/+jG8vKiO1PVsUXNQzzsIEizu eU807uR57sXHx1DpqiYwjodQf8ten9NsjQk97dbbYnuOU62XB4lYo9DfiyxKY+Xzn1ps 5xaH/yySkbknsBmM92we9uNioq+3gSY9x6FF/9y6JXlab08VYgN3j7Ka2BG7AHEwnsuF ZJuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725291115; x=1725895915; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1lEAaITg61rMOKoeV9sGqIv6NT56UG0eY9VP45Si6Hs=; b=J79DkCMcWasQb9R8d2MDCTavbd7zaDKIpOWsFBowa2G/WZ9aX39UR5bjLno2Ktv/tc K+ytYXSvbcWpYHkcBUqV4LFUijM/2hztTaxQBoGf3d4NFiQhI2r2Vv3dbiIGKcmQleSI 8L6N0wZuCQX3U1L9eS5L6j7Uq5GpsgGStI7hdA0MxB/zuFzk/5oPGTsmWszgGHoAhaKF 5GaEF7UJg4NNosZ36mhGN5RMCbbCiBgp186BVE3EcAdmGmejDdokoJn2e5g0/39s+86n drxw3fal7gSXqen12NFLpfqUgLE+fWEgLbLzIpJa5NF8/VN2lMM236sWqv5lR1WA9zbG g/qA== X-Forwarded-Encrypted: i=1; AJvYcCXR8B64K3J9GhQzhw6Gbi6p+oyiHjyeDAkn6bqlSfuiecZ2rkCKTmq4g+nwYrgKD0ID+azSdeXxzvKb9OE=@vger.kernel.org, AJvYcCXw/y6tgYzOEDdZqeK7jcQXySHn3mnhiMRgFgMZkBaUhUZ5uOmUdEVEsoXH0FJaDXDcLNTHcUcu4kkPqf0=@vger.kernel.org X-Gm-Message-State: AOJu0YwF7ZyLTdefZUyKuVDYOfUFtto3zEHaFXWGSfHcD3lU13Cnk95f /UxD2alPcFZEqhgW+hRN33DhOFDeJwn84BqQMwg7SY9Ua/V4zq6Z X-Google-Smtp-Source: AGHT+IGYGf8VX7LIcYOgdyPmt731pfn6LVYofo2CruraVVYwx7aQjpnX8k6VgUS23jgFdINd2tm2Fw== X-Received: by 2002:a05:6512:a92:b0:533:77d:1176 with SMTP id 2adb3069b0e04-53546af3011mr6978933e87.4.1725291114527; Mon, 02 Sep 2024 08:31:54 -0700 (PDT) Received: from [192.168.0.20] ([148.56.230.39]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8989233403sm569728466b.212.2024.09.02.08.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 08:31:53 -0700 (PDT) Message-ID: Date: Mon, 2 Sep 2024 17:31:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] soc: mediatek: cmdq: Remove cmdq_pkt_finalize() helper function To: Chun-Kuang Hu , AngeloGioacchino Del Regno , Mauro Carvalho Chehab , Moudy Ho , "Jason-JH . Lin" , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20240901143259.16849-1-chunkuang.hu@kernel.org> <20240901143259.16849-4-chunkuang.hu@kernel.org> Content-Language: en-US, ca-ES, es-ES From: Matthias Brugger Autocrypt: addr=matthias.bgg@gmail.com; keydata= xsFNBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABzSlNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPsLBkgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyyc7BTQRd1TlIARAAm78mTny44Hwd IYNK4ZQH6U5pxcJtU45LLBmSr4DK/7er9chpvJ5pgzCGuI25ceNTEg5FChYcgfNMKqwCAekk V9Iegzi6UK448W1eOp8QeQDS6sHpLSOe8np6/zvmUvhiLokk7tZBhGz+Xs5qQmJPXcag7AMi fuEcf88ZSpChmUB3WflJV2DpxF3sSon5Ew2i53umXLqdRIJEw1Zs2puDJaMqwP3wIyMdrfdI H1ZBBJDIWV/53P52mKtYQ0Khje+/AolpKl96opi6o9VLGeqkpeqrKM2cb1bjo5Zmn4lXl6Nv JRH/ZT68zBtOKUtwhSlOB2bE8IDonQZCOYo2w0opiAgyfpbij8uiI7siBE6bWx2fQpsmi4Jr ZBmhDT6n/uYleGW0DRcZmE2UjeekPWUumN13jaVZuhThV65SnhU05chZT8vU1nATAwirMVeX geZGLwxhscduk3nNb5VSsV95EM/KOtilrH69ZL6Xrnw88f6xaaGPdVyUigBTWc/fcWuw1+nk GJDNqjfSvB7ie114R08Q28aYt8LCJRXYM1WuYloTcIhRSXUohGgHmh7usl469/Ra5CFaMhT3 yCVciuHdZh3u+x+O1sRcOhaFW3BkxKEy+ntxw8J7ZzhgFOgi2HGkOGgM9R03A6ywc0sPwbgk gF7HCLirshP2U/qxWy3C8DkAEQEAAcLBdgQYAQgAIBYhBOa5khjA8sMlHCw6F9kUC7JWEwLx BQJd1TlIAhsMAAoJENkUC7JWEwLxtdcP/jHJ9vI8adFi1HQoWUKCQbZdZ5ZJHayFKIzU9kZE /FHzzzMDZYFgcCTs2kmUVyGloStXpZ0WtdCMMB31jBoQe5x9LtICHEip0irNXm80WsyPCEHU 3wx91QkOmDJftm6T8+F3lqhlc3CwJGpoPY7AVlevzXNJfATZR0+Yh9NhON5Ww4AjsZntqQKx E8rrieLRd+he57ZdRKtRRNGKZOS4wetNhodjfnjhr4Z25BAssD5q+x4uaO8ofGxTjOdrSnRh vhzPCgmP7BKRUZA0wNvFxjboIw8rbTiOFGb1Ebrzuqrrr3WFuK4C1YAF4CyXUBL6Z1Lto//i 44ziQUK9diAgfE/8GhXP0JlMwRUBlXNtErJgItR/XAuFwfO6BOI43P19YwEsuyQq+rubW2Wv rWY2Bj2dXDAKUxS4TuLUf2v/b9Rct36ljzbNxeEWt+Yq4IOY6QHnE+w4xVAkfwjT+Vup8sCp +zFJv9fVUpo/bjePOL4PMP1y+PYrp4PmPmRwoklBpy1ep8m8XURv46fGUHUEIsTwPWs2Q87k 7vjYyrcyAOarX2X5pvMQvpAMADGf2Z3wrCsDdG25w2HztweUNd9QEprtJG8GNNzMOD4cQ82T a7eGvPWPeXauWJDLVR9jHtWT9Ot3BQgmApLxACvwvD1a69jaFKov28SPHxUCQ9Y1Y/Ct In-Reply-To: <20240901143259.16849-4-chunkuang.hu@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/09/2024 16:32, Chun-Kuang Hu wrote: > In order to have fine-grained control, use cmdq_pkt_eoc() and > cmdq_pkt_jump_rel() to replace cmdq_pkt_finalize(). > > Signed-off-by: Chun-Kuang Hu Acked-by: Matthias Brugger > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 22 ---------------------- > include/linux/soc/mediatek/mtk-cmdq.h | 13 ------------- > 2 files changed, 35 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index a8fccedba83f..2a47dda4dd4a 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -538,27 +538,5 @@ int cmdq_pkt_eoc(struct cmdq_pkt *pkt) > } > EXPORT_SYMBOL(cmdq_pkt_eoc); > > -int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > -{ > - struct cmdq_instruction inst = { {0} }; > - int err; > - > - /* insert EOC and generate IRQ for each command iteration */ > - inst.op = CMDQ_CODE_EOC; > - inst.value = CMDQ_EOC_IRQ_EN; > - err = cmdq_pkt_append_command(pkt, inst); > - if (err < 0) > - return err; > - > - /* JUMP to end */ > - inst.op = CMDQ_CODE_JUMP; > - inst.value = CMDQ_JUMP_PASS >> > - cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan); > - err = cmdq_pkt_append_command(pkt, inst); > - > - return err; > -} > -EXPORT_SYMBOL(cmdq_pkt_finalize); > - > MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) driver"); > MODULE_LICENSE("GPL v2"); > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index 5bee6f7fc400..0c3906e8ad19 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -391,14 +391,6 @@ int cmdq_pkt_jump_rel(struct cmdq_pkt *pkt, s32 offset, u8 shift_pa); > */ > int cmdq_pkt_eoc(struct cmdq_pkt *pkt); > > -/** > - * cmdq_pkt_finalize() - Append EOC and jump command to pkt. > - * @pkt: the CMDQ packet > - * > - * Return: 0 for success; else the error code is returned > - */ > -int cmdq_pkt_finalize(struct cmdq_pkt *pkt); > - > #else /* IS_ENABLED(CONFIG_MTK_CMDQ) */ > > static inline int cmdq_dev_get_client_reg(struct device *dev, > @@ -519,11 +511,6 @@ static inline int cmdq_pkt_eoc(struct cmdq_pkt *pkt) > return -EINVAL; > } > > -static inline int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > -{ > - return -EINVAL; > -} > - > #endif /* IS_ENABLED(CONFIG_MTK_CMDQ) */ > > #endif /* __MTK_CMDQ_H__ */