From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65C6E3CB910 for ; Tue, 12 May 2026 21:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778620030; cv=none; b=agZyra31Slif3tQp5gHWOWLAO7sWZ6tmwRsfuRJF/bfT4ZHdSOxZsvDJA3fDZO9GNfs9kZAGMOLyCk6EZIWhIERu1Lsk7mmz0lI5dXEAQf3607XcoDp8mgzywqRuMXbDhUtjVQBOCFo+r24MpS20ajXxzV0mRsae/LAqKIaxaHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778620030; c=relaxed/simple; bh=qkFNOprhooUNjKQ1PSjbgi8DkKCpI8tpPK659v+JSEw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eNgccZD44l08NTg+8IQQr4b/lUZTRrg6jW7rOMSDG50QcGXqdpjPFc/2MCnPNnaUiYFoEQcyamzcw2fOl2YQYgLEXgvU0mrXot+TIwpNQ7AzAkuCAAkFtk80n2n1XHjY/FfVoyT5Hjqyh4fs6c3t9taWF82UlBkYBvlS+HfA/pA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aZ+Eg4Tw; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zknx/kHL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aZ+Eg4Tw"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zknx/kHL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778620028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nFn1v/uAu4PP6s5g6sRwXKMfyXh1YJ87r2wzrnOTcOk=; b=aZ+Eg4TwJ/pME31dLRK1LGV3bldQHgLDA7rlwthNu7jFNJ4ItjO+PH82TzOt5WD2hsccCH ze8/gnJMZALD7HtDRFECAoGoKvjSs13zkJX4IBdtlhpzxRIkTaubSPhk9kREqzErM+usiL uudelBK5BT9ZaVnPCdAp5yBpNM4kR24= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-SVXZCzvMNsacwozJFbkKvQ-1; Tue, 12 May 2026 17:07:07 -0400 X-MC-Unique: SVXZCzvMNsacwozJFbkKvQ-1 X-Mimecast-MFC-AGG-ID: SVXZCzvMNsacwozJFbkKvQ_1778620026 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488d8deb75fso46034285e9.3 for ; Tue, 12 May 2026 14:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778620026; x=1779224826; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nFn1v/uAu4PP6s5g6sRwXKMfyXh1YJ87r2wzrnOTcOk=; b=Zknx/kHLvWTgPHhp/GGWdtdnQvrIy5r9SAn/StpJiJ29CBcGdmjKDOGWrknVTZkomI uCtf1rq25Cm3suMObbBHwaZq9ccEeQH5aw6FbQsiALezbWSd/GC5L/Phocjf11DZF0Yk Hhu4cuNDwxLVX4b0sNJZmTHP7tKH8fNtR9/6XULMhic3zioNjAKBdCRf6NsZqd6wpqsQ blG9Hnla3w/u8juvBr/lzXeA8/QcCPnMQESY3vRSGT7tItbMEtIxy08gP1Xvsebp1dHO 9KrM2A94N5V1k7iJJtnYlliUWz2ZqzjPDRQxzLbARHPGNcM98ksw/A9EzDA5TnLensuO B/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778620026; x=1779224826; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nFn1v/uAu4PP6s5g6sRwXKMfyXh1YJ87r2wzrnOTcOk=; b=FvMpFRKEDoVBxwvSPOkWfQUEw34Weul9WYSPXQbithyMG6a4kop7LJa+iiAJHwKwWe nzIsmym1bHvITIIuqdwMfzRmofrWLTQAmH8QANb2Rey+VXSvuw6DD3ObJSJ3SkZGZesG JhoIztSeDmuX4CjHHDtNnVdKIPXz9t1YqLeB0f+9wpnv2eEZPRZuC76P9iNKSrSKO2b6 R7QRGIIc+dmlWgNepxMZ1567rvzx/g6MWf1oAzMLXpwpupj8xj5B9MjvPMGxh1yfgSp0 mK8JNqlxoEjaFMuy3Ez3YkCNmuUnKyGsIyC5BZQL/7jLZoaMBZoKFsG/TrPuv+D3vuLm VaTA== X-Gm-Message-State: AOJu0Yy65XR71/WXc3kKeGpy2EJ/jEI74S5zRt3ANHg0Omf4aB3z2OXw 3+KzzVA9FCumIrY/SvflkZxPO1hki+7LNQx7n+ExpOy/XAGWCOjdkncQge1ltD6y763y9T6mMnc w+dWfzjLZYbLrxQYtR/RAagK8QJnu5zqUrsNy+3ACi6LI6UDk2CXjb7Uc1pTcdT6Agr/xry3WML IM+rDii1M/bkz8WSc3wLzpw8erA4dXwdDOQl9ES+KYbBs= X-Gm-Gg: Acq92OHpd+J+srV1C0RpnRfvjm6dck1GhY5EIgvhqRLg8r8qS0lCnx7VFJceQM/+pil fryy1CFU+vgCeJ30qNzMs6fWTDJVflDh0KcPzrruyiquDHE/IW+lTyra7P0ieRw5/tAPWOi8inR hbvsDmfwBUZP5Fc9CjNAncqP1mxRTfyx0OwigavyzAWO7lDPxVhYk3uSI/w7uRQ9AiQSJ3PbKkF EzTbEdQ/HI5m5Xey7b7VOSEHaZ2+dHtVZh9DT2Ti+WfzKaOO6aF2tZvRUaDViHox0t4z5AWgVOa HsU7asvJ4EWwuUDoLUOmT4HOohVuYm6EcT3J1x20bFxJZ6Ktr9jy5dMiZnED8oVHhxOjFH36uRh +G6zQhpeoGy7B4K55Lx0Fy0DeIbJyOo/EnCOLDEA9 X-Received: by 2002:a05:600c:3b20:b0:487:2439:b7c8 with SMTP id 5b1f17b1804b1-48fc9a029d4mr6486475e9.1.1778620025581; Tue, 12 May 2026 14:07:05 -0700 (PDT) X-Received: by 2002:a05:600c:3b20:b0:487:2439:b7c8 with SMTP id 5b1f17b1804b1-48fc9a029d4mr6485625e9.1.1778620024852; Tue, 12 May 2026 14:07:04 -0700 (PDT) Received: from redhat.com (IGLD-80-230-48-7.inter.net.il. [80.230.48.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f42a845sm24872145e9.20.2026.05.12.14.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 14:07:03 -0700 (PDT) Date: Tue, 12 May 2026 17:06:59 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v7 21/31] mm: page_alloc: clear PG_zeroed on buddy merge if not both zero Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent When two buddy pages merge in __free_one_page(), preserve PG_zeroed on the merged page only if both buddies have the flag set. Otherwise clear it. The merged page would inherit PG_zeroed, and a later __GFP_ZERO allocation would skip zeroing stale data in the non-zero half. Signed-off-by: Michael S. Tsirkin Reviewed-by: Gregory Price Assisted-by: Claude:claude-opus-4-6 Assisted-by: cursor-agent:GPT-5.4-xhigh --- mm/page_alloc.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index bd3b909cacdf..d70c9ba6b329 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -940,10 +940,14 @@ static inline void __free_one_page(struct page *page, unsigned long buddy_pfn = 0; unsigned long combined_pfn; struct page *buddy; + bool buddy_zeroed; + bool page_zeroed; bool to_tail; VM_BUG_ON(!zone_is_initialized(zone)); - VM_BUG_ON_PAGE(page->flags.f & PAGE_FLAGS_CHECK_AT_PREP, page); + /* PG_zeroed (aliased to PG_private) is valid on free-list pages */ + VM_BUG_ON_PAGE(page->flags.f & + (PAGE_FLAGS_CHECK_AT_PREP & ~__PG_ZEROED), page); VM_BUG_ON(migratetype == -1); VM_BUG_ON_PAGE(pfn & ((1 << order) - 1), page); @@ -978,6 +982,8 @@ static inline void __free_one_page(struct page *page, goto done_merging; } + buddy_zeroed = PageZeroed(buddy); + /* * Our buddy is free or it is CONFIG_DEBUG_PAGEALLOC guard page, * merge with it and move up one order. @@ -996,10 +1002,17 @@ static inline void __free_one_page(struct page *page, change_pageblock_range(buddy, order, migratetype); } + page_zeroed = PageZeroed(page); + __ClearPageZeroed(page); + __ClearPageZeroed(buddy); + combined_pfn = buddy_pfn & pfn; page = page + (combined_pfn - pfn); pfn = combined_pfn; order++; + + if (page_zeroed && buddy_zeroed) + __SetPageZeroed(page); } done_merging: -- MST