From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011030.outbound.protection.outlook.com [40.107.208.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DE2F382373 for ; Thu, 12 Mar 2026 09:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.30 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773309566; cv=fail; b=W5eghSVVh+Z9OOmiOgcw5uSbJAtRYw/tJecc8XQDJ0ipwXSxtZcwjWTqZmnkBVhck/s990MnO4Duray/J6yzlddrkmEyEyj1GdnZvbzTr8/T2PfAKg2rYZ3BMSu8L8RYcEb8YmOSG9qgTgr83KRj09Ru1vyVvk/EUoLeUxn2XeQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773309566; c=relaxed/simple; bh=pobxLItZJDHIjWQs+qDxNIjfjlD2uY+1PXziKLHdcxA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=C8/tf+a320gl30nZbzxKn2OPdXzG66TQVFabB4Sm1TbP6mz879Rr38o2Bo9ygl+MCIVy5FXPR4dZBgtGQl5dUg5Lq3MJTSeNgTFM2PsXWB9vgS3/Rte/WmogfuHa9ZKoLuOHkRoqr5T9YzqYp18078l1QUSs/dW1eAdvNDJt20M= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=qbGQ1UEL; arc=fail smtp.client-ip=40.107.208.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="qbGQ1UEL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uHAaGGuNbW36a2I+Pk8aNpXImUUnY2JpGtOeM8GYvcaAAiFPjuGBgMbMRPILEzG2M0xsowJfhxLT2hoxbBWqc+brVNExE/GEAx/7J/Xp+DT0DxxS7e0gguKcuHkdOFmqhQOcC/Tscl0jp7C74vQblQ+tK5AWJZn7ASddMDWuk19TsTtFGXr8FJv6v7uBrLqjJe5J73PTZvlmwmspSeGOcFGakULX1IPzzc53ZPDVmhtx02a66bUqra254FezxJ2aRGHT4+7oa4DQ7lkwkQWRTRSSpnro5cTXQOwdJHgOozaf6MHXq3N7+F5ixP0mrTInjg0biAi6d1bkwxsttxut/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L8vm2WT39KLEabSykUZUUSSCXYWfZk6mhD/1tXuUkEw=; b=sn5OlfiBFscvcRtj0N+11SihiI09GAsXAKLY2kK2d9poEq9ia7CFnfTp7BNEba7aTkVi8Z/lCGBAeL3L9AyIj1Q10acdI48Wjx3uj8khbpVwJxLASgWZAoUmrfSvypkWvkSqLWb+bytGku6iGRoq2bP7wFa/3u39DWe7si+p+28lMiWvl+7JzKI0DzhXErwwuC4VSEjg2XCqmg/+HtRNBXsJMfl4xVzonWXRAqPn5UjcFVAX2igx9eg58/1yNKfKNwdrLscWkI5lpAI+p+IKxpc6Sgeo6yCi3KBToWNTFHbqHIr0u3/QQypxTNWxEyK9JNfFUFoQiyFaajZtXkiOYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L8vm2WT39KLEabSykUZUUSSCXYWfZk6mhD/1tXuUkEw=; b=qbGQ1UELC9xTtf1DdiWC5fHMWTZmlssFDdRAz9ginQmOTlPDLm1CieIg8xDJfKd2fIrBk9OjWO8NFS8SeUGHyEiOjGIKczgK5MMDNtepk+1qPBFmFKKCdinDmIaQzLw9DDFf9Nt3ZIDiGOOJYMq7zzw6UwCSpZOuV0V9V7jblag= Received: from CH2PR20CA0022.namprd20.prod.outlook.com (2603:10b6:610:58::32) by MN2PR12MB4454.namprd12.prod.outlook.com (2603:10b6:208:26c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.11; Thu, 12 Mar 2026 09:59:19 +0000 Received: from CH2PEPF0000014A.namprd02.prod.outlook.com (2603:10b6:610:58:cafe::14) by CH2PR20CA0022.outlook.office365.com (2603:10b6:610:58::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.27 via Frontend Transport; Thu, 12 Mar 2026 09:59:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CH2PEPF0000014A.mail.protection.outlook.com (10.167.244.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Thu, 12 Mar 2026 09:59:19 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 12 Mar 2026 04:59:19 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 12 Mar 2026 02:59:19 -0700 Received: from [10.136.39.20] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 12 Mar 2026 04:59:15 -0500 Message-ID: Date: Thu, 12 Mar 2026 15:29:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] sched/topology: Compute sd_weight considering cpuset partitions To: Peter Zijlstra CC: Ingo Molnar , Juri Lelli , Vincent Guittot , Valentin Schneider , , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Chen Yu , Shrikanth Hegde , Li Chen , "Gautham R. Shenoy" References: <20260312044434.1974-1-kprateek.nayak@amd.com> <20260312044434.1974-2-kprateek.nayak@amd.com> <20260312093428.GX1282955@noisy.programming.kicks-ass.net> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260312093428.GX1282955@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000014A:EE_|MN2PR12MB4454:EE_ X-MS-Office365-Filtering-Correlation-Id: ba59302e-ea8c-4809-8bac-08de801e0783 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|36860700016|1800799024|376014|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: S51FnlAsQ5iH37vXwIgNyTYj6BSXNtONRpnzmbWH1T/2rOFUHyLNZJu3jksxi5OKSQPI33y+d+y+QELDrdm1+6XmddKPAcU5WbMhn3CtQG80fZ69FEMUXjkn5YLepswoyaHFjeDw1f4eh1DPXrFxHhM1bh3wqAY3U7Xc7HQ8zekNUq6XG6jNOCM/+obwA/9akDwlHXo+5/wp847uBniwsisbJmHirTkQNElbLEC6rdMyHrc4O7tzmSVvoZz5tXIshYK9vfRez9qCG26hbgKBXebNBXlQc0DxG0GRSt31rWSs7zfWKxtCf7GUpkXN8lkoSepPg1nte3D2DH/0WX4Mmbua8YDvZcJlsr/+oX8ZE1FGrphJpWvSG+m5lWId6PEXvfZfXhyluS68BjlwVHBIb5McMkUvXXysHpIUY5W+fwkD2iduihK6/dQA3UU/d2geDIL2xU1/zanPVdZ5MGFFfjo9hrKeHxj0r/OcvYVFmVIbbvg5fXfn+gnlNvkfz7VAsDhnKTYFzWJKvaT8YbKBgnCOdONemg39T34rSNY2foNbs7LX7BOfhOb6TISwboV5HJrUfkEUy4DgZxdHwY7k0/YvTfDXbqEJaAlF+BBJsS70Q7ti7/v4weeGH2QyLzHabP4Q0dwPEfBp3aq3tVnA9s1OZRNIhQd1UFPMeBHpxmG08YtiC/LB+67UE4JzlKESNSAD8Bhnd1YdHycesBTixUs/F0TgTINtV4Qo1dv7b+NUDc2L6VkpnrsRb5NnLIv5cbZeUBlT8GDcfz+ZoMAZYg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(36860700016)(1800799024)(376014)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qHdWvUj7ZjL/Y2AQ4gAqAwt4Abc1NjYiJ7ldCAArTtOhtikxIZquJ8PGeKyZ25rUlTS3wMzMzOBIeysFikCVlUb8H6Zh6W3tVY0w0VACMtH7gVxTbGtlWIt+dsekx3KDM84mTkFSGEbWE41tDySLdnbVcT9bq3YN0mbg57HXYK1SvHCPwjU9oBkvmUbl8+pN3mEuGEYtFHcu3vom5VCc8KmXwjpQadeuFxrZxrTK/wNOE1uI2KBCQAlqhZGJu6/Qj8g2pBN/EfrGu51C1MJAebPKGGnxu17xjjqOWgwmW5+4YRVOn5QPh8yPtqAEhtu61ZnOjccA28OBNYtTNLbP4Zx4HH7mHSgPcFoRk/pbPzoOtWINdOMBQM3lA9gdoHPTBtP8b4pO8fDd9qstc7glPc5QxfTXU+qI8wLbRcLJZS3b60TlkY+3FwRsmRx20/do X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2026 09:59:19.6051 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ba59302e-ea8c-4809-8bac-08de801e0783 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000014A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4454 Hello Peter, On 3/12/2026 3:04 PM, Peter Zijlstra wrote: > Why not like so? > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 061f8c85f555..79bab80af8f2 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -1645,13 +1645,17 @@ sd_init(struct sched_domain_topology_level *tl, > struct cpumask *sd_span; > u64 now = sched_clock(); > > - sd_weight = cpumask_weight(tl->mask(tl, cpu)); > + sd_span = sched_domain_span(sd); > + cpumask_and(sd_span, cpu_map, tl->mask(tl, cpu)); > + sd_weight = cpumask_weight(sd_span); > + sd_id = cpumask_first(sd_span); > > if (tl->sd_flags) > sd_flags = (*tl->sd_flags)(); > if (WARN_ONCE(sd_flags & ~TOPOLOGY_SD_FLAGS, > - "wrong sd_flags in topology description\n")) > + "wrong sd_flags in topology description\n")) > sd_flags &= TOPOLOGY_SD_FLAGS; > + sd_flags |= asym_cpu_capacity_classify(sd_span, cpu_map); That can work too. Since sd_span is is just a variable array at the end of sched_domain, it shouldn't be affected by the assignment below. I'll update this in the next version. > > *sd = (struct sched_domain){ > .min_interval = sd_weight, -- Thanks and Regards, Prateek