From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B56EB64D9 for ; Thu, 29 Jun 2023 11:39:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231653AbjF2LjH (ORCPT ); Thu, 29 Jun 2023 07:39:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbjF2LjF (ORCPT ); Thu, 29 Jun 2023 07:39:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1A9110F0; Thu, 29 Jun 2023 04:39:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F94A61534; Thu, 29 Jun 2023 11:39:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD05BC433C9; Thu, 29 Jun 2023 11:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688038743; bh=ZC+wZcsNqTKU5rNSzVYdvo0zLQKLbGqao3ypI8BdBE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jWkoWDbBBcpFOLjtTNnyd7FR1EivjbdWs6gBTaqni4KaZqF/ruLkyUVmsD7MpURYP rXIN6812xuvPL8rk0LvfkXPuPpUz1hQpXTXa4FmQwwGc4RRFqK4mmMMTzeIArd67oU QZcm5IUq/AQMmKyNc3fMndC2bFEoYx2awCnLw3/Ev1c/+YT6650iKtBTNj/dBdVdve X+Ud11/lJBD+QtlrGrRW9J3zz5XHuwXazBHkZmMxBt9V+251CtV1rkc5Im8D16te6T F05OsCRJG8fdaGAvxfw/oT3wVHmryquRfhTQ94WLRfDU/zi2YD5TLF+jkUPnjwvNgW RVeTq7plHPfAw== Date: Thu, 29 Jun 2023 12:38:57 +0100 From: Mark Brown To: Shengjiu Wang Cc: tfiga@chromium.org, m.szyprowski@samsung.com, mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 4/6] ASoC: fsl_asrc: Add memory to memory driver Message-ID: References: <1688002673-28493-1-git-send-email-shengjiu.wang@nxp.com> <1688002673-28493-5-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FP1aqfO0iq4vQLEp" Content-Disposition: inline In-Reply-To: <1688002673-28493-5-git-send-email-shengjiu.wang@nxp.com> X-Cookie: Surprise due today. Also the rent. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --FP1aqfO0iq4vQLEp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 29, 2023 at 09:37:51AM +0800, Shengjiu Wang wrote: > Implement the ASRC memory to memory function using > the v4l2 framework, user can use this function with > v4l2 ioctl interface. >=20 > User send the output and capture buffer to driver and > driver store the converted data to the capture buffer. >=20 > This feature can be shared by ASRC and EASRC drivers >=20 > Signed-off-by: Shengjiu Wang > --- > sound/soc/fsl/Kconfig | 13 + > sound/soc/fsl/Makefile | 2 + > sound/soc/fsl/fsl_asrc_m2m.c | 878 +++++++++++++++++++++++++++++++++++ > sound/soc/fsl/fsl_asrc_m2m.h | 48 ++ This feels like the bit where we interface v4l to ASoC should be a separate library, there shouldn't be anything device specific about getting an audio stream into a block of memory. I'm thinking something like the way we handle dmaengine here. I've not dug into the code yet though. --FP1aqfO0iq4vQLEp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSdbVEACgkQJNaLcl1U h9DmOgf/eCvmgKO/us13curwY8vW24n389PS/2sTaVssYszEQB7BvNfQV5atoKU8 Ba6RqJPl8PRNwurpLqyF4NLOA0EOlv8h0P3cCC/XZ6ticWK2lAy80EmU5XUgR742 FCzts7URNns+y3cZAepJ7a38vxNUQLJh/tbkB5aJGXr9X30sntOepWDMnUgoW4KB UzzayZWUilTjl2LYkvbiIEf8MfC7VcptLU2Y7DevFjMm27aRoV2yBreIhEbrexsW ngXnBwKOoR7SCgS68ZtsyD/RzZIeVx+mZI2/I9P0EiGXjcJnBcJAVlehJp+Wrhgl 0IHUq6WGmLFkATfM0fclKq7dykS7UA== =K8a/ -----END PGP SIGNATURE----- --FP1aqfO0iq4vQLEp--