From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86C9C433EF for ; Fri, 15 Apr 2022 21:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355051AbiDOVrH (ORCPT ); Fri, 15 Apr 2022 17:47:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356183AbiDOVps (ORCPT ); Fri, 15 Apr 2022 17:45:48 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59D7549CA7 for ; Fri, 15 Apr 2022 14:43:18 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id v12so8015437plv.4 for ; Fri, 15 Apr 2022 14:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zQtVzR+qX7thidCkrKxZWal2lu7IMO3a3sTmsXDOSnA=; b=EVnLlP5HvcQ7mfMWcKBySfBzKktk4RuTNYJFYZGC7GP2b6ckxKgNRBH4W6ma4vs/9d 5ARTSlkDusrXNDfgVpN9vPEMuSy1WevbRS4d78goN03mGRJ2DvOE+UkehyNBAEsC4qZs m82DsvDgvdTXKFjUNU1v0BWZnpfCZm7ixqKm6+RehaHI3auKeorhGY77XOPvnT8q/1id WbyzxnyImFI+ry+t+EGs9zqk4ZOvldQEqvOF05n0udZ8/TmSYW96FvHzC2Kz5N9vdPeh a8xY42Zdv6fvx1ZIePEdVNUoNRe39dXN60QhRCX/hd7NHgUABc5qJttmp0NiRCYEMnv1 N4iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zQtVzR+qX7thidCkrKxZWal2lu7IMO3a3sTmsXDOSnA=; b=ubzNu6XYrCOwvbAKJHP0lqzsN+r40UnvkSQT32AxgOs+DKEzyPq7SqFgDZZG/SAmzT az3uiXGyW27xyegJ0qt1tp+Ijx3tRbtJBFLDegegb0NmhD6t4o0JogVuiELYcpUhw6G7 FPNjfsIewmq2uNm6ju3vv880gIh/Pa7SukzQckJxySDSguk0vWOKWG1pcIll/LnsRBw2 pcGrCkaOCofN45sQrSk7YioK5om+1aE0ioZC7k8AqaxZJYSljPVsop0L35Lu+aFyZF7w tnX589yj0bi3siOVEctOlWiKnJvYbkUPbN6bBgshPSw6Ynyn5947+a8ui1FNH99/OKvA eltg== X-Gm-Message-State: AOAM5327fsgrrHsJdOjTvJZqUOpm5Zz25aDEoSQwYd7Cc6I9VWd2rIU7 kdch4/ZpqPbx6nLd3bg0B8WjdQ== X-Google-Smtp-Source: ABdhPJyypS0vPqvwlpeOutgmScic8LUDanAQL6k5AZV9O6DDA/v4X8rx3sJTxfjHxTTTJ81aWvL7HQ== X-Received: by 2002:a17:903:12c1:b0:158:ad00:60e with SMTP id io1-20020a17090312c100b00158ad00060emr940315plb.62.1650058997479; Fri, 15 Apr 2022 14:43:17 -0700 (PDT) Received: from ?IPV6:2620:15c:2d:3:51d5:33b1:431b:be0? ([2620:15c:2d:3:51d5:33b1:431b:be0]) by smtp.gmail.com with ESMTPSA id s35-20020a056a001c6300b00505ff320d97sm3980753pfw.91.2022.04.15.14.43.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Apr 2022 14:43:17 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 14:43:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC PATCH 0/2] kunit: Support redirecting function calls Content-Language: en-US To: Brendan Higgins , David Gow Cc: Daniel Latypov , Kees Cook , Shuah Khan , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt References: <20220318021314.3225240-1-davidgow@google.com> <20220318092159.6f275782@gandalf.local.home> From: Steve Muckle In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/22 13:13, Brendan Higgins wrote: > On Fri, Mar 18, 2022 at 9:22 AM Steven Rostedt wrote: >> >> On Fri, 18 Mar 2022 10:13:12 +0800 >> David Gow wrote: >> >>> Does either (or both) of these features sound useful, and is this >>> sort-of API the right model? (Personally, I think there's a reasonable >>> scope for both.) Is anything obviously missing or wrong? Do the names, >>> descriptions etc. make any sense? >> >> Obviously I'm biased toward the ftrace solution ;-) > > Personally, I like providing both - as long as we can keep the > interface the same. > > Ftrace is less visually invasive, but it is also less flexible in > capabilities, and requires substantial work to support on new > architectures. The general feature looks useful to me. I'm not sure the ftrace based API is worth it given it is only offering a visual improvement and has some drawbacks compared to the other implementation (won't work with inline functions, dependencies on other features). Livepatch is absent on arm64 which mostly rules it out for my purposes (Android Generic Kernel Image testing). cheers, Steve